New issue
Advanced search Search tips

Issue 752892 link

Starred by 2 users
Status: Fixed
Owner: ----
Closed: Aug 2017
Cc:
qyears...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[WPT import] Import failed due to missing attribute 'keys' in git_cl.py

Project Member Reported by foolip@chromium.org, Aug 7 2017 
From the logs of https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/434:

Traceback (most recent call last):
  File "/mnt/data/b/rr/tmpmJaw9h/w/src/third_party/WebKit/Tools/Scripts/wpt-import", line 18, in <module>
    host.exit(importer.main())
  File "/mnt/data/b/rr/tmpmJaw9h/w/src/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py", line 128, in main
    if not self.run_commit_queue_for_cl():
  File "/mnt/data/b/rr/tmpmJaw9h/w/src/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py", line 171, in run_commit_queue_for_cl
    try_results = self.git_cl.filter_latest(try_results)
  File "/mnt/data/b/rr/tmpmJaw9h/w/src/third_party/WebKit/Tools/Scripts/webkitpy/common/net/git_cl.py", line 112, in filter_latest
    latest_builds = filter_latest_builds(try_results.keys())
AttributeError: 'NoneType' object has no attribute 'keys'

The review was https://chromium-review.googlesource.com/c/603154 and the results look good, reason for failure not obvious.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/406184028e6a8e1012caa6b5874c38f453205bfe

commit 406184028e6a8e1012caa6b5874c38f453205bfe
Author: Quinten Yearsley <qyearsley@google.com>
Date: Mon Aug 07 20:34:59 2017

Fix GitCL.filter_latest to accept None

Bug:  752892 
Change-Id: Iaf16f9e9a3a0fd751a96bf0203a360eb3f95c06c
Reviewed-on: https://chromium-review.googlesource.com/604209
Reviewed-by: Jeff Carpenter <jeffcarp@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492394}
[modify] https://crrev.com/406184028e6a8e1012caa6b5874c38f453205bfe/third_party/WebKit/Tools/Scripts/webkitpy/common/net/git_cl.py
[modify] https://crrev.com/406184028e6a8e1012caa6b5874c38f453205bfe/third_party/WebKit/Tools/Scripts/webkitpy/common/net/git_cl_unittest.py

Comment 2 by qyears...@chromium.org, Aug 7 2017

Status: Fixed (was: Untriaged)
►

Sign in to add a comment