Issue metadata
Sign in to add a comment
|
[Missing Tests]:Closure compiler build is failing in internet_subpage.js |
||||||||||||||||||||||
Issue descriptionAutomated tests for the below commit have been missing.Would it be possible to add test coverage to avoid regressions in future? CL: === https://chromium.googlesource.com/chromium/src.git/+/e713c1653fe0874061c6b0cbe038cf2eea7abb29 Ref Bug: ======== https://bugs.chromium.org/p/chromium/issues/detail?id=746234 Thank you!
,
Aug 7 2017
Also, I'm not sure what sort of test would prevent against a Closure compiler error. That really should just be part of the presubmit.
,
Aug 7 2017
The CL in question seems to have passed the closure_compilation bot successfully, see https://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compilation/builds/10092. I don't understand how it could have caused a compilation issue. Compilation errors are already supposed to block one from landing a CL that introduced a breakage, and if that's not happening, something needs to be fixed.
,
Aug 7 2017
Actually the CL that introduced the error was https://chromium-review.googlesource.com/c/576663, and it did not run any closure compilation. I am pretty sure that this is because of https://bugs.chromium.org/p/chromium/issues/detail?id=740601#c10 which temporarily caused CQ_INCLUDE_TRYBOTS tag to not work. It has been fixed since. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by khorimoto@chromium.org
, Aug 7 2017