New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 752885 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Wrong parameter name used in SuggestionsService

Project Member Reported by fhorschig@google.com, Aug 7 2017

Issue description

The experiment using server-side tiles (i.e. Most Likely tiles) revealed that the used parameter name "min" could not be used.

This is fixed on the server-side but the client still tries "min".

Fix this by renaming the parameter client-side, too.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/91d00178dfcd15890d2d7eb5d116436e6f6c846e

commit 91d00178dfcd15890d2d7eb5d116436e6f6c846e
Author: Friedrich Horschig <fhorschig@chromium.org>
Date: Mon Aug 07 15:37:40 2017

Fix usage of wrong parameter name in SuggestionsService

The former parameter "min" is ignored by the server. By changing it to
"num", the expected effects should show in our experiment.
(As the functionality is still feature-guarded and hasn't worked before,
there is no need to ensure compatibility.)

Change-Id: I3391da209c5e0a8b8fd892dd24db4d7940d470c1
Bug:  752885 
Reviewed-on: https://chromium-review.googlesource.com/597649
Commit-Queue: Friedrich Horschig <fhorschig@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492326}
[modify] https://crrev.com/91d00178dfcd15890d2d7eb5d116436e6f6c846e/components/suggestions/suggestions_service_impl.cc
[modify] https://crrev.com/91d00178dfcd15890d2d7eb5d116436e6f6c846e/components/suggestions/suggestions_service_impl_unittest.cc

Comment 2 by fi...@chromium.org, Aug 7 2017

Labels: zine-triaged
Labels: Merge-Request-61
Project Member

Comment 4 by sheriffbot@chromium.org, Aug 8 2017

Labels: -Merge-Request-61 Merge-Review-61 Hotlist-Merge-Review
This bug requires manual review: M61 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Before we approve merge to M61, please answer followings:
* Is this M61 regression? Is it critical?
* Is the change well baked/verified in Canary, having enough automation tests coverage and safe to merge to M61?
* Any other important details to justify the merge.

Please note M61 is already in Beta, so merge bar is very high. Thank you.
Thanks for the consideration!
It is critical for an experiment that is already running.
If we cannot merge, we have to restart the experiment.
As it is feature-guarded, users won't be impacted negtively.

The feature and even this parameter is tested to its fullest extend and the change here is just renaming a parameter. The worst case (e.g. a server rollback or a typo in the word "num") would just render the experiment as ineffective as it is right now.
Labels: -Merge-Review-61 Merge-Approved-61
Approving merge to M61 branch 3163 based on comment #6.
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 10 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e9db8c82096baeee1c53519355720f90097e588a

commit e9db8c82096baeee1c53519355720f90097e588a
Author: Friedrich Horschig <fhorschig@chromium.org>
Date: Thu Aug 10 12:43:13 2017

Fix usage of wrong parameter name in SuggestionsService

The former parameter "min" is ignored by the server. By changing it to
"num", the expected effects should show in our experiment.
(As the functionality is still feature-guarded and hasn't worked before,
there is no need to ensure compatibility.)

TBR=fhorschig@chromium.org

(cherry picked from commit 91d00178dfcd15890d2d7eb5d116436e6f6c846e)

Change-Id: I3391da209c5e0a8b8fd892dd24db4d7940d470c1
Bug:  752885 
Reviewed-on: https://chromium-review.googlesource.com/597649
Commit-Queue: Friedrich Horschig <fhorschig@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#492326}
Reviewed-on: https://chromium-review.googlesource.com/610045
Reviewed-by: Friedrich Horschig <fhorschig@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#431}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/e9db8c82096baeee1c53519355720f90097e588a/components/suggestions/suggestions_service_impl.cc
[modify] https://crrev.com/e9db8c82096baeee1c53519355720f90097e588a/components/suggestions/suggestions_service_impl_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment