New issue
Advanced search Search tips

Issue 752877 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 695972
Owner:
Closed: Sep 7
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 695972
issue 695902



Sign in to add a comment

Binding generator doesn't take into account of inheritance of anonymous setters and getters

Project Member Reported by tkent@chromium.org, Aug 7 2017

Issue description

Chrome Version: ToT as of 2017-08-07
OS: All but iOS

What steps will reproduce the problem?

Suppose that we have HTMLCollection.idl like:

interface HTMLCollection {
    ...
    getter Element? item(unsigned long index);
    getter Element? namedItem(DOMString name);
};

And we have HTMLOptionCollection.idl like:

interface HTMLOptionsCollection : HTMLCollection {
    ... No getters and setters ...
};

If we generate binding code with these IDLs, generated HTMLOptionCollection interface doesn't have getters.

Please use labels and text to provide additional information.

Workaround: Add getters and setters to inherited interfaces.

 

Comment 1 by tkent@chromium.org, Aug 7 2017

Cc: peria@chromium.org
Status: Available (was: Untriaged)

Comment 2 by tkent@chromium.org, Aug 8 2017

Summary: Binding generator doesn't take into account of inheritance of anonymous setters and getters (was: Binding generator doesn't take account of inheritance of anonymous setters and getters)
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d9066877c61a7b81bdebaac0a658d25eedf72b8f

commit d9066877c61a7b81bdebaac0a658d25eedf72b8f
Author: Kent Tamura <tkent@chromium.org>
Date: Tue Aug 08 00:59:19 2017

Update comments on getters of HTMLOptionsCollection and RadioNodeList.

NOTRY=true

Bug:  695902 , 752877 
Change-Id: Idae08fba383baefdf8eb57e673c2f2a71138311d
Reviewed-on: https://chromium-review.googlesource.com/604811
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492480}
[modify] https://crrev.com/d9066877c61a7b81bdebaac0a658d25eedf72b8f/third_party/WebKit/Source/core/html/HTMLOptionsCollection.idl
[modify] https://crrev.com/d9066877c61a7b81bdebaac0a658d25eedf72b8f/third_party/WebKit/Source/core/html/RadioNodeList.idl

Comment 4 by peria@chromium.org, Sep 18 2017

Owner: peria@chromium.org
Status: Assigned (was: Available)

Comment 5 by peria@chromium.org, May 3 2018

Blockedon: 839389

Comment 6 by peria@chromium.org, May 25 2018

Blockedon: -839389
Labels: Hotlist-Bindings-IDLCompiler
Mergedinto: 695972
Status: Duplicate (was: Assigned)

Sign in to add a comment