Issue metadata
Sign in to add a comment
|
1.3%-1.7% regression in media.android.tough_video_cases_tbmv2 at 492050:492205 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Aug 7 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8971935663028397344
,
Aug 7 2017
=== Auto-CCing suspected CL author jkummerow@chromium.org === Hi jkummerow@chromium.org, the bisect results pointed to your CL, please take a look at the results. === BISECT JOB RESULTS === Perf regression found with culprit Suspected Commit Author : Jakob Kummerow Commit : 05e862f78398d8bbeacc7f9e19bbb41c408e709b Date : Fri Aug 04 01:27:42 2017 Subject: Cache StoreIC-Transition handlers Bisect Details Configuration: android_nexus7_perf_bisect Benchmark : media.android.tough_video_cases_tbmv2 Metric : memory:chrome:renderer_processes:reported_by_chrome:v8:heap:effective_size_avg/video.html?src_tulip2.vp9.webm_background Change : 1.26% | 2185964.0 -> 2213420.0 Revision Result N chromium@492049 2185964 +- 0.0 6 good chromium@492127 2185964 +- 0.0 6 good chromium@492147 2185964 +- 0.0 6 good chromium@492157 2185964 +- 0.0 6 good chromium@492160 2185967 +- 14.6059 6 good chromium@492161 2185964 +- 0.0 6 good chromium@492161,v8@5614747680 2185964 +- 0.0 6 good chromium@492161,v8@2fd5e70a03 2186688 +- 0.0 6 good chromium@492161,v8@9735d7f109 2186688 +- 0.0 6 good chromium@492161,v8@0caf1d2029 2184544 +- 0.0 6 good chromium@492161,v8@05e862f783 2212100 +- 0.0 6 bad <-- chromium@492162 2213420 +- 0.0 6 bad chromium@492166 2213420 +- 0.0 6 bad chromium@492205 2213420 +- 0.0 6 bad To Run This Test src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=video.html.src.tulip2.vp9.webm.background media.android.tough_video_cases_tbmv2 More information on addressing performance regressions: http://g.co/ChromePerformanceRegressions Debug information about this bisect: https://chromeperf.appspot.com/buildbucket_job_status/8971935663028397344 For feedback, file a bug with component Speed>Bisection
,
Aug 7 2017
,
Aug 7 2017
,
Aug 8 2017
Issue 753039 has been merged into this issue.
,
Aug 11 2017
Issue 754641 has been merged into this issue.
,
Aug 11 2017
Issue 754630 has been merged into this issue.
,
Aug 14 2017
,
Aug 14 2017
Issue 755084 has been merged into this issue.
,
Aug 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/a3ef2489f299aef5a5393985c9351aace0602390 commit a3ef2489f299aef5a5393985c9351aace0602390 Author: Jakob Kummerow <jkummerow@chromium.org> Date: Fri Aug 18 16:06:44 2017 Cache fewer StoreIC-Transition handlers Many handlers are not used again, so we can improve the cache hit rate by caching fewer handlers. Specifically, in this CL, when a StoreIC miss causes a new map transition to be created, then the handler is not cached right away yet (it will be cached next time, when the transition exists already). Also, fix an embarrassing bug where growing a TransitionArray dropped cached handlers. That further improves the cache hit rate. ;-) Bug: chromium:752867 , chromium:753819 Change-Id: Id8db5ca1e780a5fe8fc61db7f20996e61c65a90e Reviewed-on: https://chromium-review.googlesource.com/619851 Reviewed-by: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#47433} [modify] https://crrev.com/a3ef2489f299aef5a5393985c9351aace0602390/src/ic/ic.cc [modify] https://crrev.com/a3ef2489f299aef5a5393985c9351aace0602390/src/ic/ic.h [modify] https://crrev.com/a3ef2489f299aef5a5393985c9351aace0602390/src/lookup.cc [modify] https://crrev.com/a3ef2489f299aef5a5393985c9351aace0602390/src/lookup.h [modify] https://crrev.com/a3ef2489f299aef5a5393985c9351aace0602390/src/objects.cc [modify] https://crrev.com/a3ef2489f299aef5a5393985c9351aace0602390/src/objects/map.h [modify] https://crrev.com/a3ef2489f299aef5a5393985c9351aace0602390/src/transitions.cc [modify] https://crrev.com/a3ef2489f299aef5a5393985c9351aace0602390/test/cctest/test-field-type-tracking.cc
,
Aug 21 2017
,
Aug 21 2017
Issue 757330 has been merged into this issue.
,
Aug 21 2017
Issue 757304 has been merged into this issue.
,
Aug 21 2017
Issue 757304 has been merged into this issue.
,
Aug 21 2017
Issue 757323 has been merged into this issue.
,
Aug 21 2017
Issue 754638 has been merged into this issue.
,
Aug 22 2017
,
Aug 22 2017
,
Aug 28 2017
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Aug 7 2017