Issue metadata
Sign in to add a comment
|
[OEM Mail] [Swype Keyboard]Cursor moves into next line when we deleting the text |
||||||||||||||||||||||
Issue descriptionThis report will ONLY be viewable by Google. Device name: Samsung Galaxy J7 / MMB29K, LG G5 / MMB29M Android version:6.0.1 Fingerprint: WebView version (from system settings -> Apps -> Android System WebView): 61.0.3163.37 Application Package: com.nuance.swype.dtc Application version: 3.1.2.3010200.49367 URLs (if applicable):N/A Bisect Information (update as information becomes available): Per-Version bisect information: Good build:59.0.3071.55 Bad build:59.0.3071.58 Regression range: https://chromium.googlesource.com/chromium/src/+log/59.0.3071.55..59.0.3071.58?pretty=fuller&n=10000 Pre Condition: 1.Download and install Swype+Dragon keyboard 2.Enable Swype Keyboard Steps to reproduce: (1)Launch OEM Mail->Compose text select text using double tap(Don't give space before double tap) (2)Delete selected word and observe Expected result: Cursor Should not move next line Actual result: Cursor moves into next line Frequency:5/5 Notes: Issue observed on only OEM mails Might be changes of this issue 710621 . It's a paid app
,
Sep 13 2017
Issue able to repro this issue on latest M63: 63.0.3214.0, as M61 gone to stable hence moving to M63 Thanks!
,
Sep 13 2017
Looking at the regression range: is it possible this is related to https://codereview.chromium.org/2874783004 +changwan@
,
Sep 13 2017
A random guess, this issue might be related to issue 762873, deleting could adding a <br> at the end.
,
Sep 22 2017
,
Oct 5 2017
Note: reproduces in Chrome on markup like this: <div contenteditable>hello world<p>hello (where the first line is not wrapped in a <p>, but the second line is)
,
Oct 6 2017
Will be fixed in M63.
,
Oct 6 2017
,
Oct 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/88274b8a49faf895bb7758de53a60dd2561c2a22 commit 88274b8a49faf895bb7758de53a60dd2561c2a22 Author: Ryan Landay <rlanday@chromium.org> Date: Tue Oct 10 15:31:09 2017 Fix incorrect whitespace after calling CommitText() with empty text In https://codereview.chromium.org/2874783004, we changed our implementation of Android's InputConnection#commitText() method so that it doesn't special-case empty strings (previously it wasn't deleting the selection/composition range in this case). This exposed a bug in InsertTextCommand where it's not properly rebalancing whitespace in the case where the inserted text is empty. This CL avoids trying to perform a "trivial replacement" for the case where the inserted text is empty, since the logic is clearly not correct for this case. Bug: 752860 Change-Id: Ia2930ee40a286a59f7c80452cd0a8adf531c7a26 Reviewed-on: https://chromium-review.googlesource.com/704002 Reviewed-by: Changwan Ryu <changwan@chromium.org> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Ryan Landay <rlanday@chromium.org> Cr-Commit-Position: refs/heads/master@{#507674} [modify] https://crrev.com/88274b8a49faf895bb7758de53a60dd2561c2a22/third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp [modify] https://crrev.com/88274b8a49faf895bb7758de53a60dd2561c2a22/third_party/WebKit/Source/core/editing/commands/InsertTextCommandTest.cpp
,
Jan 10 2018
,
Jan 22 2018
This was fixed in M63
,
Jan 23 2018
Fix issue verified on latest M64: 64.0.3282.116 and M65: 65.0.3325.11 Tested device:LG G5 /MMB29M Thanks! |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by battun@chromium.org
, Aug 7 2017