Regression: Nothing happens after clicking on 'Delete' icon of usage in site detail page
Reported by
sans...@etouch.net,
Aug 7 2017
|
||||
Issue descriptionChrome Version:62.0.3178.0 (Official Build)cdd15784955039742fe9a8235581922d41b82d78-refs/heads/master@{#492239}-32/64 bit OS: Windows (7,8,10), Mac (10.11.6, 10.12.3),Linux (14.04 LTS) Pre-condition: Enable Site settings with All sites and Site details from chrome://flags 1. Launch Chrome, open NTP,click on microphone icon of search box and 'Allow' for microphone permission 2. Navigate to chrome://settings/content/microphone and click on added link under 'Allow' 3. Click on 'Delete' icon seen under usage in site detail page and observe Actual: Nothing happens after clicking on 'Delete' icon of usage in site detail page i.e 'Clear and reset site' dialogue is not seen and value does not get reset or deleted Expected: 'Clear and reset site' dialogue should be seen and values should be deleted after clicking on 'Delete' icon of usage in site detail page This is a regression issue broken in M-62, will soon update the bisect info Good build: 62.0.3167.0 Bad build: 62.0.3169.0
,
Aug 9 2017
,
Aug 16 2017
WIP at https://chromium-review.googlesource.com/c/616503
,
Jun 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d4c83652a33127a0d4ec9b723e344b854f8f752a commit d4c83652a33127a0d4ec9b723e344b854f8f752a Author: Patti <patricialor@chromium.org> Date: Thu Jun 07 07:08:32 2018 MD Settings: Fix trashing site usage via Site Details. Site Details was calling a function that didn't exist when the user clicks the trash can button to delete site hard disk usage. Fix. Also add a confirmation dialog, update strings, and move the position of the reset settings button when #enable-site-settings is turned on. Manual test - with #enable-site-settings turned on, navigate to a site using hard disk usage (typically https://www.google.com works). Open the Page Info bubble, click "Site settings". When Site Details opens, it should say 'Usage' in one of the headings. Click the clear data button next to the amount of usage displayed, confirm the dialog, then verify it now shows a string that says 'No usage data'. Bug: 752859 , 835712 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I1f89a60bcc3c63bebee82eae288460f51aabca0a Reviewed-on: https://chromium-review.googlesource.com/616503 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#565205} [modify] https://crrev.com/d4c83652a33127a0d4ec9b723e344b854f8f752a/chrome/app/settings_strings.grdp [modify] https://crrev.com/d4c83652a33127a0d4ec9b723e344b854f8f752a/chrome/browser/resources/settings/site_settings/BUILD.gn [modify] https://crrev.com/d4c83652a33127a0d4ec9b723e344b854f8f752a/chrome/browser/resources/settings/site_settings/site_details.html [modify] https://crrev.com/d4c83652a33127a0d4ec9b723e344b854f8f752a/chrome/browser/resources/settings/site_settings/site_details.js [modify] https://crrev.com/d4c83652a33127a0d4ec9b723e344b854f8f752a/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc [modify] https://crrev.com/d4c83652a33127a0d4ec9b723e344b854f8f752a/chrome/test/data/webui/settings/site_details_tests.js
,
Jun 19 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by jmukthavaram@chromium.org
, Aug 7 2017Labels: hasbisect-per-revision Proj-MaterialDesign-WebUI
Owner: patricia...@chromium.org
Status: Assigned (was: Unconfirmed)