New issue
Advanced search Search tips

Issue 752844 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

chrome://tracing recording mode dropdown is broken

Reported by k...@luminance.org, Aug 7 2017

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:55.0) Gecko/20100101 Firefox/55.0

Steps to reproduce the problem:
1. open chrome://tracing
2. click record
3. try to change the recording mode from 'record until full'

What is the expected behavior?
You should be able to change the mode

What went wrong?
The dropdown closes itself instantly when you click it and you can't focus it to manipulate it with the keyboard.

Did this work before? N/A 

Chrome version: 60.0.3112.90 (Official Build) (64-bit) (cohort: 60_90_win)  Channel: stable
OS Version: 10.0
Flash Version: 

If you use devtools to remove the dropdown's 'focusin' event handler it works.
 
Labels: Needs-Triage-M60
Components: -Platform>DevTools Speed>Tracing
Labels: -Type-Bug -Pri-2 hasbisect-per-revision ReleaseBlock-Stable M-61 OS-Linux OS-Mac Pri-1 Type-Bug-Regression
Owner: benjhayden@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue on Windows 10, Mac 10.12.6 and Ubuntu 14.04 using reported version #60.0.3112.90 but the same is not reproducible in the latest canary #62.0.3179.0.

Reverse Bisect Information:
=====================
Good build: 61.0.3133.0  Revision(480259)
Bad Build : 61.0.3132.0  Revision(479900)

Change Log URL: 
https://chromium.googlesource.com/chromium/src/+log/e3981307d5a02584ece4507dc52ecc64061d118b..588c2a7ea03e082bad299146518d35f2aca951e8

Blink Change Log:
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/e9dc4c57fb00..57e600c76c9f

From the above blink change log possible CL that fixed this issue:
Review-Url: https://codereview.chromium.org/2946513002

benjhayden@ - Could you please check and merge the fix to M61 if it is a valid canadidate.

Note: Adding label ReleaseBlock-Stable, as it seems to be a recent regression.

Thanks...!!
Requested merge in https://bugs.chromium.org/p/chromium/issues/detail?id=733991
Should I mark this bug as a duplicate of that and add ReleaseBlock-Stable to that bug?
[Bulk Edit]
URGENT - PTAL.
Your bug is labelled as M61 Stable ReleaseBlock, pls make sure to land the fix and get it merged into the release branch ASAP.

Know that this issue shouldn't block the release?  Remove the ReleaseBlock-Stable label.

Thank you.

@krajshree: The fix in 733991 landed on Jun 17th and we branched M61 on July 20th, so no M61 merge is needed here. Could you please double check?

Comment 6 by gov...@chromium.org, Aug 10 2017

Status: Fixed (was: Assigned)
The fix is already in M61 branch.
Per comment #2, reverse bisect, Good build: 61.0.3133.0. And M61 branch #3163.
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-61; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-61 label, otherwise remove Merge-TBD label. Thanks.

Comment 8 by gov...@chromium.org, Aug 11 2017

Labels: -Merge-TBD

Sign in to add a comment