Issue metadata
Sign in to add a comment
|
Regression: Profile picture is seen missing in chrome://settings page |
||||||||||||||||||||||
Issue descriptionChrome Version:62.0.3176.0/9816.0.0 dev-channel Falco,Reks OS:Chrome What steps will reproduce the problem? (1)Sign into user -> Launch chrome,Open chrome://settings/changePicture page and take a sample photo. (2)Select any other picture to display for your account.Now delete the existing photo taken from camera. (3)After deleting,as usual the selected picture will display for your account. (4)Now click on (<-) back arrow to goto chrome://settings page and Observe the picture.(kindly refer video) Actual:Selected Profile pic is seen missing Expected:Selected Profile pic should be seen. This is a Regression issue as same is working fine in M-61 Note:Issue is not seen in Linux,Windows OS @Stevenjb: Please confirm the issue
,
Aug 16 2017
,
Aug 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/125b9ba3b1c6e971593491fb37cdf097e26ac551 commit 125b9ba3b1c6e971593491fb37cdf097e26ac551 Author: Steven Bennetts <stevenjb@chromium.org> Date: Wed Aug 16 18:35:42 2017 Settings: Picture: Remove stale discard code We were always selecting the default picture when the 'old' image was discarded. This is incorrect; instead have CrPictureList.setOldImageUrl('') set the default image when appropriate. Bug: 752842 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I9c4ad88b4bfed90a634a72b53c3251fffce570f9 Reviewed-on: https://chromium-review.googlesource.com/616344 Reviewed-by: David Reveman <reveman@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#494875} [modify] https://crrev.com/125b9ba3b1c6e971593491fb37cdf097e26ac551/chrome/browser/resources/chromeos/login/oobe_change_picture.js [modify] https://crrev.com/125b9ba3b1c6e971593491fb37cdf097e26ac551/chrome/browser/resources/settings/people_page/change_picture.js [modify] https://crrev.com/125b9ba3b1c6e971593491fb37cdf097e26ac551/ui/webui/resources/cr_elements/chromeos/cr_picture/cr_picture_list.js
,
Aug 16 2017
,
Aug 16 2017
[Auto-generated comment by a script] We noticed that this issue is targeted for M-61; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-61 label, otherwise remove Merge-TBD label. Thanks.
,
Aug 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d9d7434384ce0798e31100a756887b3b222ed230 commit d9d7434384ce0798e31100a756887b3b222ed230 Author: David Reveman <reveman@chromium.org> Date: Fri Aug 25 07:55:24 2017 Settings: Picture: Remove stale discard code We were always selecting the default picture when the 'old' image was discarded. This is incorrect; instead have CrPictureList.setOldImageUrl('') set the default image when appropriate. TBR=stevenjb@chromium.org (cherry picked from commit 125b9ba3b1c6e971593491fb37cdf097e26ac551) Bug: 752842 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I9c4ad88b4bfed90a634a72b53c3251fffce570f9 Reviewed-on: https://chromium-review.googlesource.com/616344 Reviewed-by: David Reveman <reveman@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#494875} Reviewed-on: https://chromium-review.googlesource.com/635006 Cr-Commit-Position: refs/branch-heads/3163@{#876} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/d9d7434384ce0798e31100a756887b3b222ed230/chrome/browser/resources/chromeos/login/oobe_change_picture.js [modify] https://crrev.com/d9d7434384ce0798e31100a756887b3b222ed230/chrome/browser/resources/settings/people_page/change_picture.js [modify] https://crrev.com/d9d7434384ce0798e31100a756887b3b222ed230/ui/webui/resources/cr_elements/chromeos/cr_picture/cr_picture_list.js
,
Oct 6 2017
,
Jan 22 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by steve...@chromium.org
, Aug 16 2017Status: Started (was: Assigned)