New issue
Advanced search Search tips

Issue 752837 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Aug 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

Can't build w/o clang on windows

Project Member Reported by yoichio@chromium.org, Aug 7 2017

Issue description

Since https://chromium-review.googlesource.com/c/596503, I can't build chrome w/o clang.
$ gn args ./
is_component_build = true
enable_nacl = false
is_clang = false
is_win_fastlink = true
target_cpu = "x86"
is_debug = true

$ ninja -j30 blink_tests
[1/668] CXX obj/cc/blink/blink/web_display_item_list_impl.obj
FAILED: obj/cc/blink/blink/web_display_item_list_impl.obj
ninja -t msvc -e environment.x86 -- "c:\src\build\src\chrome1\src\third_party\depot_tools\win_toolchain\vs_files\f53e4598951162bad6330f7a167486c7ae5db1e5\vc\bin\amd64_x86/cl.exe" /nologo /showIncludes  @obj/cc/blink/blink/web_display_item_list_impl.obj.rsp /c ../../cc/blink/web_display_item_list_impl.cc /Foobj/cc/blink/blink/web_display_item_list_impl.obj /Fd"obj/cc/blink/blink_cc.pdb"
C:\src\build\src\chrome1\src\cc/blink/web_display_item_list_impl.h(36): error C2220: warning treated as error - no 'object' file generated
C:\src\build\src\chrome1\src\cc/blink/web_display_item_list_impl.h(36): warning C4275: non dll-interface class 'blink::WebDisplayItemList' used as base for dll-interface class 'cc_blink::WebDisplayItemListImpl'
C:\src\build\src\chrome1\src\third_party/WebKit/public/platform/WebDisplayItemList.h(35): note: see declaration of 'blink::WebDisplayItemList'
C:\src\build\src\chrome1\src\cc/blink/web_display_item_list_impl.h(36): note: see declaration of 'cc_blink::WebDisplayItemListImpl'
[2/668] CXX obj/cc/blink/blink/web_content_layer_impl.obj
FAILED: obj/cc/blink/blink/web_content_layer_impl.obj
ninja -t msvc -e environment.x86 -- "c:\src\build\src\chrome1\src\third_party\depot_tools\win_toolchain\vs_files\f53e4598951162bad6330f7a167486c7ae5db1e5\vc\bin\amd64_x86/cl.exe" /nologo /showIncludes  @obj/cc/blink/blink/web_content_layer_impl.obj.rsp /c ../../cc/blink/web_content_layer_impl.cc
/Foobj/cc/blink/blink/web_content_layer_impl.obj /Fd"obj/cc/blink/blink_cc.pdb"
C:\src\build\src\chrome1\src\cc/blink/web_display_item_list_impl.h(36): error C2220: warning treated as error - no 'object' file generated
C:\src\build\src\chrome1\src\cc/blink/web_display_item_list_impl.h(36): warning C4275: non dll-interface class 'blink::WebDisplayItemList' used as base for dll-interface class 'cc_blink::WebDisplayItemListImpl'
C:\src\build\src\chrome1\src\third_party/WebKit/public/platform/WebDisplayItemList.h(35): note: see declaration of 'blink::WebDisplayItemList'
C:\src\build\src\chrome1\src\cc/blink/web_display_item_list_impl.h(36): note: see declaration of 'cc_blink::WebDisplayItemListImpl'
[3/668] CXX obj/cc/blink/blink/web_compositor_support_impl.obj
FAILED: obj/cc/blink/blink/web_compositor_support_impl.obj
ninja -t msvc -e environment.x86 -- "c:\src\build\src\chrome1\src\third_party\depot_tools\win_toolchain\vs_files\f53e4598951162bad6330f7a167486c7ae5db1e5\vc\bin\amd64_x86/cl.exe" /nologo /showIncludes  @obj/cc/blink/blink/web_compositor_support_impl.obj.rsp /c ../../cc/blink/web_compositor_support_impl.cc /Foobj/cc/blink/blink/web_compositor_support_impl.obj /Fd"obj/cc/blink/blink_cc.pdb"
C:\src\build\src\chrome1\src\cc/blink/web_display_item_list_impl.h(36): error C2220: warning treated as error - no 'object' file generated
C:\src\build\src\chrome1\src\cc/blink/web_display_item_list_impl.h(36): warning C4275: non dll-interface class 'blink::WebDisplayItemList' used as base for dll-interface class 'cc_blink::WebDisplayItemListImpl'

Maybe we miss some DLL_EXPORTs but
diff --git a/third_party/WebKit/Source/platform/fonts/FontSelectorClient.h
class PLATFORM_EXPORT FontSelectorClient : public GarbageCollectedMixin {
diff --git a/third_party/WebKit/public/platform/WebDisplayItemList.h 
class BLINK_PLATFORM_EXPORT WebDisplayItemList {

causes link error.
Please fix it.

 
Cc: h...@chromium.org thakis@chromium.org
Cc: dpranke@chromium.org jam@chromium.org r...@chromium.org piman@chromium.org
Taking a step back, if this warning is useful, we should add it to clang. If it isn't, we should disable it.

We've had "why do we enable this warning?" threads here:
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/3_GPGgQpxvc
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/IW4zfkoadKE

Both link to https://msdn.microsoft.com/en-us/library/3tdb471s(VS.80).aspx (the doc for the warning) as justification, but neither thread is very enthusiastic about the benefits of the warning. I'm not aware of any actual bugs caught by the warning, and I'm not sure I believe that the over 1000 instances of NON_EXPORTED_BASE in the codebase got the careful review of NON_EXPORTED_BASE that we said should happen :-)

From what I understand, the issue is that static data gets emitted into each component a class is used in (instead of just once), and inline functions refer to the version in the current component unless you jump to an exported function.

I think by now we should just disable the warning and make NON_EXPORTED_BASE do nothing and eventually remove it. I don't think the warning carries its weight.

cc'ing a few folks from the prior threads, in case anyone disagrees, but I think we should disable C4275.
Warning disablement CL: https://chromium-review.googlesource.com/c/603773
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4b77236a76acca2eb885b5021a0ede75efe29962

commit 4b77236a76acca2eb885b5021a0ede75efe29962
Author: Nico Weber <thakis@chromium.org>
Date: Mon Aug 07 21:13:06 2017

win: Disable warning 4275, make NON_EXPORTED_BASE a no-op.

This points out a potential (but rare) problem with referencing static
fields of a non-exported base, through the base's non-exported inline
functions, or directly. The warning is subtle enough that people just
suppressed it when they saw it, so it's not worth it.

Bug:  752837 
Change-Id: Ia9b8307f77e155416bdfdad28ff33df3081a434b
Reviewed-on: https://chromium-review.googlesource.com/603773
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492411}
[modify] https://crrev.com/4b77236a76acca2eb885b5021a0ede75efe29962/base/compiler_specific.h
[modify] https://crrev.com/4b77236a76acca2eb885b5021a0ede75efe29962/build/config/compiler/BUILD.gn

I managed to build it. Thanks.
Status: Fixed (was: Untriaged)
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/43ddd7a3af5d91573e0a03c022786d3ac6d0073f

commit 43ddd7a3af5d91573e0a03c022786d3ac6d0073f
Author: Nico Weber <thakis@chromium.org>
Date: Tue Aug 15 19:19:27 2017

Remove uses NON_EXPORTED_BASE now that it's a no-op.

CL generated by

   git grep -l NON_EXPORTED_BASE | xargs sed -i 's/NON_EXPORTED_BASE(\([^)]*\))/\1/g'
   git cl format

I'm not changing compiler_specific.h itself in this cl, to keep the revert
small if the subsequent removal of the actual macro should break something.

Bug:  752837 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_site_isolation;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I53d6460e592b91a173f7aa55dfdb05631e51e5f7
Reviewed-on: https://chromium-review.googlesource.com/614703
Reviewed-by: Brett Wilson <brettw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494486}
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/android_webview/browser/parent_output_surface.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/ash/accelerators/accelerator_controller.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/ash/accelerators/accelerator_delegate.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/ash/ime/ime_controller.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/ash/login/lock_screen_controller.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/ash/session/session_controller.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/ash/shutdown_controller.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/ash/system/night_light/night_light_controller.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/ash/system/tray/system_tray_controller.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/ash/tray_action/tray_action.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/ash/wallpaper/wallpaper_controller.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/ash/wm/tablet_mode/tablet_mode_controller.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/cc/animation/animation_events.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/cc/animation/animation_host.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/cc/blink/web_compositor_support_impl.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/cc/blink/web_layer_impl.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/cc/layers/picture_layer_impl.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/cc/trees/layer_tree_host.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/cc/trees/proxy_impl.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/cc/trees/single_thread_proxy.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/chrome/browser/chromeos/night_light/night_light_client.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/chrome/browser/media/router/browser_presentation_connection_proxy.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/chrome/browser/media/router/test_helper.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/chrome/browser/media_galleries/fileapi/mtp_file_stream_reader.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/chrome/browser/media_galleries/fileapi/readahead_file_stream_reader.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/chrome/browser/sync_file_system/local/syncable_file_system_operation.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/components/exo/shell_surface.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/components/invalidation/impl/p2p_invalidator.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/components/invalidation/impl/push_client_channel.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/components/invalidation/impl/sync_invalidation_listener.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/components/invalidation/impl/sync_system_resources.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/components/keyed_service/core/keyed_service_base_factory.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/components/prefs/pref_notifier_impl.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/components/ui_devtools/devtools_server.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/components/viz/common/gpu/in_process_context_provider.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/components/viz/common/surfaces/sequence_surface_reference_factory.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/components/viz/common/surfaces/stub_surface_reference_factory.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/components/viz/host/host_frame_sink_manager.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/components/viz/service/display_embedder/gpu_display_provider.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/components/viz/service/display_embedder/server_shared_bitmap_manager.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/components/viz/service/display_embedder/shared_bitmap_allocation_notifier_impl.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/components/viz/service/frame_sinks/compositor_frame_sink_impl.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/components/viz/service/frame_sinks/direct_layer_tree_frame_sink.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/components/viz/service/frame_sinks/frame_sink_manager_impl.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/components/viz/service/frame_sinks/root_compositor_frame_sink_impl.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/components/viz/service/gl/gpu_service_impl.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/components/viz/service/surfaces/direct_surface_reference_factory.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/components/webcrypto/fuzzer_support.cc
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/browser/appcache/chrome_appcache_service.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/browser/background_sync/background_sync_manager.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/browser/background_sync/background_sync_service_impl.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/browser/bluetooth/web_bluetooth_service_impl.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/browser/browser_child_process_host_impl.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/browser/cache_storage/cache_storage_context_impl.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/browser/child_process_security_policy_impl.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/browser/dom_storage/dom_storage_context_wrapper.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/browser/dom_storage/session_storage_namespace_impl.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/browser/fileapi/upload_file_system_file_element_reader.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/browser/frame_host/interstitial_page_impl.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/browser/frame_host/navigation_controller_impl.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/browser/frame_host/navigation_entry_impl.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/browser/frame_host/render_frame_host_impl.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/browser/frame_host/render_frame_message_filter.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/browser/frame_host/render_widget_host_view_child_frame.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/browser/geolocation/geolocation_service_impl.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/browser/gpu/gpu_data_manager_impl.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/browser/gpu/gpu_feature_checker_impl.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/browser/host_zoom_map_impl.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/browser/indexed_db/indexed_db_context_impl.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/browser/indexed_db/indexed_db_database.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/browser/indexed_db/indexed_db_factory.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/browser/keyboard_lock/keyboard_lock_service_impl.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/browser/loader/mojo_async_resource_handler.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/browser/media/capture/web_contents_audio_input_stream.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/browser/media/cdm_registry_impl.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/browser/media/media_internals.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/browser/media/session/media_session_controller.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/browser/notifications/platform_notification_context_impl.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/browser/payments/payment_manager.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/browser/pepper_flash_settings_helper_impl.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/browser/plugin_service_impl.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/browser/presentation/presentation_service_impl.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/browser/renderer_host/compositor_resize_lock.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/browser/renderer_host/compositor_resize_lock_unittest.cc
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/browser/renderer_host/delegated_frame_host.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/browser/renderer_host/delegated_frame_host_client_aura.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/browser/renderer_host/input/input_router_impl.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/browser/renderer_host/input/legacy_input_router_impl.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/browser/renderer_host/input/render_widget_host_latency_tracker.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/browser/renderer_host/legacy_render_widget_host_win.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/browser/renderer_host/media/audio_sync_reader.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/browser/renderer_host/offscreen_canvas_surface_impl.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/browser/renderer_host/render_process_host_impl.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/browser/renderer_host/render_widget_host_impl.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/browser/renderer_host/render_widget_host_view_aura.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/browser/screen_orientation/screen_orientation_provider.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/browser/service_worker/embedded_worker_instance.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/browser/service_worker/embedded_worker_registry.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/browser/service_worker/embedded_worker_test_helper.cc
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/browser/service_worker/service_worker_context_core.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/browser/service_worker/service_worker_context_wrapper.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/browser/service_worker/service_worker_handle.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/browser/service_worker/service_worker_provider_host.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/browser/service_worker/service_worker_registration.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/browser/service_worker/service_worker_storage.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/browser/service_worker/service_worker_version.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/browser/shared_worker/shared_worker_content_settings_proxy_impl.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/browser/shared_worker/shared_worker_service_impl.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/browser/speech/speech_recognition_manager_impl.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/browser/speech/speech_recognizer_impl.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/browser/storage_partition_impl.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/browser/utility_process_host_impl.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/browser/web_contents/web_contents_impl.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/browser/web_contents/web_contents_view_aura.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/browser/webauth/authenticator_impl.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/browser/webrtc/webrtc_internals_message_handler.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/browser/webrtc/webrtc_internals_message_handler_unittest.cc
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/browser/webrtc/webrtc_internals_unittest.cc
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/browser/websockets/websocket_impl.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/browser/websockets/websocket_manager.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/browser/webui/web_ui_data_source_impl.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/child/appcache/web_application_cache_host_impl.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/child/blink_platform_impl.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/child/child_thread_impl.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/child/fileapi/webfilewriter_base.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/child/indexed_db/webidbcursor_impl.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/child/indexed_db/webidbdatabase_impl.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/child/memory/child_memory_coordinator_impl.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/child/request_extra_data.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/child/service_worker/service_worker_message_filter.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/child/service_worker/service_worker_provider_context.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/child/service_worker/web_service_worker_impl.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/child/service_worker/web_service_worker_provider_impl.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/child/service_worker/web_service_worker_registration_impl.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/child/shared_memory_data_consumer_handle.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/child/web_data_consumer_handle_impl.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/child/web_url_loader_impl.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/child/webfileutilities_impl.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/child/weburlresponse_extradata_impl.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/common/input/synthetic_web_input_event_builders.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/public/browser/native_web_keyboard_event.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/public/browser/provision_fetcher_impl.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/public/renderer/document_state.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/renderer/android/synchronous_layer_tree_frame_sink.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/renderer/browser_plugin/browser_plugin.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/renderer/device_sensors/device_sensor_event_pump.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/renderer/devtools/devtools_agent.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/renderer/devtools/devtools_client.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/renderer/gpu/render_widget_compositor.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/renderer/image_capture/image_capture_frame_grabber.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/renderer/installedapp/related_apps_fetcher.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/renderer/media/audio_input_message_filter.cc
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/renderer/media/audio_message_filter.cc
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/renderer/media/external_media_stream_audio_source.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/renderer/media/gpu/rtc_video_decoder.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/renderer/media/gpu/rtc_video_decoder_factory.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/renderer/media/gpu/rtc_video_encoder.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/renderer/media/gpu/rtc_video_encoder_factory.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/renderer/media/local_media_stream_audio_source.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/renderer/media/media_stream.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/renderer/media/media_stream_audio_processor.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/renderer/media/media_stream_audio_source.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/renderer/media/media_stream_center.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/renderer/media/media_stream_source.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/renderer/media/media_stream_track.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/renderer/media/media_stream_video_renderer_sink.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/renderer/media/remote_media_stream_impl.cc
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/renderer/media/renderer_webaudiodevice_impl.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/renderer/media/renderer_webmediaplayer_delegate.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/renderer/media/rtc_certificate.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/renderer/media/rtc_data_channel_handler.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/renderer/media/rtc_dtmf_sender_handler.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/renderer/media/rtc_peer_connection_handler.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/renderer/media/speech_recognition_audio_sink.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/renderer/media/track_audio_renderer.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/renderer/media/user_media_client_impl.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/renderer/media/webaudio_media_stream_source.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/renderer/media/webmediaplayer_ms.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/renderer/media/webmediaplayer_ms_compositor.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/renderer/media/webrtc/peer_connection_dependency_factory.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/renderer/media/webrtc/peer_connection_remote_audio_source.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/renderer/media/webrtc/processed_local_audio_source.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/renderer/media/webrtc/track_observer.cc
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/renderer/media/webrtc/webrtc_media_stream_adapter.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/renderer/media/webrtc/webrtc_video_capturer_adapter.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/renderer/media/webrtc_audio_device_impl.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/renderer/media/webrtc_audio_device_not_impl.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/renderer/media/webrtc_audio_renderer.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/renderer/media/webrtc_local_audio_source_provider.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/renderer/media_capture_from_element/canvas_capture_handler.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/renderer/media_capture_from_element/html_audio_element_capturer_source.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/renderer/media_recorder/audio_track_recorder.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/renderer/media_recorder/media_recorder_handler.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/renderer/media_recorder/video_track_recorder.h
[modify] https://crrev.com/43ddd7a3af5d91573e0a03c022786d3ac6d0073f/content/r
Labels: -Pri-1 Pri-0
Status: Available (was: Fixed)
It fails again on ToT:
https://chromium.googlesource.com/chromium/src/+/56f8b13c543feea07d4ed99ce58ddec46bbd0ae2

Since we don't have any bots with clang=false,
 this situation can happen again and again and we only can find it by hand.
This is really frustrating and so far we developers still need clang=false option
 because clang on win is still much slow in link.

Build error message:
C:\src\build\src\chrome2\src\out_gn\Debug\gen\blink\core/css/properties/CSSPropertyAPIMaxWidthOrHeight.h(28): error C3668: 'blink::CSSPropertyAPIMaxWidthOrHeight::ParseSingleValue': method with override specifier 'override' did not override any base class methods
C:\src\build\src\chrome2\src\out_gn\Debug\gen\blink\core/css/properties/CSSPropertyAPIWebkitTextDecorationsInEffect.h(28): error C3668: 'blink::CSSPropertyAPIWebkitTextDecorationsInEffect::ParseSingleValue': method with override specifier 'override' did not override any base class methods
C:\src\build\src\chrome2\src\out_gn\Debug\gen\blink\core/css/properties/CSSShorthandPropertyAPIScrollPaddingInline.h(28): error C3668: 'blink::CSSShorthandPropertyAPIScrollPaddingInline::ParseShorthand': method with override specifier 'override' did not override any base class methods
C:\src\build\src\chrome2\src\out_gn\Debug\gen\blink\core/css/properties/CSSPropertyAPIColumnWidth.h(28): error C3668: 'blink::CSSPropertyAPIColumnWidth::ParseSingleValue': method with override specifier 'override' did not override any base
class methods
C:\src\build\src\chrome2\src\out_gn\Debug\gen\blink\core/css/properties/CSSPropertyAPIContent.h(28): error C3668: 'blink::CSSPropertyAPIContent::ParseSingleValue': method with override specifier 'override' did not override any base class methods
...
1) we reverted clang-by-default, almost all win bots build with msvc at the moment, see chromium-review thread. So not sure why you're seeing this but none of the bots are
2) I don't think reopening this bug each time this happens is very useful ("no zombie bugs")
3) consider helping fix these issues, you're part of the dev team too

Comment 13 by h...@chromium.org, Aug 23 2017

Labels: -Pri-0 Pri-2
Status: Fixed (was: Available)
The original issue was fixed and as Nico pointed out, virtually all Win bots now use MSVC and are green.


yoichio: Maybe something changed with https://chromium.googlesource.com/chromium/src/+/b3410f557205acd68eb5fd69b4bac43fd61fc70d and you need to rebase?

Sign in to add a comment