New issue
Advanced search Search tips

Issue 752827 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

webkit_unit_tests failing on chromium.webkit/WebKit Android (Nexus4)

Project Member Reported by tasak@google.com, Aug 7 2017

Issue description

webkit_unit_tests failing on chromium.webkit/WebKit Android (Nexus4)

Builders failed on: 
- WebKit Android (Nexus4): 
  https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29

FYI:
I  217.796s run_tests_on_device(01cb7ce0cfe305ae)  [ RUN      ] RenderedPositionTest.IsVisible
I  217.796s run_tests_on_device(01cb7ce0cfe305ae)  [INFO:SkFontMgr_android_parser.cpp(609)] [SkFontMgr Android Parser] '/system/etc/fonts.xml' could not be opened
I  217.796s run_tests_on_device(01cb7ce0cfe305ae)  
I  217.796s run_tests_on_device(01cb7ce0cfe305ae)  [INFO:SkFontMgr_android_parser.cpp(609)] [SkFontMgr Android Parser] '/vendor/etc/fallback_fonts.xml' could not be opened
I  217.796s run_tests_on_device(01cb7ce0cfe305ae)  
I  217.796s run_tests_on_device(01cb7ce0cfe305ae)  ../../third_party/WebKit/Source/core/editing/RenderedPositionTest.cpp:33: Failure
I  217.796s run_tests_on_device(01cb7ce0cfe305ae)  Value of: rendered_hidden_position.IsVisible(true)
I  217.796s run_tests_on_device(01cb7ce0cfe305ae)    Actual: true
I  217.796s run_tests_on_device(01cb7ce0cfe305ae)  Expected: false
I  217.796s run_tests_on_device(01cb7ce0cfe305ae)  [  FAILED  ] RenderedPositionTest.IsVisible (62 ms)
I  217.796s run_tests_on_device(01cb7ce0cfe305ae)  [----------] 1 test from RenderedPositionTest (63 ms total)

 
Status: Fixed (was: Available)
The patch was reverted.
Labels: Pri-1
Status: Assigned (was: Fixed)
This is still failing now that the patch has relanded in commit 18235e2e87fdbddd735342cdfbcba7df1940b144 from https://chromium-review.googlesource.com/c/603880.

Since the failing test is a new one added by the patch, there's no urgent need to revert, so I'll disable the test for now in https://chromium-review.googlesource.com/c/608188, and let you decide how to prioritise fixing this.
Labels: -Sheriff-Chromium Type-Bug
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f5bd0c1249f73ebbc5270c3ead2057558b19f6c

commit 7f5bd0c1249f73ebbc5270c3ead2057558b19f6c
Author: John Mellor <johnme@chromium.org>
Date: Wed Aug 09 12:28:35 2017

Mark RenderedPositionTest.IsVisible as failing on android

It was recently added in commit 18235e2e87fdbddd735342cdfbcba7df1940b144
from https://chromium-review.googlesource.com/c/603880

But has failed every build since landing on
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29/builds/68199

NOTREECHECKS=true
NOTRY=true
BUG= 752827 ,751068
TBR=chrishtr@chromium.org

Change-Id: I50d550b50d358ba6a8ca1a154427079e0969fff6
Reviewed-on: https://chromium-review.googlesource.com/608188
Reviewed-by: John Mellor <johnme@chromium.org>
Commit-Queue: John Mellor <johnme@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492950}
[modify] https://crrev.com/7f5bd0c1249f73ebbc5270c3ead2057558b19f6c/third_party/WebKit/Source/core/editing/RenderedPositionTest.cpp

Labels: -Pri-1 Pri-2
Status: WontFix (was: Assigned)

Sign in to add a comment