Single click on a cookie name no longer expands its contents in Material Settings
Reported by
woxxom@gmail.com,
Aug 6 2017
|
|||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/62.0.3178.0 Safari/537.36 Steps to reproduce the problem: 1. open chrome://settings/content 2. open Cookies (in pre-MD versions it's "All cookies and site data") 3. open any domain in the list 4. click any cookie name What is the expected behavior? * The mouse cursor remains an arrow * The contents of the cookie is shown/hidden What went wrong? * Nothing useful happens. * The mouse cursor changes to I-beam. * I have to click on the expander button at the end of each row, which is too close to the "delete" action icon. Did this work before? Yes 58 and all earlier versions before Material Design Chrome version: 60.0.3112.90 Channel: n/a OS Version: 6.1 (Windows 7, Windows Server 2008 R2) Flash Version: UX-wise this is a regression, but implementation-wise the Material Design settings never handled this correctly as far as I know.
,
Aug 9 2017
woxxom@ - Thanks for your feedback...!! Able to reproduce the issue on Windows 7, Ubuntu 14.04 and Mac 10.12.6 using chrome stable version #60.0.3112.90 and latest canary #62.0.3180.0. Bisect Information: ===================== Good build: 58.0.3020.0 Revision(451874) Bad Build : 58.0.3021.0 Revision(452347) Change Log URL: https://chromium.googlesource.com/chromium/src/+log/2a8688557c5a91fd3984454215523f2eea58bcd1..b9135d31f35a07fb2677c8c7266ddf9ed27f784e From the above change log suspecting below change Review URL: https://codereview.chromium.org/2699973002 As dbeam@ is no longer on Chrome, assigning to dpapad@ for further investigation. Thanks...!!
,
Aug 9 2017
@dschuyler: Assigning to you since this seems similar to issue 734275 .
,
Dec 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/86601ec64479f00e497a85a6aa0b28030b6cc311 commit 86601ec64479f00e497a85a6aa0b28030b6cc311 Author: Dave Schuyler <dschuyler@chromium.org> Date: Fri Dec 15 00:18:03 2017 [MD settings] Make expand row clickable This CL makes the cookie name part of the expand button so that clicking on it will expand/collapse the local data. Bug: 752821 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Id81f16c3ecd435c4e99e4ccd9a6cfacf0cf81ef8 Reviewed-on: https://chromium-review.googlesource.com/820651 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#524252} [modify] https://crrev.com/86601ec64479f00e497a85a6aa0b28030b6cc311/chrome/browser/resources/settings/site_settings/site_data_details_subpage.html [modify] https://crrev.com/86601ec64479f00e497a85a6aa0b28030b6cc311/ui/webui/resources/cr_elements/cr_expand_button/cr_expand_button.html
,
Dec 15 2017
Verified this issue on Windows 7, Ubuntu 14.04 and Mac OS 10.12.6 using chrome latest dev #65.0.3295.0 by following steps mentioned in the original comment. Could observe that on single-clicking on any domain under Cookies in chrome://settings/content, the contents are shown. Hence adding TE-Verified label for M65. Thanks!
,
Dec 18 2017
,
Dec 18 2017
The mouse cursor isn't changed when hovering the cookie name. Is it okay? AFAIK clickability should always be indicated.
,
Dec 19 2017
#8 Yeah, clickable things should have the 'hand' when hovering. If this doesn't that would be a bug. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by krajshree@chromium.org
, Aug 7 2017