+treib

Any idea what's going on here?

Can you check today's build? (3175?) This might have fixed it:

https://chromium-review.googlesource.com/c/572206

Back to reporter to verify.

Friendly ping for feedback :)

Was on vacation. Looks good to me!

Just a note: This is still broken in Chrome 61 Beta. Not sure, if this should be fixed in M61, too?! This probably depends on how many people are using a NewTab-Override Extension on Mac. This is currently only fixed in M62, since https://chromium-review.googlesource.com/c/572206 wasn't merged to M61.

Reopening this issue, so that macOS Team can decide.

Thanks.

+krb@

[mac triage] -> Jayson: do you have an opinion on this?

I couldn't find any UMA - there's only https://cs.chromium.org/non_webstore_ntp_override_count

There was an earlier manual review where it was discussed whether to merge to m60 at https://bugs.chromium.org/p/chromium/issues/detail?id=750716#c7 (decision was not to, and it's now 3 weeks later).

I think it's very late in the game to try to merge it back to M61. Re: the problem description, the subject says the URL is not fully selected while the problem description isn't that specific. I'm wondering if a workaround is adding a Cmd-A (select all) step before typing the new URL.

#11: I think you'd have to wait until the NTP loads for that to work, not entirely sure.

Either way, having an extra keycombo as a workaround isn't going to fix the vast majority of the potential millions of queries that are going to be affected by this. 'Ctrl + T => type query' is a core user flow. Having it break for all users with a custom NTP isn't great.

But (I think you mean Cmd T) plus Cmd A plus type query, though inconvenient, is still a viable workaround?

As much as Cmd T + Select text with mouse/touchpad + type query is a viable workaround, yes.

We don't strictly lose any functionality here, it's just horribly inconvenient and confusing.

Retargeting to M63. Should this really be P1? If it requires installing a specific type of extension, it seems like a somewhat rare problem.

Reporter states in c#6 that this bug is fixed. The fix (mentioned in c#2) landed in M62. We opted not to try to cherry pick back to M61.

 Issue 766012  has been merged into this issue.

 Issue 767319  has been merged into this issue.