clang-format failing on IPC_BEGIN_MESSAGE_MAP |
||||
Issue descriptionSee: https://chromium-review.googlesource.com/c/592848/8/chrome/renderer/extensions/automation_internal_custom_bindings.cc This is was it produced: void AutomationInternalCustomBindings::OnMessageReceived( const IPC::Message& message){ IPC_BEGIN_MESSAGE_MAP(AutomationInternalCustomBindings, message) IPC_MESSAGE_HANDLER(ExtensionMsg_AccessibilityEvents, OnAccessibilityEvents) IPC_MESSAGE_HANDLER(ExtensionMsg_AccessibilityLocationChanges, OnAccessibilityLocationChanges) IPC_END_MESSAGE_MAP()} This was while running clang-format on Windows. It was reproducible.
,
Aug 6 2017
One particularly strange bit is that clang-format ate the space between the ) and {... So maybe it thinks this is a list initialization expression somehow?
,
Oct 26 2017
,
Nov 27
void AutomationInternalCustomBindings::OnMessageReceived(
const IPC::Message& message) {
IPC_BEGIN_MESSAGE_MAP(AutomationInternalCustomBindings, message)
IPC_MESSAGE_HANDLER(ExtensionMsg_AccessibilityEvents, OnAccessibilityEvents)
IPC_MESSAGE_HANDLER(ExtensionMsg_AccessibilityLocationChanges,
OnAccessibilityLocationChanges)
IPC_END_MESSAGE_MAP()
}
,
Nov 27
Actually fixed by https://chromium.googlesource.com/chromium/src/+/9ce8be44d36f1d8e52a571a18def3b5295cf0763 long ago, not by that roll.
,
Nov 27
|
||||
►
Sign in to add a comment |
||||
Comment 1 by thakis@chromium.org
, Aug 6 2017Labels: clang-format