New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 752770 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Null-dereference READ in blink::OffscreenCanvas::GetOrCreateImageBuffer

Project Member Reported by ClusterFuzz, Aug 5 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5204731390853120

Fuzzer: inferno_twister
Job Type: linux_asan_content_shell_drt
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000020
Crash State:
  blink::OffscreenCanvas::GetOrCreateImageBuffer
  blink::OffscreenCanvasRenderingContext2D::commit
  blink::V8OffscreenCanvasRenderingContext2D::commitMethodCallback
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_content_shell_drt&range=473072:473106

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5204731390853120


Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Cc: msrchandra@chromium.org
Labels: M-61 Test-Predator-Wrong
Owner: fs...@chromium.org
Status: Assigned (was: Untriaged)
Predator and CL did not provide any possible suspects.
Using Code Search for the file, "OffscreenCanvas.cpp" assigning to concern owner from GIT Blame.

Suspecting Commit#
https://chromium.googlesource.com/chromium/src/+/5db093f59a68e29ed89a115da7e0c86b897a67b1

@fserb -- Could you please look into the issue, kindly re-assign if this is not related to your changes.
Thank You.

Comment 2 by fs...@chromium.org, Aug 7 2017

Owner: junov@chromium.org
@junov is the right one. :)
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/36c0abdab86cc8d2717b75c46587f1c23c9ad032

commit 36c0abdab86cc8d2717b75c46587f1c23c9ad032
Author: Justin Novosad <junov@chromium.org>
Date: Wed Aug 09 14:39:06 2017

Add null pointer check in OffscreenCanvas::GetOrCreateImageBuffer

BUG= 752770 

Change-Id: Id046e6a772bd456652862ca6c14b74469d613ed9
Reviewed-on: https://chromium-review.googlesource.com/607039
Commit-Queue: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492970}
[modify] https://crrev.com/36c0abdab86cc8d2717b75c46587f1c23c9ad032/third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.cpp

Comment 4 by junov@chromium.org, Aug 9 2017

Status: Fixed (was: Assigned)
Project Member

Comment 5 by ClusterFuzz, Aug 10 2017

ClusterFuzz has detected this issue as fixed in range 492866:493084.

Detailed report: https://clusterfuzz.com/testcase?key=5204731390853120

Fuzzer: inferno_twister
Job Type: linux_asan_content_shell_drt
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000020
Crash State:
  blink::OffscreenCanvas::GetOrCreateImageBuffer
  blink::OffscreenCanvasRenderingContext2D::commit
  blink::V8OffscreenCanvasRenderingContext2D::commitMethodCallback
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_content_shell_drt&range=473072:473106
Fixed: https://clusterfuzz.com/revisions?job=linux_asan_content_shell_drt&range=492866:493084

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5204731390853120

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 6 by ClusterFuzz, Aug 10 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 5204731390853120 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment