New issue
Advanced search Search tips

Issue 752768 link

Starred by 2 users
Status: Available
Owner: ----
Cc:
chromeos-continuous-integration-fire-hose@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature



Sign in to add a comment

FR: pre-cq-launcher should respect DetectRelevantChanges updates from pre-cq slaves

Project Member Reported by norvez@chromium.org, Aug 5 2017 

This pre-cq run failed: 
https://luci-milo.appspot.com/buildbot/chromiumos.tryserver/pre_cq/48055 

It failed because cheets_keyboardtest is flaky (Issue 653048), not because of the CL under test.

Looking at the DetectRelevantChanges stage, the pre-cq correctly identified that the CL wasn't relevant. However it still marked it as failing. It would nice if in that case the pre-cq let the CL go through. That's what the CQ does already I think?

Comment 1 by kirtika@google.com, Aug 11 2017 

More examples: 
https://chromium-review.googlesource.com/#/c/chromiumos/third_party/kernel/+/607932/

This is a 3.8 kernel CL and has nothing to do with betty which runs 4.4 kernel. 
Yet it was rejected :(

Comment 2 by pprabhu@chromium.org, Aug 21 2017

Cc: akes...@chromium.org nxia@chromium.org
Status: Untriaged (was: Unconfirmed)
Summary: pre-cq (was: pre-cq should not fail if the CLs tested aren't relevant)
Good point.

Currently pre-cq-launcher only looks at the success/failure of pre-cq slave when deciding if a CL should be promoted to CQ.
pre-cq-launcher can be updated to do as cq-master does, and only reject changes that are relevant to the failed pre-cq slave.

Comment 3 by pprabhu@chromium.org, Aug 21 2017

Summary: FR: pre-cq-launcher should respsect DetectRelevantChanges updates from pre-cq slaves (was: pre-cq)

Comment 4 by nxia@chromium.org, Aug 21 2017 

It's possible that there's a bug on TOT on that build, so it makes sense to not reject the CL if the CL is not relevant to the failed pre-cqs. My concern is if we don't reject the CL, pre-cq-launcher will keep retrying the pre-cq; and if the bug on TOT doesn't get resolved in time, the pool will be overwhelmed by this build.

Comment 5 by ayatane@chromium.org, Aug 22 2017

Owner: nxia@chromium.org
Status: Assigned (was: Untriaged)
I think nxia is qualified to make a decision on the best course of action.

Comment 6 by ayatane@chromium.org, Aug 22 2017

Summary: FR: pre-cq-launcher should respect DetectRelevantChanges updates from pre-cq slaves (was: FR: pre-cq-launcher should respsect DetectRelevantChanges updates from pre-cq slaves)

Comment 7 by akes...@chromium.org, Mar 30 2018

Components: Infra>Client>ChromeOS>CI

Comment 8 by akes...@chromium.org, Mar 30 2018

Components: -Infra>Client>ChromeOS

Comment 9 by nxia@chromium.org, May 31 2018

Cc: -akes...@chromium.org -nxia@chromium.org
Owner: ----
Status: Available (was: Assigned)
This will be a good improvement to reduce false rejection in pre-cq. Passing this to CI team.
►

Sign in to add a comment