New issue
Advanced search Search tips

Issue 752759 link

Starred by 2 users

Issue metadata

Status: Verified
Owner: ----
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Validate DrawCircleOp deserialization

Project Member Reported by ClusterFuzz, Aug 5 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6619929087574016

Fuzzer: libFuzzer_paint_op_buffer_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: Abrt
Crash Address: 0x03e900002c49
Crash State:
  sk_abort_no_print
  SkCanvas::onDrawOval
  SkCanvas::drawOval
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=491830:491916

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6619929087574016


Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.
 

Comment 1 by dm812...@gmail.com, Aug 5 2017

Yes
Components: Internals>Skia
Labels: M-62 Test-Predator-Wrong

Comment 3 by enne@chromium.org, Aug 7 2017

Cc: vmp...@chromium.org enne@chromium.org
Status: Available (was: Untriaged)
Summary: Validate DrawCircleOp deserialization (was: Abrt in sk_abort_no_print)
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5d293e1dfbcade28b8af4901c7a706c4355ac6b8

commit 5d293e1dfbcade28b8af4901c7a706c4355ac6b8
Author: Adrienne Walker <enne@chromium.org>
Date: Thu Aug 10 01:06:34 2017

Validate DrawCircleOp by turning it into DrawOvalOp

Rather than validating parameters to make sure that the SkRect that
SkCanvas::drawCircle creates is valid, just delete DrawCircleOp
entirely and use DrawOvalOp internally.

Bug:  752759 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I586e1eb0653adc72c258a03f6d916982c7d99069
Reviewed-on: https://chromium-review.googlesource.com/606773
Commit-Queue: enne <enne@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Vladimir Levin <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493203}
[modify] https://crrev.com/5d293e1dfbcade28b8af4901c7a706c4355ac6b8/cc/paint/paint_canvas.h
[modify] https://crrev.com/5d293e1dfbcade28b8af4901c7a706c4355ac6b8/cc/paint/paint_op_buffer.cc
[modify] https://crrev.com/5d293e1dfbcade28b8af4901c7a706c4355ac6b8/cc/paint/paint_op_buffer.h
[modify] https://crrev.com/5d293e1dfbcade28b8af4901c7a706c4355ac6b8/cc/paint/paint_op_buffer_unittest.cc
[modify] https://crrev.com/5d293e1dfbcade28b8af4901c7a706c4355ac6b8/cc/paint/record_paint_canvas.cc
[modify] https://crrev.com/5d293e1dfbcade28b8af4901c7a706c4355ac6b8/cc/paint/record_paint_canvas.h
[modify] https://crrev.com/5d293e1dfbcade28b8af4901c7a706c4355ac6b8/cc/paint/skia_paint_canvas.cc
[modify] https://crrev.com/5d293e1dfbcade28b8af4901c7a706c4355ac6b8/cc/paint/skia_paint_canvas.h
[modify] https://crrev.com/5d293e1dfbcade28b8af4901c7a706c4355ac6b8/cc/paint/solid_color_analyzer.cc
[modify] https://crrev.com/5d293e1dfbcade28b8af4901c7a706c4355ac6b8/cc/trees/layer_tree_host_pixeltest_masks.cc
[modify] https://crrev.com/5d293e1dfbcade28b8af4901c7a706c4355ac6b8/content/shell/test_runner/mock_web_theme_engine.cc
[modify] https://crrev.com/5d293e1dfbcade28b8af4901c7a706c4355ac6b8/third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp
[modify] https://crrev.com/5d293e1dfbcade28b8af4901c7a706c4355ac6b8/third_party/WebKit/Source/platform/graphics/test/MockPaintCanvas.h
[modify] https://crrev.com/5d293e1dfbcade28b8af4901c7a706c4355ac6b8/ui/app_list/folder_image.cc
[modify] https://crrev.com/5d293e1dfbcade28b8af4901c7a706c4355ac6b8/ui/gfx/canvas.cc

Project Member

Comment 5 by ClusterFuzz, Aug 10 2017

ClusterFuzz has detected this issue as fixed in range 493187:493236.

Detailed report: https://clusterfuzz.com/testcase?key=6619929087574016

Fuzzer: libFuzzer_paint_op_buffer_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: Abrt
Crash Address: 0x03e900002c49
Crash State:
  sk_abort_no_print
  SkCanvas::onDrawOval
  SkCanvas::drawOval
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=491830:491916
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=493187:493236

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6619929087574016

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 6 by ClusterFuzz, Aug 10 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Available)
ClusterFuzz testcase 6619929087574016 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment