New issue
Advanced search Search tips

Issue 752735 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug

Blocking:
issue 770184



Sign in to add a comment

Chrome arbitrarily fills server password to a LuCI configuration field

Reported by stanisla...@gmail.com, Aug 5 2017

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3112.90 Safari/537.36

Steps to reproduce the problem:
When using Chrome to configure router with a popular LuCI configuration tool, Chrome arbitrarily changes wireless PSK to the router password. This is bad, as wireless access is lost, and the server gets password in an unecrypted form.

1. Login to any router with LuCI configuration interface
2. Remember password
3. Go to Network -> Wifi -> radio0
4. Check that the mode is WPA2-PSK and there is a Key dialog.
4. Press Save and Apply

Note that I have auto-login enabled in Chrome password settings.

What is the expected behavior?
Chrome will keep PSK key as it is, especially if user does not touch it. It should not attempt to auto pre-fill the router password as a wireless PSK automatically, even if PSK is empty / not yet set.

What went wrong?
After these steps, Chrome changes Key (WPA2-PSK) from the original value to a password used in the login dialog. It happens even if I skip 4., i. e. Key input field remains hidden.

It means, that e. g. channel change will cause PSK change.

Did this work before? N/A 

Chrome version: 60.0.3112.90  Channel: stable
OS Version: openSUSE Leap 42.3
Flash Version: 

In the case of LuCI, this Chrome behavior has an implication of denial of wireless service of the router. But with other pages, this behavior (i. e. automatic filling of the main password, even to hidden input fields) can have bad security implications. Hacker can just add a hidden field and get passwords in unencrypted form, even if server itself does not store them.

When I remove stored password, the problem disappears.

Login and wireless setup pages have different URL on the same server.

Files in the attachment were saved after removing of the stored password. Sensitive data were replaced by stubs.
 
LuCI_pages.zip
34.4 KB Download
Components: UI>Browser>Passwords UI>Browser>Autofill
Labels: -Type-Bug-Security -Restrict-View-SecurityTeam Type-Bug
Summary: Chrome arbitrarily fills server password to a LuCI configuration field (was: Chrome arbitrarily fills server password to a random dialog)
This isn't a security vulnerability per-se (an attacker with the ability to introduce arbitrary markup into a site can already collect anything on that site, including credentials, which are scoped to that origin). 

However, it does sound like a feature issue with the password-filling logic. It may be possible to heuristically distinguish between the LuCI field and the router's configuration dialog.
Labels: Needs-Triage-M60
Labels: -Type-Bug Type-Feature
Status: Untriaged (was: Unconfirmed)
As per comment #1, it seems to be a feature request. Hence, marking it as untriaged for further investigation from dev team.

Thanks...!!
Labels: -Type-Feature Type-Bug
Sorry, to be clear, this issue claims that the password filler is overaggressive in recognizing the INPUT TYPE=PASSWORD fields in the affected pages. The question for the feature owners is whether there's something that can be tuned in the heuristics so this doesn't happen. 

Comment 5 by vabr@chromium.org, Oct 19 2017

Blocking: 770184
Labels: -Pri-2 Hotlist-Polish Pri-3
Status: Available (was: Untriaged)
Thanks for the report. I am grouping it under our umbrella bug for sites where we fill wrong fields.

Comment 6 by ma...@chromium.org, May 1 2018

Status: Untriaged (was: Available)
Components: -UI>Browser>Autofill
Status: Available (was: Untriaged)

Sign in to add a comment