New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 752729 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

[Regression] [NewTabPage]: The Apps Icon in the right top corner flickers when opening a NewTab

Project Member Reported by meh...@chromium.org, Aug 5 2017

Issue description

Chrome Version: Canary 62.0.3177.0 
OS: macOS 10.12.6

What steps will reproduce the problem?
(1) Press CMD+T to open a NewTabPage.
(2) Take a look at the Apps Icon in the right top corner during the NewTabPage opens.

What is the expected result?
The Apps Icon in the right top corner should not flicker.

What happens instead?
The Apps Icon in the right top corner flickers.

A screencast is attached. This is a regression. Works fine in latest Chrome Stable 60. I see this on macOS. Not sure, if this is also a regression on other platforms.
 
screencast.mov
1.2 MB Download

Comment 1 by treib@chromium.org, Aug 7 2017

I can *not* reproduce on Linux, Chrome Dev 62.0.3175.4. Will check on Windows soon.
Cc: hdodda@chromium.org
Labels: Needs-Feedback
Tested the issue on Mac os 10.12.6 (sierra & retina) and windows 7 using chrome M60 #60.0.3112.90 and M62 #62.0.3178.0 and followed below steps :

1. Pressed CMD+T to open a newtabpage.
2. and observed no flickering as attached screencast in original comment . And observed similar behavior in M60 and M62.

Attached screencast for reference.

@mehmet-- Could you please check attached screencast and help us in reproducing the issue , if we have missed any steps in it.

Thanks!
752729.mp4
901 KB View Download

Comment 3 by treib@chromium.org, Aug 7 2017

Interesting - I *can* see the issue on MacOS 10.12.6, Chrome Canary 62.0.3178.0. That indicates it's likely a server-side issue, maybe depending on locale. (I'm in Germany, same as the screencast in the original bug report.)

Comment 4 by treib@chromium.org, Aug 7 2017

Also note that the issue is somewhat inconsistent; seems to happen about half the time for me.

Comment 5 by treib@chromium.org, Aug 7 2017

Cc: nelinger@google.com yuvald@google.com
CCing some OneGoogle folks. Is it possible that some recent server-side change is causing this? This is the remote NTP with a Vasquette bar.

Comment 6 by treib@chromium.org, Aug 7 2017

Cc: ellabo@google.com aviad@google.com
+more OneGoogle folks. Any ideas what's going on?
If I understand the first comment correctly, especially the part about:
"This is a regression. Works fine in latest Chrome Stable 60" than I tend to believe that this is on the Chrome side (and not caused by a server side change).
The reason is that all Chrome versions (again, IINM) are wired to the same OneGogole service.

Comment 8 by treib@chromium.org, Aug 7 2017

I can *not* reproduce on Windows Canary; seems to be Mac only. I've also checked that it does not happen on Mac Stable (though it is hard to be completely sure, given that it doesn't happen every time).

So, latest theory is that it's a Mac-specific rendering issue in Chrome. Let's wait for that bisect.
Hi All,

I was able to find the regression range: https://chromium.googlesource.com/chromium/src/+log/255a96883ec1cb264854b04c31cd430a0942a6b7..7741cb0ad2ad1d8daae8c9ebc967b14538bbf888

But I am not sure, which change could cause this issue?!
Labels: -Type-Bug -Needs-Feedback -Needs-Bisect M-62 Type-Bug-Regression
Owner: khushals...@chromium.org
Status: Assigned (was: Untriaged)
Attached is a screenshot of the frame that's causing the flashing. A placeholder for the image, perhaps?

Can only think it might be

author	Khushal <khushalsagar@chromium.org>	Wed Jul 26 23:48:04 2017
committer	Commit Bot <commit-bot@chromium.org>	Wed Jul 26 23:48:04 2017

cc: Eliminate canvas overrides for replacing images.

Reviewed-on: https://chromium-review.googlesource.com/582330

Screen Shot 2017-08-07 at 1.55.45 PM.png
40.6 KB View Download
I have a 62.0.3178.0 canary build on 10.12.5 that I tried to repro this on but couldn't.

shrike@, could you share your chrome://gpu status? Any flag I could set to be certain to get a repro?
Sorry, I didn't mean to imply that I could repro (I can't) - I grabbed the frame from mehmet's screencast.

Hi khushalsagar@:

Not sure, if you can only reproduce it, when you are using Chrome in Germany (server-side issue?). 

Here is my chrome://gpu output:

Note: To properly save this page, select the "Webpage, Complete" option in the Save File dialog.
Graphics Feature Status
Canvas: Hardware accelerated
CheckerImaging: Enabled
Flash: Hardware accelerated
Flash Stage3D: Hardware accelerated
Flash Stage3D Baseline profile: Hardware accelerated
Compositing: Hardware accelerated
Multiple Raster Threads: Enabled
Native GpuMemoryBuffers: Hardware accelerated
Rasterization: Hardware accelerated
Video Decode: Hardware accelerated
Video Encode: Hardware accelerated
WebGL: Hardware accelerated
WebGL2: Hardware accelerated
Driver Bug Workarounds
add_and_true_to_loop_condition
adjust_src_dst_region_for_blitframebuffer
decode_encode_srgb_for_generatemipmap
disable_framebuffer_cmaa
disable_webgl_rgb_multisampling_usage
emulate_abs_int_function
get_frag_data_info_bug
init_two_cube_map_levels_before_copyteximage
msaa_is_slow
pack_parameters_workaround_with_pack_buffer
rebind_transform_feedback_before_resume
regenerate_struct_names
remove_invariant_and_centroid_for_essl3
rewrite_texelfetchoffset_to_texelfetch
scalarize_vec_and_mat_constructor_args
set_zero_level_before_generating_mipmap
unfold_short_circuit_as_ternary_operation
unpack_alignment_workaround_with_unpack_buffer
unpack_image_height_workaround_with_unpack_buffer
use_intermediary_for_copy_texture_image
use_unused_standard_shared_blocks
Problems Detected
Unfold short circuit on Mac OS X: 307751
Applied Workarounds: unfold_short_circuit_as_ternary_operation
Always rewrite vec/mat constructors to be consistent: 398694
Applied Workarounds: scalarize_vec_and_mat_constructor_args
Mac drivers handle struct scopes incorrectly: 403957
Applied Workarounds: regenerate_struct_names
On Intel GPUs MSAA performance is not acceptable for GPU rasterization: 527565
Applied Workarounds: msaa_is_slow
glGenerateMipmap fails if the zero texture level is not set on some Mac drivers: 560499
Applied Workarounds: set_zero_level_before_generating_mipmap
Pack parameters work incorrectly with pack buffer bound: 563714
Applied Workarounds: pack_parameters_workaround_with_pack_buffer
Alignment works incorrectly with unpack buffer bound: 563714
Applied Workarounds: unpack_alignment_workaround_with_unpack_buffer
copyTexImage2D fails when reading from IOSurface on multiple GPU types.: 581777
Applied Workarounds: use_intermediary_for_copy_texture_image
Multisample renderbuffers with format GL_RGB8 have performance issues on Intel GPUs.: 607130
Applied Workarounds: disable_webgl_rgb_multisampling_usage
Limited enabling of Chromium GL_INTEL_framebuffer_CMAA: 535198
Applied Workarounds: disable_framebuffer_cmaa
glGetFragData{Location|Index} works incorrectly on Max: 638340
Applied Workarounds: get_frag_data_info_bug
glResumeTransformFeedback works incorrectly on Intel GPUs: 638514
Applied Workarounds: rebind_transform_feedback_before_resume
Result of abs(i) where i is an integer in vertex shader is wrong: 642227
Applied Workarounds: emulate_abs_int_function
Rewrite texelFetchOffset to texelFetch for Intel Mac: 642605
Applied Workarounds: rewrite_texelfetchoffset_to_texelfetch
Rewrite condition in for and while loops for Intel Mac: 644669
Applied Workarounds: add_and_true_to_loop_condition
Decode and encode before generateMipmap for srgb format textures on macosx: 634519
Applied Workarounds: decode_encode_srgb_for_generatemipmap
Init first two levels before CopyTexImage2D for cube map texture on Intel Mac 10.12: 648197
Applied Workarounds: init_two_cube_map_levels_before_copyteximage
Insert statements to reference all members in unused std140/shared blocks on Mac: 618464
Applied Workarounds: use_unused_standard_shared_blocks
Tex(Sub)Image3D performs incorrectly when uploading from unpack buffer with GL_UNPACK_IMAGE_HEIGHT greater than zero on Intel Macs: 654258
Applied Workarounds: unpack_image_height_workaround_with_unpack_buffer
adjust src/dst region if blitting pixels outside read framebuffer on Mac: 644740
Applied Workarounds: adjust_src_dst_region_for_blitframebuffer
Mac driver GL 4.1 requires invariant and centroid to match between shaders: 639760, 641129
Applied Workarounds: remove_invariant_and_centroid_for_essl3
Disable KHR_blend_equation_advanced until cc shaders are updated: 661715
On Intel GPUs MSAA performance is not acceptable for GPU rasterization: 527565, 751919
Applied Workarounds: msaa_is_slow
Version Information
Data exported	8.8.2017, 00:36:39
Chrome version	Chrome/62.0.3178.0
Operating system	Mac OS X 10.12.6
Software rendering list version	13.10
Driver bug list version	10.24
ANGLE commit id	13c0dd4631b1
2D graphics backend	Skia/62 155e94297a466a4e4c4c3e353359de18ab9720ab-
Command Line	/Applications/Google Chrome Canary.app/Contents/MacOS/Google Chrome Canary --flag-switches-begin --flag-switches-end
Driver Information
Initialization time	67
In-process GPU	false
Passthrough Command Decoder	false
Supports overlays	false
Sandboxed	true
GPU0	VENDOR = 0x8086, DEVICE= 0x0166 *ACTIVE*
Optimus	false
Optimus	false
AMD switchable	false
Driver vendor	
Driver version	10.25.17
Driver date	
Pixel shader version	4.10
Vertex shader version	4.10
Max. MSAA samples	8
Machine model name	MacBookAir
Machine model version	5.1
GL_VENDOR	Intel Inc.
GL_RENDERER	Intel HD Graphics 4000 OpenGL Engine
GL_VERSION	4.1 INTEL-10.25.17
GL_EXTENSIONS	GL_ARB_blend_func_extended GL_ARB_draw_buffers_blend GL_ARB_draw_indirect GL_ARB_ES2_compatibility GL_ARB_explicit_attrib_location GL_ARB_gpu_shader_fp64 GL_ARB_gpu_shader5 GL_ARB_instanced_arrays GL_ARB_internalformat_query GL_ARB_occlusion_query2 GL_ARB_sample_shading GL_ARB_sampler_objects GL_ARB_separate_shader_objects GL_ARB_shader_bit_encoding GL_ARB_shader_subroutine GL_ARB_shading_language_include GL_ARB_tessellation_shader GL_ARB_texture_buffer_object_rgb32 GL_ARB_texture_cube_map_array GL_ARB_texture_gather GL_ARB_texture_query_lod GL_ARB_texture_rgb10_a2ui GL_ARB_texture_storage GL_ARB_texture_swizzle GL_ARB_timer_query GL_ARB_transform_feedback2 GL_ARB_transform_feedback3 GL_ARB_vertex_attrib_64bit GL_ARB_vertex_type_2_10_10_10_rev GL_ARB_viewport_array GL_EXT_debug_label GL_EXT_debug_marker GL_EXT_framebuffer_multisample_blit_scaled GL_EXT_texture_compression_s3tc GL_EXT_texture_filter_anisotropic GL_EXT_texture_sRGB_decode GL_APPLE_client_storage GL_APPLE_container_object_shareable GL_APPLE_flush_render GL_APPLE_object_purgeable GL_APPLE_rgb_422 GL_APPLE_row_bytes GL_APPLE_texture_range GL_ATI_texture_mirror_once GL_NV_texture_barrier
Disabled Extensions	GL_KHR_blend_equation_advanced GL_KHR_blend_equation_advanced_coherent
Window system binding vendor	
Window system binding version	
Window system binding extensions	
Direct rendering	Yes
Reset notification strategy	0x0000
GPU process crash count	0
Compositor Information
Tile Update Mode	Zero-copy
Partial Raster	Enabled
GpuMemoryBuffers Status
ATC	Software only
ATCIA	Software only
DXT1	Software only
DXT5	Software only
ETC1	Software only
R_8	GPU_READ_CPU_READ_WRITE, GPU_READ_CPU_READ_WRITE_PERSISTENT
R_16	Software only
RG_88	Software only
BGR_565	Software only
RGBA_4444	Software only
RGBX_8888	Software only
RGBA_8888	GPU_READ, SCANOUT, SCANOUT_CPU_READ_WRITE
BGRX_8888	GPU_READ, SCANOUT, SCANOUT_CPU_READ_WRITE
BGRA_8888	GPU_READ, SCANOUT, SCANOUT_CPU_READ_WRITE, GPU_READ_CPU_READ_WRITE, GPU_READ_CPU_READ_WRITE_PERSISTENT
RGBA_F16	GPU_READ_CPU_READ_WRITE, GPU_READ_CPU_READ_WRITE_PERSISTENT
YVU_420	Software only
YUV_420_BIPLANAR	GPU_READ_CPU_READ_WRITE, GPU_READ_CPU_READ_WRITE_PERSISTENT
UYVY_422	GPU_READ_CPU_READ_WRITE, GPU_READ_CPU_READ_WRITE_PERSISTENT

Aha, its CheckerImaging. Go to about:flags and disable AsyncImageDecoding and that fixes it. I'll look into a fix.
Yes, changing the flag of AsyncImageDecoding from Default to Disabled fixes the problem.

Thank you for looking for a fix in advance :-)
Cc: vmp...@chromium.org
Labels: zine-triaged
Project Member

Comment 19 by bugdroid1@chromium.org, Aug 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6fa252c7503b24f2aad3735d3641b3dd04edf4c1

commit 6fa252c7503b24f2aad3735d3641b3dd04edf4c1
Author: Khushal <khushalsagar@chromium.org>
Date: Thu Aug 10 22:40:36 2017

cc: Skip ops with no decode available.

If a decoded image for a shader isn't available, skip the draw op
instead of rasterizing it without the shader.

Bug:  752729 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ia689a93536d09332f62dcd5e60a43b1674221a88
Reviewed-on: https://chromium-review.googlesource.com/611006
Commit-Queue: Khushal <khushalsagar@chromium.org>
Reviewed-by: Vladimir Levin <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493574}
[modify] https://crrev.com/6fa252c7503b24f2aad3735d3641b3dd04edf4c1/cc/paint/paint_op_buffer.cc
[modify] https://crrev.com/6fa252c7503b24f2aad3735d3641b3dd04edf4c1/cc/paint/paint_op_buffer_unittest.cc

Status: Fixed (was: Assigned)
Yup, fixed in latest Canary Version 62.0.3182.0. Thanks!

Sign in to add a comment