New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 752716 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Buried. Ping if important.
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: 2017-08-21
OS: Linux , Android , Windows , Mac
Pri: 1
Type: Bug-Regression


Show other hotlists

Hotlists containing this issue:
Hotlist-1


Sign in to add a comment

Dropbox saver does not work in Chrome 61+

Reported by j...@textio.com, Aug 5 2017

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/603.3.8 (KHTML, like Gecko) Version/10.1.2 Safari/603.3.8

Steps to reproduce the problem:
1. Navigate to https://www.dropbox.com/developers/saver
2. Click on the example "Save to Dropbox" button
3. Enter valid dropbox credentials if necessary (issue still repros if cached creds are used)
4. Pick the suggested save location *or* browse to find a different one
5. Attempt to save

What is the expected behavior?
The sample png should be saved in the selected location

What went wrong?
The sample is not saved. Additionally, in step 4, the browse to folder option may not work at all. 

Did this work before? Yes 60 - stable

Chrome version: 62.0.3177.0  Channel: dev
OS Version: OS X 10.12.6
Flash Version: 

Initially discovered in dev channel 61, reproduced today when 61 moved to beta, and then reproduced in Canary/62 and latest Chromium builds
 

Comment 1 by kochi@chromium.org, Aug 7 2017

Labels: Needs-Feedback
NextAction: 2017-08-21
Status: Untriaged (was: Unconfirmed)
Hmm, I am not able to save the file to my personal dropbox account either,
on 60.0.3112.90 (Official Build) (64-bit) Linux.
On Mac, I could use the "save" button on stable 59.0.3071.115 or 60.0.3112.90,
but could not on canary 62.0.3178.0 (same result as yours).
So from my experiments M60 could still be affected (at least on Linux).

I don't see any suspicious error message on JavaScript console, so I'm not sure
what is going on, also not sure any change caused the saver code to stop
working.

I'd suggest you'd contact DropBox first so they can identify the issue, and
if there is something that we can fix, we can work on it.

Comment 2 by j...@textio.com, Aug 7 2017

Hrm. I pulled down 60.0.3112.90 on Ubuntu LTS and was able to save without issue, so it looks to me like it's something consistent with builds of Chromium at least. I could certainly contact Dropbox about this, but I suspect, given the evidence that they'd just direct me back to here. :-)
The NextAction date has arrived: 2017-08-21

Comment 4 by jen...@jensen.cx, Aug 21 2017

This is still broken in Chrome Beta 61.0.3163.49 on all platforms. It breaks Dropbox integration for thousands of web sites.

Works in Chrome 60 (stable release channel).

You can easily see the repro by clicking on the Save to Dropbox button in their documentation site: https://www.dropbox.com/developers/saver.

Comment 5 by tkent@chromium.org, Aug 21 2017

Labels: -Pri-2 ReleaseBlock-Stable M-61 Needs-Bisect Pri-1

Comment 6 by gov...@chromium.org, Aug 21 2017

[Bulk Edit]
URGENT - PTAL.
M61 Stable promotion is coming soon and your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged into the release branch ASAP. 

Know that this issue shouldn't block the release?  Remove the ReleaseBlock-Stable label or move to M62. Thank you!

Note: We will only have 2 beta releases before Stable promotion. Plan is to cut M61 Stable RC on 08/31/17.

Comment 7 by nasko@chromium.org, Aug 22 2017

Can you paste the output of chrome://version and especially the Variations part for the release you are able to repro with? Also, does it repro if Chrome is started with --disable-features=browser-side-navigation?

Comment 8 by jen...@jensen.cx, Aug 22 2017

It does still repro with --disable-features=browser-side-navigation.

I don't think it is specific to any particular flavor of Chrome (it also repros on my Windows v61 VM for instance) but here's the output of chrome://version:

Google Chrome	61.0.3163.49 (Official Build) beta (64-bit)
Revision	97efb89dab9d3a6340b8e86378baafedff752f3b-refs/branch-heads/3163@{#578}
OS	Mac OS X
JavaScript	V8 6.1.534.22
Flash	27.0.0.96 /Users/jensen/Library/Application Support/Google/Chrome/PepperFlash/27.0.0.96/PepperFlashPlayer.plugin
User Agent	Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/61.0.3163.49 Safari/537.36
Command Line	/Applications/Google Chrome.app/Contents/MacOS/Google Chrome --flag-switches-begin --flag-switches-end
Executable Path	/Applications/Google Chrome.app/Contents/MacOS/Google Chrome
Profile Path	/Users/jensen/Library/Application Support/Google/Chrome/Default
Variations	c04e5123-cf4f6ead
6c18ba9d-10f9cf26
c68ab9a3-6edc92c7
38eb801c-3f4a17df
7c1bc906-f55a7974
47e5d3db-3d47f4f4
776de70c-e0278d3d
79616653-3f4a17df
a605b19e-ca7d8d80
5ca89f9-f23d1dea
9e201a2b-d151e2f5
d0165945-3f4a17df
b21cf1cf-ca7d8d80
68812885-3f4a17df
94702c12-8e8e4a2b
f347910c-f23d1dea
b791c1b8-f23d1dea
9773d3bd-f23d1dea
99144bc3-dc4a3f77
9e5c75f1-abc77297
f79cb77b-3d47f4f4
23a898eb-3f2db5fb
4ea303a6-ecbb250e
d92562a9-97fcc22f
de03e059-e65e20f2
ad6d27cc-7075cd8
b2f0086-93053e47
4bc337ce-f23d1dea
1354da85-f34af386
494d8760-1410f10
3ac60855-486e2a9c
f296190c-116bbed1
4442aae2-a5822863
ed1d377-e1cc0f14
75f0f0a0-4ad60575
e2b18481-e1cc0f14
e7e71889-e1cc0f14
644b8345-f23d1dea
94e68624-f23d1dea
828a5926-8f2c913
Labels: Needs-Triage-M61
Labels: -Needs-Feedback

Comment 11 by nasko@chromium.org, Aug 23 2017

Can someone bisect this? It will be useful to narrow down what causes this regression and to ensure it is/is not related to PlzNavigate.
Labels: -Needs-Triage-M61
Owner: pbomm...@chromium.org
Status: Assigned (was: Untriaged)
I am able to reproduce the issue working on bisect now.
Cc: pbomm...@chromium.org gov...@chromium.org
Components: -Blink Blink>SecurityFeature Blink>SecurityFeature>ContentSecurityPolicy
Owner: mkwst@chromium.org
Please find the bisect result below :

You are probably looking for a change made after 478589 (known good), but no lat
er than 478590 (first known bad).
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/48e5a7f1adf55ec695f3c24bdf648db251b933d3..7bcb9ee52f2600bafddabaed884ccfea52916753
Labels: -Needs-Bisect
Labels: OS-Android OS-Linux OS-Windows
oop's forgot to update that this is across the platforms, Since blink I am tagging android as well.

Comment 16 by mkwst@chromium.org, Aug 23 2017

Cc: d...@dropbox.com
Looks like Dropbox is trying to access `u.getAttribute("nonce")` in https://cfl.dropboxstatic.com/static/compiled/js/packaged/pkg-core.min-vfl7GBVS6.js, which won't work in the brave new world of hidden nonce values.

Dev (CCd), how would you feel about replacing that with something like `u.nonce || u.getAttribute('nonce')`? (I feel like we talked about this before... :) ).

Comment 17 by akh...@dropbox.com, Aug 23 2017

huh .. I thought we fixed this. taking a look. 

Comment 18 by akh...@dropbox.com, Aug 23 2017

I think I know whats happening. Found one place where we overlooked this change. Sorry .. working on this. should be fixed tomorrow. thanks for escalating to me.
Per comment #18, no fix is needed from Chrome side, correct?
Labels: -ReleaseBlock-Stable
I am removing the release block stable since this is external dependency.

Comment 21 by jen...@jensen.cx, Aug 25 2017

This appears fixed in the version of Dropbox Saver pushed today.

Comment 22 by akh...@dropbox.com, Aug 25 2017

yup. Sorry again and thanks for filing the bug and escalating here.

Comment 23 by mkwst@chromium.org, Aug 31 2017

Status: WontFix (was: Assigned)

Comment 24 by mkwst@chromium.org, Aug 31 2017

Thanks, Dev!

Sign in to add a comment