New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 752705 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 752440



Sign in to add a comment

Kiosk mode: Trying to launch network config screen hangs when network config is disallowed

Project Member Reported by michae...@chromium.org, Aug 5 2017

Issue description

Chrome Version: 61, 62

0. Have a device be enterprise-enrolled
1. Launch an app in Kiosk mode
2. At the app loading splash screen, hit Ctrl+Alt+N

Expected: Nothing happens because network config is disallowed. App finishes loading.

Actual: The loading text changes to "Internet disconnected. Please check your internet connection." Nothing more happens. The device must be restarted.
 
Blocking: 752440
Labels: M-61
Owner: xiy...@chromium.org
Status: Assigned (was: Untriaged)
Labels: -Pri-3 Pri-2
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4226f48ce099df93e1f3e4c05a985c2ac094cc38

commit 4226f48ce099df93e1f3e4c05a985c2ac094cc38
Author: Xiyuan Xia <xiyuan@chromium.org>
Date: Tue Aug 08 18:40:32 2017

kiosk: Restore prompt_for_network_when_offline default to true

Partial revert of https://codereview.chromium.org/2920253003
to restore the default of prompt_for_network_when_offline policy.

BUG= 752705 , 719907 

Change-Id: Idfa0b4f7df100b7569de9d32aa87fffd0dde5550
Reviewed-on: https://chromium-review.googlesource.com/606708
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492710}
[modify] https://crrev.com/4226f48ce099df93e1f3e4c05a985c2ac094cc38/chrome/browser/chromeos/login/app_launch_controller.cc
[modify] https://crrev.com/4226f48ce099df93e1f3e4c05a985c2ac094cc38/chrome/browser/chromeos/policy/proto/chrome_device_policy.proto

Labels: -Pri-2 Merge-Request-61 Pri-1
Let's merge the partial revert in #4 to M61 and figure out the correct thing for  issue 719907  later.
Cc: josa...@chromium.org
Labels: -Merge-Request-61 Merge-Approved-61
Approving merge to M61 Chrome OS.
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 8 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d83a85e0407f159d68b4097da3cce4962a7b5527

commit d83a85e0407f159d68b4097da3cce4962a7b5527
Author: Xiyuan Xia <xiyuan@chromium.org>
Date: Tue Aug 08 19:25:12 2017

Merge "kiosk: Restore prompt_for_network_when_offline default to true"

> Partial revert of https://codereview.chromium.org/2920253003
> to restore the default of prompt_for_network_when_offline policy.
>
> BUG= 752705 , 719907 
>
> Change-Id: Idfa0b4f7df100b7569de9d32aa87fffd0dde5550
> Reviewed-on: https://chromium-review.googlesource.com/606708
> Reviewed-by: Toni Barzic <tbarzic@chromium.org>
> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#492710}
> (cherry picked from commit 4226f48ce099df93e1f3e4c05a985c2ac094cc38)

TBR=xiyuan@chromium.org

Change-Id: I20a6f95eff273e36b587c4d8238352c297271d62
Reviewed-on: https://chromium-review.googlesource.com/606703
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#387}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/d83a85e0407f159d68b4097da3cce4962a7b5527/chrome/browser/chromeos/login/app_launch_controller.cc
[modify] https://crrev.com/d83a85e0407f159d68b4097da3cce4962a7b5527/chrome/browser/chromeos/policy/proto/chrome_device_policy.proto

Comment 9 by xiy...@chromium.org, Aug 15 2017

Status: Fixed (was: Assigned)
Cc: mlight@chromium.org
Status: Verified (was: Fixed)

Sign in to add a comment