New issue
Advanced search Search tips

Issue 752702 link

Starred by 1 user
Status: Started
Owner:
satorux@chromium.org
Cc:
lazyboy@chromium.org
gab@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Make third_party/ ZipReader Sequence friendly

Project Member Reported by lazyboy@chromium.org, Aug 5 2017 
While migrating chrome/browser/extensions/api/image_writer_private
code to Sequences (as part of Task Scheduler migration), I found that
ZipReader::ExtractCurrentEntryToFilePathAsync
called from
chrome/browser/extensions/api/image_writer_private/operation.cc issues

base::ThreadTaskRunnerHandle::Get()->PostTask

So running ZipReader on a SequencedTaskRunner isn't currently possible.
This made me use a SingleThreadTaskRunner to run ZipReader.

reference:
https://chromium-review.googlesource.com/c/596671

Comment 1 by satorux@chromium.org, Dec 26 2017 

To do that, I think ExtractCurrentEntryToFilePathAsync() should take a sequenced task runner. 

https://cs.chromium.org/chromium/src/chrome/browser/extensions/api/image_writer_private/unzip_helper.cc has a sequenced task runner so I think it should be an easy change. Let me see if I can make that change quickly...

Comment 2 by satorux@chromium.org, Dec 26 2017

Status: Started (was: Assigned)
Created a CL https://chromium-review.googlesource.com/c/chromium/src/+/844258
►

Sign in to add a comment