New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 752691 link

Starred by 1 user
Status: Fixed
Owner:
█ jcivelli@chromium.org
Last visit > 30 days ago
Closed: Sep 2017
Cc:
█ jcivelli@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

ChildProcessLauncherHelperTest.testBindServiceFromMultipleProcesses failed in consecutive N5X+M runs

Project Member Reported by jbudorick@chromium.org, Aug 4 2017 
in both cases, it failed with:

junit.framework.AssertionFailedError: The connection wasn't established.
	at junit.framework.Assert.fail(Assert.java:50)
	at junit.framework.Assert.assertTrue(Assert.java:20)
	at org.chromium.content.browser.test.util.CriteriaHelper.pollInstrumentationThread(CriteriaHelper.java:79)
	at org.chromium.content.browser.test.util.CriteriaHelper.pollInstrumentationThread(CriteriaHelper.java:94)
	at org.chromium.content.browser.ChildProcessLauncherHelperTest.blockUntilConnected(ChildProcessLauncherHelperTest.java:480)
	at org.chromium.content.browser.ChildProcessLauncherHelperTest.startSandboxedChildProcessWithCreationParams(ChildProcessLauncherHelperTest.java:471)
	at org.chromium.content.browser.ChildProcessLauncherHelperTest.testBindServiceFromMultipleProcesses(ChildProcessLauncherHelperTest.java:225)

from: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.android%2FAndroid_N5X_Swarm_Builder%2F14200%2F%2B%2Frecipes%2Fsteps%2Fcontent_shell_test_apk_on_Android%2F0%2Flogs%2Forg.chromium.content.browser.ChildProcessLauncherHelperTest_testBindServiceFromMultipleProcesses%2F0

notable logcat:

08-04 21:34:10.782 20915 20927 E cr_ChildProcessService: Service is already bound by pid 20899, cannot bind for pid 20884
08-04 21:34:10.784 20884 20931 E cr_ChildProcLauncher: ChildProcessConnection.start failed, trying again

from: https://luci-logdog.appspot.com/v/?s=chromium%2Fandroid%2Fswarming%2Flogcats%2F37c7f8c872e64311%2F%2B%2Flogcat_org.chromium.content.browser.ChildProcessLauncherHelperTest.testBindServiceFromMultipleProcesses_20170804T213410-UTC_00ca940725cebace

Not clear yet whether this is a flake or a stable failure.
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4e2739e781a86284f15852f8a97e001da1f9d98d

commit 4e2739e781a86284f15852f8a97e001da1f9d98d
Author: Max Morin <maxmorin@chromium.org>
Date: Thu Aug 17 10:14:21 2017

Disable testBindServiceFromMultipleProcesses

Disable the flaky
ChildProcessLauncherHelperTest.testBindServiceFromMultipleProcesses
test.

BUG= 752691 
TBR=aelias
NOTRY=true

Change-Id: I6c39a4789b8187aa53b29a63130acedc2f6e7a76
Reviewed-on: https://chromium-review.googlesource.com/618712
Reviewed-by: Max Morin <maxmorin@chromium.org>
Commit-Queue: Max Morin <maxmorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495126}
[modify] https://crrev.com/4e2739e781a86284f15852f8a97e001da1f9d98d/content/public/android/javatests/src/org/chromium/content/browser/ChildProcessLauncherHelperTest.java
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec1acaec01e4bcae22cb604cf62502e8403ad1f3

commit ec1acaec01e4bcae22cb604cf62502e8403ad1f3
Author: Max Morin <maxmorin@chromium.org>
Date: Thu Aug 17 10:45:51 2017

Revert "Disable testBindServiceFromMultipleProcesses"

This reverts commit 4e2739e781a86284f15852f8a97e001da1f9d98d.

Reason for revert: Breaks build

Original change's description:
> Disable testBindServiceFromMultipleProcesses
> 
> Disable the flaky
> ChildProcessLauncherHelperTest.testBindServiceFromMultipleProcesses
> test.
> 
> BUG= 752691 
> TBR=aelias
> NOTRY=true
> 
> Change-Id: I6c39a4789b8187aa53b29a63130acedc2f6e7a76
> Reviewed-on: https://chromium-review.googlesource.com/618712
> Reviewed-by: Max Morin <maxmorin@chromium.org>
> Commit-Queue: Max Morin <maxmorin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#495126}

TBR=aelias@chromium.org,maxmorin@chromium.org

Change-Id: I48e5cf4c64fcc1fb859e7e5850b08092144e86ed
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  752691 
Reviewed-on: https://chromium-review.googlesource.com/618630
Reviewed-by: Max Morin <maxmorin@chromium.org>
Commit-Queue: Max Morin <maxmorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495132}
[modify] https://crrev.com/ec1acaec01e4bcae22cb604cf62502e8403ad1f3/content/public/android/javatests/src/org/chromium/content/browser/ChildProcessLauncherHelperTest.java
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d7ed43c1d83c7c3358518801685ae51cfc5ce8d9

commit d7ed43c1d83c7c3358518801685ae51cfc5ce8d9
Author: Max Morin <maxmorin@chromium.org>
Date: Fri Aug 18 06:30:23 2017

Reland disable testBindServiceFromMultipleProcesses

Disable the flaky
ChildProcessLauncherHelperTest.testBindServiceFromMultipleProcesses
test.

BUG= 752691 
TBR=aelias

Change-Id: If0a771595728fdb5182e43373e837fe1e51d2d25
Reviewed-on: https://chromium-review.googlesource.com/618587
Commit-Queue: Max Morin <maxmorin@chromium.org>
Reviewed-by: Max Morin <maxmorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495488}
[modify] https://crrev.com/d7ed43c1d83c7c3358518801685ae51cfc5ce8d9/content/public/android/javatests/src/org/chromium/content/browser/ChildProcessLauncherHelperTest.java

Comment 6 by mattcary@chromium.org, Aug 21 2017

Labels: -sheriff-android
Removing from sheriff queue.

Comment 7 by jcivelli@chromium.org, Aug 21 2017

Owner: jcivelli@chromium.org
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a23c62a5ef609bd56f8ee6a70043ee2901e89c2a

commit a23c62a5ef609bd56f8ee6a70043ee2901e89c2a
Author: Jay Civelli <jcivelli@google.com>
Date: Mon Aug 21 18:53:01 2017

Fixing flaky test testBindServiceFromMultipleProcesses.

Attempt at fixing the test ChildProcessLauncherHelperTest.
testBindServiceFromMultipleProcesses which is flaky.
It seems on some devices the service process does not go away fast
enough even if no clients are bound to it, so when we try to connect
we fail.
Now forcing the process to die on disconnect.

Bug:  752691 
Change-Id: I69d0efe5c153b754ef41ac0fa801b76e7ed8120d
Reviewed-on: https://chromium-review.googlesource.com/623969
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496006}
[modify] https://crrev.com/a23c62a5ef609bd56f8ee6a70043ee2901e89c2a/content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ChildProcessLauncherTestHelperService.java

Comment 9 by jcivelli@chromium.org, Aug 21 2017 

Let's see if that fix addresses the flakyness.
I'll close the bug if it does.

Comment 10 by jcivelli@chromium.org, Sep 18 2017

Status: Fixed (was: Untriaged)
I don't see the test failing anymore, closing this bug.
►

Sign in to add a comment