New issue
Advanced search Search tips

Issue 752690 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: ----
Type: Feature

Blocking:
issue 664630



Sign in to add a comment

Import or implement CBOR encoder

Project Member Reported by kpaulhamus@chromium.org, Aug 4 2017

Issue description

Required to encode the data returned from a U2F authenticator.
 
Blocking: 664630
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6efcf495521d18d060027762f48bb292d6979136

commit 6efcf495521d18d060027762f48bb292d6979136
Author: Kim Paulhamus <kpaulhamus@chromium.org>
Date: Thu Sep 14 22:46:27 2017

Implement a basic CBOR encoder.

CBOR encoding is defined by the spec:
https://tools.ietf.org/html/rfc7049

This implementation supports definite-length encoding for the following
major types:
0 (unsigned int)
2 (byte string)
3 (text string)
4 (array)
5 (map)

Bug:  752690 
Change-Id: Id0d475d0d6706018c74470aff1010c0c54e4f3d3
Reviewed-on: https://chromium-review.googlesource.com/602866
Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Chris Palmer <palmer@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Jeffrey Yasskin <jyasskin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502060}
[modify] https://crrev.com/6efcf495521d18d060027762f48bb292d6979136/content/browser/BUILD.gn
[add] https://crrev.com/6efcf495521d18d060027762f48bb292d6979136/content/browser/webauth/cbor/cbor_values.cc
[add] https://crrev.com/6efcf495521d18d060027762f48bb292d6979136/content/browser/webauth/cbor/cbor_values.h
[add] https://crrev.com/6efcf495521d18d060027762f48bb292d6979136/content/browser/webauth/cbor/cbor_values_unittest.cc
[add] https://crrev.com/6efcf495521d18d060027762f48bb292d6979136/content/browser/webauth/cbor/cbor_writer.cc
[add] https://crrev.com/6efcf495521d18d060027762f48bb292d6979136/content/browser/webauth/cbor/cbor_writer.h
[add] https://crrev.com/6efcf495521d18d060027762f48bb292d6979136/content/browser/webauth/cbor/cbor_writer_unittest.cc
[modify] https://crrev.com/6efcf495521d18d060027762f48bb292d6979136/content/test/BUILD.gn

Status: Fixed (was: Assigned)

Sign in to add a comment