Issue metadata
Sign in to add a comment
|
Touchable launcher: White strip is seen below search bar |
||||||||||||||||||||||
Issue descriptionGoogle Chrome 62.0.3176.0 (Official Build) dev (64-bit) Revision 0 Platform 9807.0.0 (Official Build) dev-channel caroline What steps will reproduce the problem? 1. Open launcher 2. Type some query in the search bar 3. Tap anywhere on the launcher to dismiss search result view What happens? White strip is seen below search bar. The width of the strip is not consistent Attached screenshots.
,
Aug 7 2017
+weidongg, related to the search box view changes?
,
Aug 7 2017
I think this is caused by the fixing the text broken in crbug.com/746563 by setting the SearchResultView's background from transparent to colored.
,
Aug 7 2017
I just imaged samus with ToT build, the broken text seems to be fixed even without setting the SearchResultView's background to be colored. Could you confirm this on your devices? If that's true, we could simply revert the change.
,
Aug 7 2017
,
Aug 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8a2c3e2686d0b6113581d4920f355dc17a5a32e0 commit 8a2c3e2686d0b6113581d4920f355dc17a5a32e0 Author: Weidong Guo <weidongg@chromium.org> Date: Tue Aug 08 23:35:30 2017 cros: Fix white strip below search bar Reason: The white strip is caused by the background of SearchCardView. Changes: Remove the background color of SearchCardView and SearchResultView, because SearchResultPageView's background color is already set and all child views should have the same background color. This also help prevent the rounded corner of SearchResuldPageView being overwritten by child view's background. BUG= 752685 Change-Id: Ic606240a40326c6ef95cde7f9d43fcb0cee8864a Reviewed-on: https://chromium-review.googlesource.com/604396 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#492773} [modify] https://crrev.com/8a2c3e2686d0b6113581d4920f355dc17a5a32e0/ui/app_list/views/search_result_page_view.cc [modify] https://crrev.com/8a2c3e2686d0b6113581d4920f355dc17a5a32e0/ui/app_list/views/search_result_view.cc
,
Aug 9 2017
,
Aug 9 2017
Issue 753808 has been merged into this issue.
,
Aug 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fa8ee5f2a35df83bf90994e0dddef01fd68a7d12 commit fa8ee5f2a35df83bf90994e0dddef01fd68a7d12 Author: Maajid <maajid@chromium.org> Date: Thu Aug 10 23:05:02 2017 cros: Fix white strip below search bar Reason: The white strip is caused by the background of SearchCardView. Changes: Remove the background color of SearchCardView and SearchResultView, because SearchResultPageView's background color is already set and all child views should have the same background color. This also help prevent the rounded corner of SearchResuldPageView being overwritten by child view's background. BUG= 752685 TBR=weidongg@chromium.org (cherry picked from commit 8a2c3e2686d0b6113581d4920f355dc17a5a32e0) Change-Id: Ic606240a40326c6ef95cde7f9d43fcb0cee8864a Reviewed-on: https://chromium-review.googlesource.com/604396 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#492773} Reviewed-on: https://chromium-review.googlesource.com/611282 Reviewed-by: Vadim Tryshev <vadimt@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#467} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/fa8ee5f2a35df83bf90994e0dddef01fd68a7d12/ui/app_list/views/search_result_page_view.cc [modify] https://crrev.com/fa8ee5f2a35df83bf90994e0dddef01fd68a7d12/ui/app_list/views/search_result_view.cc
,
Aug 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9985985766911f64a17053fff4575733568447ed commit 9985985766911f64a17053fff4575733568447ed Author: Weidong Guo <weidongg@chromium.org> Date: Mon Aug 14 22:57:26 2017 Fix broken text in fullscreen app list Known issue: All text in SearchResultPageView is broken randomly when typing query in the search box. One work-around fix is setting a solid color background. But setting SearchResultView's background color will cause issue in crbug.com/752685 and overwrite the border corner radius of SearchResultPageView during animation. Changes: 1. Set all the text's background to be kCardBackgroundColorFullscreen to prevent broken text while not breaking the animation. 2. Adjust price and rating's bounds to avoid one's solid background blocking the other's. BUG= 746563 , 752685 Change-Id: I0ed538776957623e07a3a4a3aab08ee3ed5d46a3 Reviewed-on: https://chromium-review.googlesource.com/612723 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#494224} [modify] https://crrev.com/9985985766911f64a17053fff4575733568447ed/ui/app_list/views/search_result_tile_item_view.cc [modify] https://crrev.com/9985985766911f64a17053fff4575733568447ed/ui/app_list/views/search_result_view.cc
,
Aug 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9520038a27b395e7bb78e2789139fb16906c905e commit 9520038a27b395e7bb78e2789139fb16906c905e Author: Vadim Tryshev <vadimt@google.com> Date: Mon Aug 21 21:24:03 2017 Fix broken text in fullscreen app list Known issue: All text in SearchResultPageView is broken randomly when typing query in the search box. One work-around fix is setting a solid color background. But setting SearchResultView's background color will cause issue in crbug.com/752685 and overwrite the border corner radius of SearchResultPageView during animation. Changes: 1. Set all the text's background to be kCardBackgroundColorFullscreen to prevent broken text while not breaking the animation. 2. Adjust price and rating's bounds to avoid one's solid background blocking the other's. BUG= 746563 , 752685 TBR=weidongg@chromium.org (cherry picked from commit 9985985766911f64a17053fff4575733568447ed) Change-Id: I0ed538776957623e07a3a4a3aab08ee3ed5d46a3 Reviewed-on: https://chromium-review.googlesource.com/612723 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#494224} Reviewed-on: https://chromium-review.googlesource.com/624796 Reviewed-by: Vadim Tryshev <vadimt@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#718} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/9520038a27b395e7bb78e2789139fb16906c905e/ui/app_list/views/search_result_tile_item_view.cc [modify] https://crrev.com/9520038a27b395e7bb78e2789139fb16906c905e/ui/app_list/views/search_result_view.cc
,
Oct 11 2017
9765.76.1, 61.0.3163.113
,
Oct 25 2017
Issue 753728 has been merged into this issue. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by vadimt@chromium.org
, Aug 5 2017