chrome://certificate-manager shows raw $i18n{} strings |
|||||||||
Issue description
The certificate manager dialog is showing raw $i18n{} strings instead of localized text.
The WebUI is accessible via chrome://certificate-manager on Chrome OS.
Locally reverting https://chromium-review.googlesource.com/564137 fixes the issue.
I think this goes back to M61.
,
Aug 5 2017
,
Aug 5 2017
#1: The CL in my description updated options to $i18n{}. You were TBR'd on it but not actually set as a reviewer in gerrit.
,
Aug 5 2017
,
Aug 5 2017
,
Aug 5 2017
Confirmed this will need to be merged into M61 (3163). git merge-base --is-ancestor 5aee1f7187 branch-heads/3163 && echo yes
,
Aug 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8ab63a962410f003ad8e3bb25b85dcb9a61ec460 commit 8ab63a962410f003ad8e3bb25b85dcb9a61ec460 Author: Dave Schuyler <dschuyler@chromium.org> Date: Mon Aug 07 21:01:19 2017 [i18n] options certificate-manager ui This CL adds the template replacements for $i18n in the options (old) certificate-manager page. Bug: 752683 Change-Id: I8790acf9b8e0f1ace1f22ecc7f1147d628a8078e Reviewed-on: https://chromium-review.googlesource.com/603069 Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#492405} [modify] https://crrev.com/8ab63a962410f003ad8e3bb25b85dcb9a61ec460/chrome/browser/ui/webui/chromeos/certificate_manager_dialog_ui.cc
,
Aug 7 2017
,
Aug 7 2017
,
Aug 8 2017
Approving merge to M61 Chrome OS.
,
Aug 14 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 14 2017
I'll merge this now/today.
,
Aug 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1c47deec84387bf4306ac8eac1104dc98d5b0507 commit 1c47deec84387bf4306ac8eac1104dc98d5b0507 Author: Dave Schuyler <dschuyler@chromium.org> Date: Mon Aug 14 17:16:18 2017 [i18n] options certificate-manager ui This CL adds the template replacements for $i18n in the options (old) certificate-manager page. TBR=dschuyler@chromium.org (cherry picked from commit 8ab63a962410f003ad8e3bb25b85dcb9a61ec460) Bug: 752683 Change-Id: I8790acf9b8e0f1ace1f22ecc7f1147d628a8078e Reviewed-on: https://chromium-review.googlesource.com/603069 Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#492405} Reviewed-on: https://chromium-review.googlesource.com/613672 Reviewed-by: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#528} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/1c47deec84387bf4306ac8eac1104dc98d5b0507/chrome/browser/ui/webui/chromeos/certificate_manager_dialog_ui.cc
,
Jan 22 2018
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by steve...@chromium.org
, Aug 4 2017Yay, we can fix this just before it gets replaced! Isn't this still using the options UI code? I'm surprised it has $i18n{} strings. The CL that switches over to the MD Settings UI hasn't landed yet: https://chromium-review.googlesource.com/c/602880