New issue
Advanced search Search tips

Issue 752674 link

Starred by 3 users
Status: Fixed
Owner: ----
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

blink_web.dll is now vestigial, causing build breaks

Project Member Reported by brucedaw...@chromium.org, Aug 4 2017 
With crrev.com/c/601609 the blink_web.dll component has shrunk down to nothing - so much so that blink_web.dll.lib is no longer generated on Windows because there is nothing to export.

Unfortunately that file is listed as an input so ninja fails on component builds.

Widespread build breakage has been avoided because the blink_web.dll.lib file from previous builds is usually left around. However any new output directories, or clobbers, or "gn clean"s will lead to an unbuildable state.

We either need to revert the change or else delete the blink_web target. Reverting seems safest.

I don't know if this hits other platforms.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 5 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eeb168acde0805dc48f5dcc3959b63d92ae087dc

commit eeb168acde0805dc48f5dcc3959b63d92ae087dc
Author: Bruce Dawson <brucedawson@chromium.org>
Date: Sat Aug 05 00:59:14 2017

Revert "Rehome remaining STATIC_ASSERT_ENUMs"

This reverts commit afc8fa887c0a13cc1fdf6dba0e6730b4cd9c0267.

Reason for revert: Component builds will break if they don't
have an old blink_web.dll.lib lying around

Original change's description:
> Rehome remaining STATIC_ASSERT_ENUMs
> 
> Delete the last web/ cpp file.
> 
> Bug:  712963 
> Change-Id: I2a8f5d514285121fa5b3512718baddc9ccaf2e24
> Reviewed-on: https://chromium-review.googlesource.com/601609
> Commit-Queue: Nicholas Verne <nverne@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#491953}

TBR=haraken@chromium.org,nverne@chromium.org

Change-Id: I3c634f7cf5e791735b0511154ab79203576c7a64
No-Presubmit: true
Bug:  712963 , 752674 
Reviewed-on: https://chromium-review.googlesource.com/602947
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492203}
[modify] https://crrev.com/eeb168acde0805dc48f5dcc3959b63d92ae087dc/third_party/WebKit/Source/bindings/core/DEPS
[modify] https://crrev.com/eeb168acde0805dc48f5dcc3959b63d92ae087dc/third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp
[modify] https://crrev.com/eeb168acde0805dc48f5dcc3959b63d92ae087dc/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp
[modify] https://crrev.com/eeb168acde0805dc48f5dcc3959b63d92ae087dc/third_party/WebKit/Source/bindings/core/v8/serialization/SerializedScriptValue.cpp
[modify] https://crrev.com/eeb168acde0805dc48f5dcc3959b63d92ae087dc/third_party/WebKit/Source/core/dom/SandboxFlags.cpp
[modify] https://crrev.com/eeb168acde0805dc48f5dcc3959b63d92ae087dc/third_party/WebKit/Source/core/editing/SelectionController.cpp
[modify] https://crrev.com/eeb168acde0805dc48f5dcc3959b63d92ae087dc/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp
[modify] https://crrev.com/eeb168acde0805dc48f5dcc3959b63d92ae087dc/third_party/WebKit/Source/core/exported/WebSettingsImpl.cpp
[modify] https://crrev.com/eeb168acde0805dc48f5dcc3959b63d92ae087dc/third_party/WebKit/Source/core/frame/Frame.cpp
[modify] https://crrev.com/eeb168acde0805dc48f5dcc3959b63d92ae087dc/third_party/WebKit/Source/core/html/media/AutoplayPolicy.cpp
[modify] https://crrev.com/eeb168acde0805dc48f5dcc3959b63d92ae087dc/third_party/WebKit/Source/core/inspector/ConsoleMessage.cpp
[modify] https://crrev.com/eeb168acde0805dc48f5dcc3959b63d92ae087dc/third_party/WebKit/Source/core/loader/DocumentLoader.cpp
[modify] https://crrev.com/eeb168acde0805dc48f5dcc3959b63d92ae087dc/third_party/WebKit/Source/core/loader/FrameLoader.cpp
[modify] https://crrev.com/eeb168acde0805dc48f5dcc3959b63d92ae087dc/third_party/WebKit/Source/core/loader/ProgressTracker.cpp
[modify] https://crrev.com/eeb168acde0805dc48f5dcc3959b63d92ae087dc/third_party/WebKit/Source/core/style/ComputedStyle.cpp
[modify] https://crrev.com/eeb168acde0805dc48f5dcc3959b63d92ae087dc/third_party/WebKit/Source/modules/indexeddb/IDBDatabase.cpp
[modify] https://crrev.com/eeb168acde0805dc48f5dcc3959b63d92ae087dc/third_party/WebKit/Source/modules/indexeddb/IDBKey.cpp
[modify] https://crrev.com/eeb168acde0805dc48f5dcc3959b63d92ae087dc/third_party/WebKit/Source/modules/indexeddb/IDBKeyPath.cpp
[modify] https://crrev.com/eeb168acde0805dc48f5dcc3959b63d92ae087dc/third_party/WebKit/Source/modules/indexeddb/IDBMetadata.cpp
[modify] https://crrev.com/eeb168acde0805dc48f5dcc3959b63d92ae087dc/third_party/WebKit/Source/modules/navigatorcontentutils/NavigatorContentUtilsClient.cpp
[modify] https://crrev.com/eeb168acde0805dc48f5dcc3959b63d92ae087dc/third_party/WebKit/Source/platform/graphics/BitmapImage.cpp
[modify] https://crrev.com/eeb168acde0805dc48f5dcc3959b63d92ae087dc/third_party/WebKit/Source/platform/graphics/DEPS
[add] https://crrev.com/eeb168acde0805dc48f5dcc3959b63d92ae087dc/third_party/WebKit/Source/web/AssertMatchingEnums.cpp
[modify] https://crrev.com/eeb168acde0805dc48f5dcc3959b63d92ae087dc/third_party/WebKit/Source/web/BUILD.gn
[delete] https://crrev.com/e09ae9ae37364468dce317c84b9e7ca3f44cae50/third_party/WebKit/Source/web/Empty.cpp

Comment 2 by nverne@chromium.org, Oct 17 2017

Status: Fixed (was: Untriaged)
►

Sign in to add a comment