Issue 752672 link

Starred by 1 user

Issue metadata

Status:	WontFix
Owner:	----
Closed:	Dec 12
Cc:	editing-dev@chromium.org
Components:	Blink>Editing Blink>Layout
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	3
Type:	Task

Blocked on: View detail
issue 727929
issue 764489
issue 781434

Blocking:
issue 852470

TextIterator should be spec-compliant

Project Member Reported by xiaoche...@chromium.org, Aug 4 2017

Issue description

We need a clear spec of the behavior of TextIterator, namely, given an HTML document and the iteration range, what text should be emitted.

The spec might not be completely clear at the starting stage. Hence, we will start with collecting tricky cases.

Comment 1 by xiaoche...@chromium.org, Aug 4 2017

Should space/newline be emitted after/between positioned blocks? For example:

1. TextIterator emits "foobar" for the following HTML:

<div style="position: absolute; left: 40px; top: 40px;">foo</div>
<div style="position: absolute; left: 40px; top: 60px;">bar</div>

2. TextIterator emits "foo bar" for the following HTML:

<div style="position: absolute; left: 40px; top: 40px;">
foo
</div>
<div style="position: absolute; left: 40px; top: 60px;">
bar
</div>

The bottom line is, the same text should be emitted for the two HTML since they are rendered in completely the same way.

Besides, it seems more natural to emit a newline, instead of space, between the two divs.

Comment 2 by xiaoche...@chromium.org, Aug 4 2017

If there is text before <body>, should a space or newline emitted before <body>?

Example:

bar
<script>
document.documentElement.insertBefore(document.createTextNode('foo'), document.body);
</script>

TextIterator emits "foo bar". However, "foo\nbar" seems better.

Comment 3 by yosin@chromium.org, Aug 7 2017

Element#innerText has a spec[1][2]


[1] https://html.spec.whatwg.org/multipage/dom.html#the-innertext-idl-attribute
[2] https://github.com/rocallahan/innerText-spec See WHATWG version

Comment 4 by xiaoche...@chromium.org, Sep 7 2017

Summary: TextIterator should be spec-compliant (was: We need a spec of TextIterator)

TextIterator is a legacy introduced before we have any spec.


We should reimplement it following the spec, so that Element.innerText at least follows the spec.

The current TextIterator is more powerful than just emitting inner text. The reimplementation shouldn't discard any existing functionality. In general, we should ensure that a degeneralized version of TextIterator, when used to emit inner text, follows the spec.

Project Member

Comment 5 by bugdroid1@chromium.org, Sep 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ff781cd5c1aabca068247de9a3f143645e80422

commit 8ff781cd5c1aabca068247de9a3f143645e80422
Author: Xiaocheng Hu <xiaochengh@chromium.org>
Date: Mon Sep 11 20:44:15 2017

Stop TextIterator from checking margin when adding double newlines after P

TextIterator currently decides to add two consecutive newlines
after a P element only if it has a large margin, while the spec
of innerText doesn't have this margin check at all.
This patch removes the margin check to make TextIterator more
spec-complicant.

Bug:  752672 , 758816 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Ib283a41ef715a549a65abd33f189d6456a66241a
Reviewed-on: https://chromium-review.googlesource.com/653665
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501028}
[modify] https://crrev.com/8ff781cd5c1aabca068247de9a3f143645e80422/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
[modify] https://crrev.com/8ff781cd5c1aabca068247de9a3f143645e80422/third_party/WebKit/LayoutTests/editing/selection/offset-from-point-expected.txt
[modify] https://crrev.com/8ff781cd5c1aabca068247de9a3f143645e80422/third_party/WebKit/LayoutTests/fast/css-generated-content/hover-inline-expected.txt
[modify] https://crrev.com/8ff781cd5c1aabca068247de9a3f143645e80422/third_party/WebKit/LayoutTests/fast/dom/shadow/anchor-content-projected-expected.txt
[modify] https://crrev.com/8ff781cd5c1aabca068247de9a3f143645e80422/third_party/WebKit/LayoutTests/fast/events/dispatch-mouse-events-to-window-always-expected.txt
[modify] https://crrev.com/8ff781cd5c1aabca068247de9a3f143645e80422/third_party/WebKit/LayoutTests/fast/text/sub-pixel/text-scaling-ltr-expected.txt
[modify] https://crrev.com/8ff781cd5c1aabca068247de9a3f143645e80422/third_party/WebKit/LayoutTests/fast/text/sub-pixel/text-scaling-rtl-expected.txt
[modify] https://crrev.com/8ff781cd5c1aabca068247de9a3f143645e80422/third_party/WebKit/LayoutTests/fast/text/sub-pixel/text-scaling-vertical-expected.txt
[modify] https://crrev.com/8ff781cd5c1aabca068247de9a3f143645e80422/third_party/WebKit/LayoutTests/fast/text/sub-pixel/text-scaling-webfont-expected.txt
[modify] https://crrev.com/8ff781cd5c1aabca068247de9a3f143645e80422/third_party/WebKit/LayoutTests/html/sections/nav-element-expected.txt
[modify] https://crrev.com/8ff781cd5c1aabca068247de9a3f143645e80422/third_party/WebKit/LayoutTests/http/tests/canvas/philip/tests/security.drawImage.canvas-expected.txt
[modify] https://crrev.com/8ff781cd5c1aabca068247de9a3f143645e80422/third_party/WebKit/LayoutTests/http/tests/canvas/philip/tests/security.drawImage.image-expected.txt
[modify] https://crrev.com/8ff781cd5c1aabca068247de9a3f143645e80422/third_party/WebKit/LayoutTests/http/tests/canvas/philip/tests/security.pattern.canvas.fillStyle-expected.txt
[modify] https://crrev.com/8ff781cd5c1aabca068247de9a3f143645e80422/third_party/WebKit/LayoutTests/http/tests/canvas/philip/tests/security.pattern.canvas.strokeStyle-expected.txt
[modify] https://crrev.com/8ff781cd5c1aabca068247de9a3f143645e80422/third_party/WebKit/LayoutTests/http/tests/canvas/philip/tests/security.pattern.canvas.timing-expected.txt
[modify] https://crrev.com/8ff781cd5c1aabca068247de9a3f143645e80422/third_party/WebKit/LayoutTests/http/tests/canvas/philip/tests/security.pattern.create-expected.txt
[modify] https://crrev.com/8ff781cd5c1aabca068247de9a3f143645e80422/third_party/WebKit/LayoutTests/http/tests/canvas/philip/tests/security.pattern.cross-expected.txt
[modify] https://crrev.com/8ff781cd5c1aabca068247de9a3f143645e80422/third_party/WebKit/LayoutTests/http/tests/canvas/philip/tests/security.pattern.image.fillStyle-expected.txt
[modify] https://crrev.com/8ff781cd5c1aabca068247de9a3f143645e80422/third_party/WebKit/LayoutTests/http/tests/canvas/philip/tests/security.pattern.image.strokeStyle-expected.txt
[modify] https://crrev.com/8ff781cd5c1aabca068247de9a3f143645e80422/third_party/WebKit/LayoutTests/http/tests/canvas/philip/tests/security.reset-expected.txt
[modify] https://crrev.com/8ff781cd5c1aabca068247de9a3f143645e80422/third_party/WebKit/LayoutTests/platform/linux/fast/text/sub-pixel/text-scaling-ltr-expected.txt
[modify] https://crrev.com/8ff781cd5c1aabca068247de9a3f143645e80422/third_party/WebKit/LayoutTests/platform/linux/fast/text/sub-pixel/text-scaling-rtl-expected.txt
[modify] https://crrev.com/8ff781cd5c1aabca068247de9a3f143645e80422/third_party/WebKit/LayoutTests/platform/linux/fast/text/sub-pixel/text-scaling-vertical-expected.txt
[modify] https://crrev.com/8ff781cd5c1aabca068247de9a3f143645e80422/third_party/WebKit/LayoutTests/platform/linux/fast/text/sub-pixel/text-scaling-webfont-expected.txt
[modify] https://crrev.com/8ff781cd5c1aabca068247de9a3f143645e80422/third_party/WebKit/LayoutTests/platform/win/fast/text/sub-pixel/text-scaling-ltr-expected.txt
[modify] https://crrev.com/8ff781cd5c1aabca068247de9a3f143645e80422/third_party/WebKit/LayoutTests/platform/win/fast/text/sub-pixel/text-scaling-rtl-expected.txt
[modify] https://crrev.com/8ff781cd5c1aabca068247de9a3f143645e80422/third_party/WebKit/LayoutTests/platform/win/fast/text/sub-pixel/text-scaling-vertical-expected.txt
[modify] https://crrev.com/8ff781cd5c1aabca068247de9a3f143645e80422/third_party/WebKit/LayoutTests/scrollbars/scrollbar-large-overflow-rectangle-expected.txt
[modify] https://crrev.com/8ff781cd5c1aabca068247de9a3f143645e80422/third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp

Project Member

Comment 6 by bugdroid1@chromium.org, Sep 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5605a3d70df5978a0609bd5b4dfedb8421aaffa7

commit 5605a3d70df5978a0609bd5b4dfedb8421aaffa7
Author: Xiaocheng Hu <xiaochengh@chromium.org>
Date: Tue Sep 12 16:19:02 2017

Stop TextIterator from emit double newlines after H4~6 elements

TextIterator currently may add two consecutive newlines after an
H4, H5 or H6 element, while the spec of innerText doesn't have
this case at all.

This patch removes the extra newline to make TextIterator more
spec-complicant.

Note: TextIterator should eventually remove double newline emission
also for H1~3. This patch removes it only for H4~6 to keep the
amount of rebaselined tests small.

Bug:  752672 , 758816 
Change-Id: I32583c194a829f52411555125e77590e36ccf838
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Reviewed-on: https://chromium-review.googlesource.com/661937
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501297}
[modify] https://crrev.com/5605a3d70df5978a0609bd5b4dfedb8421aaffa7/third_party/WebKit/LayoutTests/accessibility/canvas-fallback-content-2-expected.txt
[modify] https://crrev.com/5605a3d70df5978a0609bd5b4dfedb8421aaffa7/third_party/WebKit/LayoutTests/accessibility/readonly-expected.txt
[modify] https://crrev.com/5605a3d70df5978a0609bd5b4dfedb8421aaffa7/third_party/WebKit/LayoutTests/editing/execCommand/19087-expected.txt
[modify] https://crrev.com/5605a3d70df5978a0609bd5b4dfedb8421aaffa7/third_party/WebKit/LayoutTests/editing/execCommand/arguments-combinations-expected.txt
[modify] https://crrev.com/5605a3d70df5978a0609bd5b4dfedb8421aaffa7/third_party/WebKit/LayoutTests/fast/css/text-align-webkit-match-parent-expected.txt
[modify] https://crrev.com/5605a3d70df5978a0609bd5b4dfedb8421aaffa7/third_party/WebKit/LayoutTests/fast/dom/inner-text-001-expected.txt
[modify] https://crrev.com/5605a3d70df5978a0609bd5b4dfedb8421aaffa7/third_party/WebKit/LayoutTests/fast/events/drag-in-frames-expected.txt
[modify] https://crrev.com/5605a3d70df5978a0609bd5b4dfedb8421aaffa7/third_party/WebKit/LayoutTests/fast/invalid/nestedh3s-rapidweaver-expected.txt
[modify] https://crrev.com/5605a3d70df5978a0609bd5b4dfedb8421aaffa7/third_party/WebKit/LayoutTests/fast/table/rowspan-only-rows-height-distribution-expected.txt
[modify] https://crrev.com/5605a3d70df5978a0609bd5b4dfedb8421aaffa7/third_party/WebKit/LayoutTests/fast/table/table-all-rowspans-height-distribution-in-rows-expected.txt
[modify] https://crrev.com/5605a3d70df5978a0609bd5b4dfedb8421aaffa7/third_party/WebKit/LayoutTests/fast/table/table-colgroup-present-after-table-row-expected.txt
[modify] https://crrev.com/5605a3d70df5978a0609bd5b4dfedb8421aaffa7/third_party/WebKit/LayoutTests/fast/table/table-rowspan-cell-with-empty-cell-expected.txt
[modify] https://crrev.com/5605a3d70df5978a0609bd5b4dfedb8421aaffa7/third_party/WebKit/LayoutTests/fast/table/table-rowspan-crash-with-huge-pedding-value-expected.txt
[modify] https://crrev.com/5605a3d70df5978a0609bd5b4dfedb8421aaffa7/third_party/WebKit/LayoutTests/fast/table/table-rowspan-crash-with-huge-rowspan-cells-2-expected.txt
[modify] https://crrev.com/5605a3d70df5978a0609bd5b4dfedb8421aaffa7/third_party/WebKit/LayoutTests/fast/table/table-rowspan-crash-with-huge-rowspan-cells-expected.txt
[modify] https://crrev.com/5605a3d70df5978a0609bd5b4dfedb8421aaffa7/third_party/WebKit/LayoutTests/fast/table/table-rowspan-height-distribution-in-rows-1-expected.txt
[modify] https://crrev.com/5605a3d70df5978a0609bd5b4dfedb8421aaffa7/third_party/WebKit/LayoutTests/fast/table/table-rowspan-height-distribution-in-rows-2-expected.txt
[modify] https://crrev.com/5605a3d70df5978a0609bd5b4dfedb8421aaffa7/third_party/WebKit/LayoutTests/fast/table/table-rowspan-table-height-and-row-precent-height-too-large-expected.txt
[modify] https://crrev.com/5605a3d70df5978a0609bd5b4dfedb8421aaffa7/third_party/WebKit/LayoutTests/fast/table/table-sections-border-spacing-expected.txt
[modify] https://crrev.com/5605a3d70df5978a0609bd5b4dfedb8421aaffa7/third_party/WebKit/LayoutTests/fast/table/table-toggle-paragraph-padding-expected.txt
[modify] https://crrev.com/5605a3d70df5978a0609bd5b4dfedb8421aaffa7/third_party/WebKit/LayoutTests/fast/tokenizer/004-expected.txt
[modify] https://crrev.com/5605a3d70df5978a0609bd5b4dfedb8421aaffa7/third_party/WebKit/LayoutTests/fast/xpath/xpath-functional-test-expected.txt
[modify] https://crrev.com/5605a3d70df5978a0609bd5b4dfedb8421aaffa7/third_party/WebKit/LayoutTests/html/sections/nav-element-expected.txt
[modify] https://crrev.com/5605a3d70df5978a0609bd5b4dfedb8421aaffa7/third_party/WebKit/LayoutTests/html/tabular_data/table_insertrow-expected.txt
[modify] https://crrev.com/5605a3d70df5978a0609bd5b4dfedb8421aaffa7/third_party/WebKit/LayoutTests/http/tests/loading/redirect-methods-expected.txt
[modify] https://crrev.com/5605a3d70df5978a0609bd5b4dfedb8421aaffa7/third_party/WebKit/LayoutTests/http/tests/security/frameNavigation/sandbox-ALLOWED-top-navigation-with-two-flags-expected.txt
[modify] https://crrev.com/5605a3d70df5978a0609bd5b4dfedb8421aaffa7/third_party/WebKit/LayoutTests/http/tests/security/frameNavigation/sandbox-ALLOWED-top-navigation-with-user-gesture-expected.txt
[modify] https://crrev.com/5605a3d70df5978a0609bd5b4dfedb8421aaffa7/third_party/WebKit/LayoutTests/http/tests/security/frameNavigation/xss-ALLOWED-parent-navigation-change-async-expected.txt
[modify] https://crrev.com/5605a3d70df5978a0609bd5b4dfedb8421aaffa7/third_party/WebKit/LayoutTests/http/tests/security/frameNavigation/xss-ALLOWED-parent-navigation-change-expected.txt
[modify] https://crrev.com/5605a3d70df5978a0609bd5b4dfedb8421aaffa7/third_party/WebKit/LayoutTests/http/tests/security/frameNavigation/xss-ALLOWED-targeted-subframe-navigation-change-expected.txt
[modify] https://crrev.com/5605a3d70df5978a0609bd5b4dfedb8421aaffa7/third_party/WebKit/LayoutTests/http/tests/security/frameNavigation/xss-DENIED-targeted-link-navigation-expected.txt
[modify] https://crrev.com/5605a3d70df5978a0609bd5b4dfedb8421aaffa7/third_party/WebKit/LayoutTests/http/tests/security/frameNavigation/xss-DENIED-top-navigation-user-gesture-in-parent-expected.txt
[modify] https://crrev.com/5605a3d70df5978a0609bd5b4dfedb8421aaffa7/third_party/WebKit/LayoutTests/http/tests/security/frameNavigation/xss-DENIED-top-navigation-without-user-gesture-expected.txt
[modify] https://crrev.com/5605a3d70df5978a0609bd5b4dfedb8421aaffa7/third_party/WebKit/LayoutTests/http/tests/security/vibration/vibrate-in-cross-origin-iframe-with-user-gesture-allowed-expected.txt
[modify] https://crrev.com/5605a3d70df5978a0609bd5b4dfedb8421aaffa7/third_party/WebKit/LayoutTests/http/tests/security/vibration/vibrate-in-same-origin-iframe-with-user-gesture-allowed-expected.txt
[modify] https://crrev.com/5605a3d70df5978a0609bd5b4dfedb8421aaffa7/third_party/WebKit/LayoutTests/platform/mac/fast/table/table-all-rowspans-height-distribution-in-rows-except-overlapped-expected.txt
[modify] https://crrev.com/5605a3d70df5978a0609bd5b4dfedb8421aaffa7/third_party/WebKit/LayoutTests/platform/mac/fast/table/table-all-rowspans-height-distribution-in-rows-expected.txt
[modify] https://crrev.com/5605a3d70df5978a0609bd5b4dfedb8421aaffa7/third_party/WebKit/LayoutTests/platform/mac/fast/table/table-rowspan-height-distribution-in-rows-1-expected.txt
[modify] https://crrev.com/5605a3d70df5978a0609bd5b4dfedb8421aaffa7/third_party/WebKit/LayoutTests/platform/mac/fast/table/table-rowspan-height-distribution-in-rows-2-expected.txt
[modify] https://crrev.com/5605a3d70df5978a0609bd5b4dfedb8421aaffa7/third_party/WebKit/LayoutTests/platform/win/fast/table/table-all-rowspans-height-distribution-in-rows-except-overlapped-expected.txt
[modify] https://crrev.com/5605a3d70df5978a0609bd5b4dfedb8421aaffa7/third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp

Project Member

Comment 7 by bugdroid1@chromium.org, Sep 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ede7a12eb0ab2dfe967d073edb4010f76cc23d1a

commit ede7a12eb0ab2dfe967d073edb4010f76cc23d1a
Author: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Date: Tue Sep 12 19:30:56 2017

Revert "Stop TextIterator from emit double newlines after H4~6 elements"

This reverts commit 5605a3d70df5978a0609bd5b4dfedb8421aaffa7.

Reason for revert: Causing failures on all platform webkit layout test external/wpt/innerText/getter.html.

see bug:  crbug.com/764417 

Original change's description:
> Stop TextIterator from emit double newlines after H4~6 elements
> 
> TextIterator currently may add two consecutive newlines after an
> H4, H5 or H6 element, while the spec of innerText doesn't have
> this case at all.
> 
> This patch removes the extra newline to make TextIterator more
> spec-complicant.
> 
> Note: TextIterator should eventually remove double newline emission
> also for H1~3. This patch removes it only for H4~6 to keep the
> amount of rebaselined tests small.
> 
> Bug:  752672 , 758816 
> Change-Id: I32583c194a829f52411555125e77590e36ccf838
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
> Reviewed-on: https://chromium-review.googlesource.com/661937
> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
> Reviewed-by: Koji Ishii <kojii@chromium.org>
> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#501297}

TBR=yosin@chromium.org,kojii@chromium.org,xiaochengh@chromium.org,simonp@opera.com

Change-Id: I16487602d07a29ac95d79867ae0522dbfbe130d5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  752672 ,  758816 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Reviewed-on: https://chromium-review.googlesource.com/663941
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501359}
[modify] https://crrev.com/ede7a12eb0ab2dfe967d073edb4010f76cc23d1a/third_party/WebKit/LayoutTests/accessibility/canvas-fallback-content-2-expected.txt
[modify] https://crrev.com/ede7a12eb0ab2dfe967d073edb4010f76cc23d1a/third_party/WebKit/LayoutTests/accessibility/readonly-expected.txt
[modify] https://crrev.com/ede7a12eb0ab2dfe967d073edb4010f76cc23d1a/third_party/WebKit/LayoutTests/editing/execCommand/19087-expected.txt
[modify] https://crrev.com/ede7a12eb0ab2dfe967d073edb4010f76cc23d1a/third_party/WebKit/LayoutTests/editing/execCommand/arguments-combinations-expected.txt
[modify] https://crrev.com/ede7a12eb0ab2dfe967d073edb4010f76cc23d1a/third_party/WebKit/LayoutTests/fast/css/text-align-webkit-match-parent-expected.txt
[modify] https://crrev.com/ede7a12eb0ab2dfe967d073edb4010f76cc23d1a/third_party/WebKit/LayoutTests/fast/dom/inner-text-001-expected.txt
[modify] https://crrev.com/ede7a12eb0ab2dfe967d073edb4010f76cc23d1a/third_party/WebKit/LayoutTests/fast/events/drag-in-frames-expected.txt
[modify] https://crrev.com/ede7a12eb0ab2dfe967d073edb4010f76cc23d1a/third_party/WebKit/LayoutTests/fast/invalid/nestedh3s-rapidweaver-expected.txt
[modify] https://crrev.com/ede7a12eb0ab2dfe967d073edb4010f76cc23d1a/third_party/WebKit/LayoutTests/fast/table/rowspan-only-rows-height-distribution-expected.txt
[modify] https://crrev.com/ede7a12eb0ab2dfe967d073edb4010f76cc23d1a/third_party/WebKit/LayoutTests/fast/table/table-all-rowspans-height-distribution-in-rows-expected.txt
[modify] https://crrev.com/ede7a12eb0ab2dfe967d073edb4010f76cc23d1a/third_party/WebKit/LayoutTests/fast/table/table-colgroup-present-after-table-row-expected.txt
[modify] https://crrev.com/ede7a12eb0ab2dfe967d073edb4010f76cc23d1a/third_party/WebKit/LayoutTests/fast/table/table-rowspan-cell-with-empty-cell-expected.txt
[modify] https://crrev.com/ede7a12eb0ab2dfe967d073edb4010f76cc23d1a/third_party/WebKit/LayoutTests/fast/table/table-rowspan-crash-with-huge-pedding-value-expected.txt
[modify] https://crrev.com/ede7a12eb0ab2dfe967d073edb4010f76cc23d1a/third_party/WebKit/LayoutTests/fast/table/table-rowspan-crash-with-huge-rowspan-cells-2-expected.txt
[modify] https://crrev.com/ede7a12eb0ab2dfe967d073edb4010f76cc23d1a/third_party/WebKit/LayoutTests/fast/table/table-rowspan-crash-with-huge-rowspan-cells-expected.txt
[modify] https://crrev.com/ede7a12eb0ab2dfe967d073edb4010f76cc23d1a/third_party/WebKit/LayoutTests/fast/table/table-rowspan-height-distribution-in-rows-1-expected.txt
[modify] https://crrev.com/ede7a12eb0ab2dfe967d073edb4010f76cc23d1a/third_party/WebKit/LayoutTests/fast/table/table-rowspan-height-distribution-in-rows-2-expected.txt
[modify] https://crrev.com/ede7a12eb0ab2dfe967d073edb4010f76cc23d1a/third_party/WebKit/LayoutTests/fast/table/table-rowspan-table-height-and-row-precent-height-too-large-expected.txt
[modify] https://crrev.com/ede7a12eb0ab2dfe967d073edb4010f76cc23d1a/third_party/WebKit/LayoutTests/fast/table/table-sections-border-spacing-expected.txt
[modify] https://crrev.com/ede7a12eb0ab2dfe967d073edb4010f76cc23d1a/third_party/WebKit/LayoutTests/fast/table/table-toggle-paragraph-padding-expected.txt
[modify] https://crrev.com/ede7a12eb0ab2dfe967d073edb4010f76cc23d1a/third_party/WebKit/LayoutTests/fast/tokenizer/004-expected.txt
[modify] https://crrev.com/ede7a12eb0ab2dfe967d073edb4010f76cc23d1a/third_party/WebKit/LayoutTests/fast/xpath/xpath-functional-test-expected.txt
[modify] https://crrev.com/ede7a12eb0ab2dfe967d073edb4010f76cc23d1a/third_party/WebKit/LayoutTests/html/sections/nav-element-expected.txt
[modify] https://crrev.com/ede7a12eb0ab2dfe967d073edb4010f76cc23d1a/third_party/WebKit/LayoutTests/html/tabular_data/table_insertrow-expected.txt
[modify] https://crrev.com/ede7a12eb0ab2dfe967d073edb4010f76cc23d1a/third_party/WebKit/LayoutTests/http/tests/loading/redirect-methods-expected.txt
[modify] https://crrev.com/ede7a12eb0ab2dfe967d073edb4010f76cc23d1a/third_party/WebKit/LayoutTests/http/tests/security/frameNavigation/sandbox-ALLOWED-top-navigation-with-two-flags-expected.txt
[modify] https://crrev.com/ede7a12eb0ab2dfe967d073edb4010f76cc23d1a/third_party/WebKit/LayoutTests/http/tests/security/frameNavigation/sandbox-ALLOWED-top-navigation-with-user-gesture-expected.txt
[modify] https://crrev.com/ede7a12eb0ab2dfe967d073edb4010f76cc23d1a/third_party/WebKit/LayoutTests/http/tests/security/frameNavigation/xss-ALLOWED-parent-navigation-change-async-expected.txt
[modify] https://crrev.com/ede7a12eb0ab2dfe967d073edb4010f76cc23d1a/third_party/WebKit/LayoutTests/http/tests/security/frameNavigation/xss-ALLOWED-parent-navigation-change-expected.txt
[modify] https://crrev.com/ede7a12eb0ab2dfe967d073edb4010f76cc23d1a/third_party/WebKit/LayoutTests/http/tests/security/frameNavigation/xss-ALLOWED-targeted-subframe-navigation-change-expected.txt
[modify] https://crrev.com/ede7a12eb0ab2dfe967d073edb4010f76cc23d1a/third_party/WebKit/LayoutTests/http/tests/security/frameNavigation/xss-DENIED-targeted-link-navigation-expected.txt
[modify] https://crrev.com/ede7a12eb0ab2dfe967d073edb4010f76cc23d1a/third_party/WebKit/LayoutTests/http/tests/security/frameNavigation/xss-DENIED-top-navigation-user-gesture-in-parent-expected.txt
[modify] https://crrev.com/ede7a12eb0ab2dfe967d073edb4010f76cc23d1a/third_party/WebKit/LayoutTests/http/tests/security/frameNavigation/xss-DENIED-top-navigation-without-user-gesture-expected.txt
[modify] https://crrev.com/ede7a12eb0ab2dfe967d073edb4010f76cc23d1a/third_party/WebKit/LayoutTests/http/tests/security/vibration/vibrate-in-cross-origin-iframe-with-user-gesture-allowed-expected.txt
[modify] https://crrev.com/ede7a12eb0ab2dfe967d073edb4010f76cc23d1a/third_party/WebKit/LayoutTests/http/tests/security/vibration/vibrate-in-same-origin-iframe-with-user-gesture-allowed-expected.txt
[modify] https://crrev.com/ede7a12eb0ab2dfe967d073edb4010f76cc23d1a/third_party/WebKit/LayoutTests/platform/mac/fast/table/table-all-rowspans-height-distribution-in-rows-except-overlapped-expected.txt
[modify] https://crrev.com/ede7a12eb0ab2dfe967d073edb4010f76cc23d1a/third_party/WebKit/LayoutTests/platform/mac/fast/table/table-all-rowspans-height-distribution-in-rows-expected.txt
[modify] https://crrev.com/ede7a12eb0ab2dfe967d073edb4010f76cc23d1a/third_party/WebKit/LayoutTests/platform/mac/fast/table/table-rowspan-height-distribution-in-rows-1-expected.txt
[modify] https://crrev.com/ede7a12eb0ab2dfe967d073edb4010f76cc23d1a/third_party/WebKit/LayoutTests/platform/mac/fast/table/table-rowspan-height-distribution-in-rows-2-expected.txt
[modify] https://crrev.com/ede7a12eb0ab2dfe967d073edb4010f76cc23d1a/third_party/WebKit/LayoutTests/platform/win/fast/table/table-all-rowspans-height-distribution-in-rows-except-overlapped-expected.txt
[modify] https://crrev.com/ede7a12eb0ab2dfe967d073edb4010f76cc23d1a/third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp

Comment 8 by xiaoche...@chromium.org, Sep 12 2017

Blockedon: 764489

Project Member

Comment 9 by bugdroid1@chromium.org, Sep 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2925e1d42d5bc7a91c98a7239424104a43672c02

commit 2925e1d42d5bc7a91c98a7239424104a43672c02
Author: Xiaocheng Hu <xiaochengh@chromium.org>
Date: Wed Sep 13 07:34:45 2017

Reland "Stop TextIterator from emit double newlines after H4~6 elements"

The original patch caused buildbot failures because it didn't rebaseline
the newly added wpt innerText getter tests. This is fixed in this one.

Original change's description:
> Stop TextIterator from emit double newlines after H4~6 elements
>
> TextIterator currently may add two consecutive newlines after an
> H4, H5 or H6 element, while the spec of innerText doesn't have
> this case at all.
>
> This patch removes the extra newline to make TextIterator more
> spec-complicant.
>
> Note: TextIterator should eventually remove double newline emission
> also for H1~3. This patch removes it only for H4~6 to keep the
> amount of rebaselined tests small.
>
> Bug:  752672 , 758816 
> Change-Id: I32583c194a829f52411555125e77590e36ccf838
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
> Reviewed-on: https://chromium-review.googlesource.com/661937
> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
> Reviewed-by: Koji Ishii <kojii@chromium.org>
> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#501297}

TBR=yosin@chromium.org,kojii@chromium.org,xiaochengh@chromium.org,simonp@opera.com

Bug:  752672 , 758816 
Change-Id: I9f6414635d257a309eca0f7f28882c7ebdc90e94
Reviewed-on: https://chromium-review.googlesource.com/664122
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501563}
[modify] https://crrev.com/2925e1d42d5bc7a91c98a7239424104a43672c02/third_party/WebKit/LayoutTests/accessibility/canvas-fallback-content-2-expected.txt
[modify] https://crrev.com/2925e1d42d5bc7a91c98a7239424104a43672c02/third_party/WebKit/LayoutTests/accessibility/readonly-expected.txt
[modify] https://crrev.com/2925e1d42d5bc7a91c98a7239424104a43672c02/third_party/WebKit/LayoutTests/editing/execCommand/19087-expected.txt
[modify] https://crrev.com/2925e1d42d5bc7a91c98a7239424104a43672c02/third_party/WebKit/LayoutTests/editing/execCommand/arguments-combinations-expected.txt
[modify] https://crrev.com/2925e1d42d5bc7a91c98a7239424104a43672c02/third_party/WebKit/LayoutTests/external/wpt/innerText/getter-expected.txt
[modify] https://crrev.com/2925e1d42d5bc7a91c98a7239424104a43672c02/third_party/WebKit/LayoutTests/fast/css/text-align-webkit-match-parent-expected.txt
[modify] https://crrev.com/2925e1d42d5bc7a91c98a7239424104a43672c02/third_party/WebKit/LayoutTests/fast/dom/inner-text-001-expected.txt
[modify] https://crrev.com/2925e1d42d5bc7a91c98a7239424104a43672c02/third_party/WebKit/LayoutTests/fast/events/drag-in-frames-expected.txt
[modify] https://crrev.com/2925e1d42d5bc7a91c98a7239424104a43672c02/third_party/WebKit/LayoutTests/fast/invalid/nestedh3s-rapidweaver-expected.txt
[modify] https://crrev.com/2925e1d42d5bc7a91c98a7239424104a43672c02/third_party/WebKit/LayoutTests/fast/table/rowspan-only-rows-height-distribution-expected.txt
[modify] https://crrev.com/2925e1d42d5bc7a91c98a7239424104a43672c02/third_party/WebKit/LayoutTests/fast/table/table-all-rowspans-height-distribution-in-rows-expected.txt
[modify] https://crrev.com/2925e1d42d5bc7a91c98a7239424104a43672c02/third_party/WebKit/LayoutTests/fast/table/table-colgroup-present-after-table-row-expected.txt
[modify] https://crrev.com/2925e1d42d5bc7a91c98a7239424104a43672c02/third_party/WebKit/LayoutTests/fast/table/table-rowspan-cell-with-empty-cell-expected.txt
[modify] https://crrev.com/2925e1d42d5bc7a91c98a7239424104a43672c02/third_party/WebKit/LayoutTests/fast/table/table-rowspan-crash-with-huge-pedding-value-expected.txt
[modify] https://crrev.com/2925e1d42d5bc7a91c98a7239424104a43672c02/third_party/WebKit/LayoutTests/fast/table/table-rowspan-crash-with-huge-rowspan-cells-2-expected.txt
[modify] https://crrev.com/2925e1d42d5bc7a91c98a7239424104a43672c02/third_party/WebKit/LayoutTests/fast/table/table-rowspan-crash-with-huge-rowspan-cells-expected.txt
[modify] https://crrev.com/2925e1d42d5bc7a91c98a7239424104a43672c02/third_party/WebKit/LayoutTests/fast/table/table-rowspan-height-distribution-in-rows-1-expected.txt
[modify] https://crrev.com/2925e1d42d5bc7a91c98a7239424104a43672c02/third_party/WebKit/LayoutTests/fast/table/table-rowspan-height-distribution-in-rows-2-expected.txt
[modify] https://crrev.com/2925e1d42d5bc7a91c98a7239424104a43672c02/third_party/WebKit/LayoutTests/fast/table/table-rowspan-table-height-and-row-precent-height-too-large-expected.txt
[modify] https://crrev.com/2925e1d42d5bc7a91c98a7239424104a43672c02/third_party/WebKit/LayoutTests/fast/table/table-sections-border-spacing-expected.txt
[modify] https://crrev.com/2925e1d42d5bc7a91c98a7239424104a43672c02/third_party/WebKit/LayoutTests/fast/table/table-toggle-paragraph-padding-expected.txt
[modify] https://crrev.com/2925e1d42d5bc7a91c98a7239424104a43672c02/third_party/WebKit/LayoutTests/fast/tokenizer/004-expected.txt
[modify] https://crrev.com/2925e1d42d5bc7a91c98a7239424104a43672c02/third_party/WebKit/LayoutTests/fast/xpath/xpath-functional-test-expected.txt
[modify] https://crrev.com/2925e1d42d5bc7a91c98a7239424104a43672c02/third_party/WebKit/LayoutTests/html/sections/nav-element-expected.txt
[modify] https://crrev.com/2925e1d42d5bc7a91c98a7239424104a43672c02/third_party/WebKit/LayoutTests/html/tabular_data/table_insertrow-expected.txt
[modify] https://crrev.com/2925e1d42d5bc7a91c98a7239424104a43672c02/third_party/WebKit/LayoutTests/http/tests/loading/redirect-methods-expected.txt
[modify] https://crrev.com/2925e1d42d5bc7a91c98a7239424104a43672c02/third_party/WebKit/LayoutTests/http/tests/security/frameNavigation/sandbox-ALLOWED-top-navigation-with-two-flags-expected.txt
[modify] https://crrev.com/2925e1d42d5bc7a91c98a7239424104a43672c02/third_party/WebKit/LayoutTests/http/tests/security/frameNavigation/sandbox-ALLOWED-top-navigation-with-user-gesture-expected.txt
[modify] https://crrev.com/2925e1d42d5bc7a91c98a7239424104a43672c02/third_party/WebKit/LayoutTests/http/tests/security/frameNavigation/xss-ALLOWED-parent-navigation-change-async-expected.txt
[modify] https://crrev.com/2925e1d42d5bc7a91c98a7239424104a43672c02/third_party/WebKit/LayoutTests/http/tests/security/frameNavigation/xss-ALLOWED-parent-navigation-change-expected.txt
[modify] https://crrev.com/2925e1d42d5bc7a91c98a7239424104a43672c02/third_party/WebKit/LayoutTests/http/tests/security/frameNavigation/xss-ALLOWED-targeted-subframe-navigation-change-expected.txt
[modify] https://crrev.com/2925e1d42d5bc7a91c98a7239424104a43672c02/third_party/WebKit/LayoutTests/http/tests/security/frameNavigation/xss-DENIED-targeted-link-navigation-expected.txt
[modify] https://crrev.com/2925e1d42d5bc7a91c98a7239424104a43672c02/third_party/WebKit/LayoutTests/http/tests/security/frameNavigation/xss-DENIED-top-navigation-user-gesture-in-parent-expected.txt
[modify] https://crrev.com/2925e1d42d5bc7a91c98a7239424104a43672c02/third_party/WebKit/LayoutTests/http/tests/security/frameNavigation/xss-DENIED-top-navigation-without-user-gesture-expected.txt
[modify] https://crrev.com/2925e1d42d5bc7a91c98a7239424104a43672c02/third_party/WebKit/LayoutTests/http/tests/security/vibration/vibrate-in-cross-origin-iframe-with-user-gesture-allowed-expected.txt
[modify] https://crrev.com/2925e1d42d5bc7a91c98a7239424104a43672c02/third_party/WebKit/LayoutTests/http/tests/security/vibration/vibrate-in-same-origin-iframe-with-user-gesture-allowed-expected.txt
[modify] https://crrev.com/2925e1d42d5bc7a91c98a7239424104a43672c02/third_party/WebKit/LayoutTests/platform/mac/fast/table/table-all-rowspans-height-distribution-in-rows-except-overlapped-expected.txt
[modify] https://crrev.com/2925e1d42d5bc7a91c98a7239424104a43672c02/third_party/WebKit/LayoutTests/platform/mac/fast/table/table-all-rowspans-height-distribution-in-rows-expected.txt
[modify] https://crrev.com/2925e1d42d5bc7a91c98a7239424104a43672c02/third_party/WebKit/LayoutTests/platform/mac/fast/table/table-rowspan-height-distribution-in-rows-1-expected.txt
[modify] https://crrev.com/2925e1d42d5bc7a91c98a7239424104a43672c02/third_party/WebKit/LayoutTests/platform/mac/fast/table/table-rowspan-height-distribution-in-rows-2-expected.txt
[modify] https://crrev.com/2925e1d42d5bc7a91c98a7239424104a43672c02/third_party/WebKit/LayoutTests/platform/win/fast/table/table-all-rowspans-height-distribution-in-rows-except-overlapped-expected.txt
[modify] https://crrev.com/2925e1d42d5bc7a91c98a7239424104a43672c02/third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp

Project Member

Comment 10 by bugdroid1@chromium.org, Sep 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e009d46d55d1e57cac5cd2825ea25cc02d9f094

commit 9e009d46d55d1e57cac5cd2825ea25cc02d9f094
Author: Xiaocheng Hu <xiaochengh@chromium.org>
Date: Wed Sep 13 21:10:43 2017

Stop TextIterator from emitting double newlines after H3

TextIterator currently may add two consecutive newlines after an
H3 element, while the spec of innerText doesn't have this case at all.

This patch removes the extra newline to make TextIterator more
spec-complicant.

This patch also discovers a bad pattern in editing commands, which
assume same plain text length before and after formatting text.
See crbug.com/764489

Note: TextIterator should eventually remove double newline emission
also for H1 and H2. This patch removes it only for H3 to keep the
amount of rebaselined tests small.

Bug:  752672 , 758816 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I83ca35338201505364f6d4c741c6148e5171d8fe
Reviewed-on: https://chromium-review.googlesource.com/663826
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501748}
[modify] https://crrev.com/9e009d46d55d1e57cac5cd2825ea25cc02d9f094/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/9e009d46d55d1e57cac5cd2825ea25cc02d9f094/third_party/WebKit/LayoutTests/accessibility/aria-controls-with-tabs-expected.txt
[modify] https://crrev.com/9e009d46d55d1e57cac5cd2825ea25cc02d9f094/third_party/WebKit/LayoutTests/accessibility/aria-none-role-expected.txt
[modify] https://crrev.com/9e009d46d55d1e57cac5cd2825ea25cc02d9f094/third_party/WebKit/LayoutTests/accessibility/aria-presentational-role-expected.txt
[modify] https://crrev.com/9e009d46d55d1e57cac5cd2825ea25cc02d9f094/third_party/WebKit/LayoutTests/accessibility/aria-tab-roles-expected.txt
[modify] https://crrev.com/9e009d46d55d1e57cac5cd2825ea25cc02d9f094/third_party/WebKit/LayoutTests/accessibility/contenteditable-hidden-div-expected.txt
[modify] https://crrev.com/9e009d46d55d1e57cac5cd2825ea25cc02d9f094/third_party/WebKit/LayoutTests/editing/selection/drag-start-event-client-x-y-expected.txt
[modify] https://crrev.com/9e009d46d55d1e57cac5cd2825ea25cc02d9f094/third_party/WebKit/LayoutTests/external/wpt/innerText/getter-expected.txt
[modify] https://crrev.com/9e009d46d55d1e57cac5cd2825ea25cc02d9f094/third_party/WebKit/LayoutTests/fast/block/min-max-height-percent-height-child-expected.txt
[modify] https://crrev.com/9e009d46d55d1e57cac5cd2825ea25cc02d9f094/third_party/WebKit/LayoutTests/fast/block/positioning/offsetLeft-relative-iframe-expected.txt
[modify] https://crrev.com/9e009d46d55d1e57cac5cd2825ea25cc02d9f094/third_party/WebKit/LayoutTests/fast/block/positioning/offsetLeft-relative-td-expected.txt
[modify] https://crrev.com/9e009d46d55d1e57cac5cd2825ea25cc02d9f094/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/getComputedStyle-text-overflow-expected.txt
[modify] https://crrev.com/9e009d46d55d1e57cac5cd2825ea25cc02d9f094/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/getComputedStyle-with-pseudo-element-expected.txt
[modify] https://crrev.com/9e009d46d55d1e57cac5cd2825ea25cc02d9f094/third_party/WebKit/LayoutTests/fast/css/list-item-text-align-expected.txt
[modify] https://crrev.com/9e009d46d55d1e57cac5cd2825ea25cc02d9f094/third_party/WebKit/LayoutTests/fast/css/text-align-webkit-match-parent-expected.txt
[modify] https://crrev.com/9e009d46d55d1e57cac5cd2825ea25cc02d9f094/third_party/WebKit/LayoutTests/fast/dom/Range/surround-contents-font-face-crash-expected.txt
[modify] https://crrev.com/9e009d46d55d1e57cac5cd2825ea25cc02d9f094/third_party/WebKit/LayoutTests/fast/dom/adopt-attribute-crash-expected.txt
[modify] https://crrev.com/9e009d46d55d1e57cac5cd2825ea25cc02d9f094/third_party/WebKit/LayoutTests/fast/dom/inner-text-001-expected.txt
[modify] https://crrev.com/9e009d46d55d1e57cac5cd2825ea25cc02d9f094/third_party/WebKit/LayoutTests/fast/dom/xml-parser-error-message-crash-expected.txt
[modify] https://crrev.com/9e009d46d55d1e57cac5cd2825ea25cc02d9f094/third_party/WebKit/LayoutTests/fast/events/drag-link-expected.txt
[modify] https://crrev.com/9e009d46d55d1e57cac5cd2825ea25cc02d9f094/third_party/WebKit/LayoutTests/fast/events/drag-selects-image-expected.txt
[modify] https://crrev.com/9e009d46d55d1e57cac5cd2825ea25cc02d9f094/third_party/WebKit/LayoutTests/fast/forms/button/button-click-DOM-expected.txt
[modify] https://crrev.com/9e009d46d55d1e57cac5cd2825ea25cc02d9f094/third_party/WebKit/LayoutTests/fast/forms/select/select-namedItem-expected.txt
[modify] https://crrev.com/9e009d46d55d1e57cac5cd2825ea25cc02d9f094/third_party/WebKit/LayoutTests/fast/invalid/nestedh3s-rapidweaver-expected.txt
[modify] https://crrev.com/9e009d46d55d1e57cac5cd2825ea25cc02d9f094/third_party/WebKit/LayoutTests/fast/multicol/widows-and-orphans-expected.txt
[modify] https://crrev.com/9e009d46d55d1e57cac5cd2825ea25cc02d9f094/third_party/WebKit/LayoutTests/fast/parser/external-entities-expected.txt
[modify] https://crrev.com/9e009d46d55d1e57cac5cd2825ea25cc02d9f094/third_party/WebKit/LayoutTests/fast/parser/xml-colon-entity-expected.txt
[modify] https://crrev.com/9e009d46d55d1e57cac5cd2825ea25cc02d9f094/third_party/WebKit/LayoutTests/fast/parser/xml-declaration-missing-ending-mark-expected.txt
[modify] https://crrev.com/9e009d46d55d1e57cac5cd2825ea25cc02d9f094/third_party/WebKit/LayoutTests/fast/table/rowspan-only-rows-height-distribution-expected.txt
[modify] https://crrev.com/9e009d46d55d1e57cac5cd2825ea25cc02d9f094/third_party/WebKit/LayoutTests/fast/table/table-all-rowspans-height-distribution-in-rows-expected.txt
[modify] https://crrev.com/9e009d46d55d1e57cac5cd2825ea25cc02d9f094/third_party/WebKit/LayoutTests/fast/table/table-colgroup-present-after-table-row-expected.txt
[modify] https://crrev.com/9e009d46d55d1e57cac5cd2825ea25cc02d9f094/third_party/WebKit/LayoutTests/fast/table/table-rowspan-cell-override-logical-content-height-reset-issue-expected.txt
[modify] https://crrev.com/9e009d46d55d1e57cac5cd2825ea25cc02d9f094/third_party/WebKit/LayoutTests/fast/table/table-rowspan-cell-with-empty-cell-expected.txt
[modify] https://crrev.com/9e009d46d55d1e57cac5cd2825ea25cc02d9f094/third_party/WebKit/LayoutTests/fast/table/table-rowspan-crash-only-percent-rows-with-less-than-100-percent-expected.txt
[modify] https://crrev.com/9e009d46d55d1e57cac5cd2825ea25cc02d9f094/third_party/WebKit/LayoutTests/fast/table/table-rowspan-crash-with-huge-pedding-value-expected.txt
[modify] https://crrev.com/9e009d46d55d1e57cac5cd2825ea25cc02d9f094/third_party/WebKit/LayoutTests/fast/table/table-rowspan-crash-with-huge-rowspan-cells-2-expected.txt
[modify] https://crrev.com/9e009d46d55d1e57cac5cd2825ea25cc02d9f094/third_party/WebKit/LayoutTests/fast/table/table-rowspan-crash-with-huge-rowspan-cells-expected.txt
[modify] https://crrev.com/9e009d46d55d1e57cac5cd2825ea25cc02d9f094/third_party/WebKit/LayoutTests/fast/table/table-rowspan-height-distribution-in-rows-1-expected.txt
[modify] https://crrev.com/9e009d46d55d1e57cac5cd2825ea25cc02d9f094/third_party/WebKit/LayoutTests/fast/table/table-rowspan-height-distribution-in-rows-2-expected.txt
[modify] https://crrev.com/9e009d46d55d1e57cac5cd2825ea25cc02d9f094/third_party/WebKit/LayoutTests/fast/table/table-rowspan-height-less-than-one-percent-expected.txt
[modify] https://crrev.com/9e009d46d55d1e57cac5cd2825ea25cc02d9f094/third_party/WebKit/LayoutTests/fast/table/table-rowspan-row-height-less-than-content-height-expected.txt
[modify] https://crrev.com/9e009d46d55d1e57cac5cd2825ea25cc02d9f094/third_party/WebKit/LayoutTests/fast/table/table-rowspan-table-height-and-row-precent-height-too-large-expected.txt
[modify] https://crrev.com/9e009d46d55d1e57cac5cd2825ea25cc02d9f094/third_party/WebKit/LayoutTests/fast/table/table-rowspan-wrong-height-with-only-spanning-cells-expected.txt
[modify] https://crrev.com/9e009d46d55d1e57cac5cd2825ea25cc02d9f094/third_party/WebKit/LayoutTests/fast/table/table-sections-border-spacing-expected.txt
[modify] https://crrev.com/9e009d46d55d1e57cac5cd2825ea25cc02d9f094/third_party/WebKit/LayoutTests/fast/table/table-toggle-paragraph-padding-expected.txt
[modify] https://crrev.com/9e009d46d55d1e57cac5cd2825ea25cc02d9f094/third_party/WebKit/LayoutTests/fast/tokenizer/004-expected.txt
[modify] https://crrev.com/9e009d46d55d1e57cac5cd2825ea25cc02d9f094/third_party/WebKit/LayoutTests/fast/xpath/xpath-functional-test-expected.txt
[modify] https://crrev.com/9e009d46d55d1e57cac5cd2825ea25cc02d9f094/third_party/WebKit/LayoutTests/html/tabular_data/table_insertrow-expected.txt
[modify] https://crrev.com/9e009d46d55d1e57cac5cd2825ea25cc02d9f094/third_party/WebKit/LayoutTests/http/tests/security/frameNavigation/xss-DENIED-targeted-link-navigation-expected.txt
[modify] https://crrev.com/9e009d46d55d1e57cac5cd2825ea25cc02d9f094/third_party/WebKit/LayoutTests/platform/linux/editing/selection/drag-start-event-client-x-y-expected.txt
[modify] https://crrev.com/9e009d46d55d1e57cac5cd2825ea25cc02d9f094/third_party/WebKit/LayoutTests/platform/linux/fast/table/table-rowspan-height-less-than-one-percent-expected.txt
[modify] https://crrev.com/9e009d46d55d1e57cac5cd2825ea25cc02d9f094/third_party/WebKit/LayoutTests/platform/linux/svg/custom/use-invalid-pattern-expected.txt
[modify] https://crrev.com/9e009d46d55d1e57cac5cd2825ea25cc02d9f094/third_party/WebKit/LayoutTests/platform/mac/fast/table/table-all-rowspans-height-distribution-in-rows-except-overlapped-expected.txt
[modify] https://crrev.com/9e009d46d55d1e57cac5cd2825ea25cc02d9f094/third_party/WebKit/LayoutTests/platform/mac/fast/table/table-all-rowspans-height-distribution-in-rows-expected.txt
[modify] https://crrev.com/9e009d46d55d1e57cac5cd2825ea25cc02d9f094/third_party/WebKit/LayoutTests/platform/mac/fast/table/table-rowspan-height-distribution-in-rows-1-expected.txt
[modify] https://crrev.com/9e009d46d55d1e57cac5cd2825ea25cc02d9f094/third_party/WebKit/LayoutTests/platform/mac/fast/table/table-rowspan-height-distribution-in-rows-2-expected.txt
[modify] https://crrev.com/9e009d46d55d1e57cac5cd2825ea25cc02d9f094/third_party/WebKit/LayoutTests/platform/win/editing/selection/drag-start-event-client-x-y-expected.txt
[modify] https://crrev.com/9e009d46d55d1e57cac5cd2825ea25cc02d9f094/third_party/WebKit/LayoutTests/platform/win/fast/table/table-all-rowspans-height-distribution-in-rows-except-overlapped-expected.txt
[modify] https://crrev.com/9e009d46d55d1e57cac5cd2825ea25cc02d9f094/third_party/WebKit/LayoutTests/platform/win/fast/table/table-rowspan-height-less-than-one-percent-expected.txt
[modify] https://crrev.com/9e009d46d55d1e57cac5cd2825ea25cc02d9f094/third_party/WebKit/LayoutTests/platform/win/svg/custom/use-invalid-pattern-expected.txt
[modify] https://crrev.com/9e009d46d55d1e57cac5cd2825ea25cc02d9f094/third_party/WebKit/LayoutTests/svg/custom/bug78807-expected.txt
[modify] https://crrev.com/9e009d46d55d1e57cac5cd2825ea25cc02d9f094/third_party/WebKit/LayoutTests/svg/custom/use-crash-in-non-wellformed-document-expected.txt
[modify] https://crrev.com/9e009d46d55d1e57cac5cd2825ea25cc02d9f094/third_party/WebKit/LayoutTests/svg/custom/use-invalid-html-expected.txt
[modify] https://crrev.com/9e009d46d55d1e57cac5cd2825ea25cc02d9f094/third_party/WebKit/LayoutTests/svg/custom/use-invalid-pattern-expected.txt
[modify] https://crrev.com/9e009d46d55d1e57cac5cd2825ea25cc02d9f094/third_party/WebKit/LayoutTests/svg/custom/use-invalid-style-expected.txt
[modify] https://crrev.com/9e009d46d55d1e57cac5cd2825ea25cc02d9f094/third_party/WebKit/LayoutTests/svg/custom/use-referencing-style-crash-expected.txt
[modify] https://crrev.com/9e009d46d55d1e57cac5cd2825ea25cc02d9f094/third_party/WebKit/LayoutTests/traversal/node-iterator-009-expected.txt
[modify] https://crrev.com/9e009d46d55d1e57cac5cd2825ea25cc02d9f094/third_party/WebKit/LayoutTests/traversal/tree-walker-006-expected.txt
[modify] https://crrev.com/9e009d46d55d1e57cac5cd2825ea25cc02d9f094/third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp

Project Member

Comment 11 by bugdroid1@chromium.org, Sep 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3fba023e99a039f2c493acf0cd42305ea42f0fd1

commit 3fba023e99a039f2c493acf0cd42305ea42f0fd1
Author: Xiaocheng Hu <xiaochengh@chromium.org>
Date: Thu Sep 14 17:54:11 2017

Stop TextIterator from emitting double newlines after H1 and H2

TextIterator currently may add two consecutive newlines after an
H1/2 element, while the spec of innerText doesn't have this case at all.

This patch removes the extra newline to make TextIterator more
spec-complicant.

Most of this patch is rebaselining test results. Only the following
two files contains non-trivial change:
- editing/iterators/TextIterator.cpp: the implementation change
- LayoutTests/TestExpectations: found one more layout tests where
  editing command relying on incorrect plain text char count fails

Bug:  752672 , 758816 
Change-Id: I524ef1e95c9c25372b9ba350e3d70bc5d604985e
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Reviewed-on: https://chromium-review.googlesource.com/665378
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501988}
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/content/test/data/accessibility/aria/aria-textbox-with-rich-text-expected-mac.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/content/test/data/accessibility/aria/aria-textbox-with-rich-text-expected-win.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/accessibility/aria-controls-with-tabs-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/accessibility/aria-hidden-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/accessibility/aria-hidden-updates-alldescendants-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/accessibility/aria-hidden-with-elements-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/accessibility/aria-roles-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/accessibility/css-styles-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/accessibility/element-role-mapping-normal-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/accessibility/image-link-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/accessibility/image-link-inline-cont-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/accessibility/inline-continuations-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/accessibility/inline-text-word-boundary-causes-crash-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/accessibility/non-data-table-cell-title-ui-element-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/accessibility/table-detection-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/compositing/visibility/visibility-image-layers-dynamic-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/dom/domparsing/dom-parse-serialize-display-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/dom/domparsing/dom-parse-serialize-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/editing/execCommand/5700414-1-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/editing/execCommand/5700414-2-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/editing/pasteboard/copy-backslash-with-euc-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/editing/pasteboard/smart-paste-003-trailing-whitespace-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/editing/selection/doubleclick-beside-cr-span-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/editing/style/heading-text-after-hr-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/external/wpt/innerText/getter-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/fast/block/block-remove-child-delete-line-box-crash-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/fast/block/min-max-height-percent-height-child-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/fast/canvas/canvas-composite-alpha-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/fast/canvas/canvas-composite-canvas-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/fast/canvas/canvas-composite-image-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/fast/canvas/canvas-composite-stroke-alpha-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/fast/canvas/canvas-composite-text-alpha-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/fast/css-grid-layout/maximize-tracks-definite-indefinite-height-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/fast/css-grid-layout/maximize-tracks-definite-indefinite-width-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-properties-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/getComputedStyle-zoom-and-background-size-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/fast/css/link-alternate-stylesheet-1-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/fast/css/link-alternate-stylesheet-2-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/fast/css/link-alternate-stylesheet-3-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/fast/css/link-alternate-stylesheet-4-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/fast/css/link-alternate-stylesheet-5-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/fast/css/number-parsing-crash-2-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/fast/css/pseudo-any-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/fast/dom/HTMLLinkElement/prerender-insert-after-stop-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/fast/dom/HTMLLinkElement/prerender-remove-after-stop-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/fast/dom/HTMLLinkElement/resolve-url-on-insertion-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/fast/dom/HTMLMeterElement/meter-element-with-child-crash-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/fast/dom/HTMLProgressElement/progress-element-indeterminate-crash-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/fast/dom/HTMLProgressElement/progress-element-with-child-crash-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/fast/dom/HTMLProgressElement/progress-element-with-style-crash-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/fast/dom/Range/range-expand-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/fast/dom/SelectorAPI/bug-17313-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/fast/dom/SelectorAPI/resig-SelectorsAPI-test-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/fast/dom/attribute-empty-value-no-children-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/fast/dom/inner-text-001-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/fast/dom/shadow/tree-scope-crash-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/fast/events/imagemap-norender-crash-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/fast/events/pointer-events-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/fast/forms/focus-selection-input-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/fast/forms/focus-selection-textarea-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/fast/forms/number/number-spinbutton-in-multi-column-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/fast/forms/number/number-spinbutton-state-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/fast/forms/paste-multiline-text-input-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/fast/forms/range/slider-in-multi-column-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/fast/forms/select/listbox-in-multi-column-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/fast/forms/select/menulist-type-ahead-find-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/fast/forms/select/menulist-type-ahead-find-original-item-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/fast/forms/select/remove-element-from-within-focus-handler-crash-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/fast/forms/select/select-selectedIndex-bug-12942-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/fast/gradients/crash-on-1px-border-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/fast/gradients/crash-on-degenerate-gradient-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/fast/html/draggable-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/fast/html/imports/import-master-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/fast/html/imports/import-style-basic-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/fast/html/imports/import-style-link-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/fast/lists/w3-css3-list-styles-alphabetic-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/fast/lists/w3-css3-list-styles-fallback-style-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/fast/lists/w3-css3-list-styles-numeric-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/fast/lists/w3-css3-lower-armenian-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/fast/lists/w3-css3-upper-armenian-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/fast/lists/w3-list-styles-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/fast/multicol/span/anonymous-before-child-parent-crash-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/fast/multicol/span/anonymous-split-block-crash-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/fast/parser/entities-in-html-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/fast/parser/entities-in-xhtml-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/fast/parser/invalid-entity-document-write-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/fast/ruby/float-object-doesnt-crash-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/fast/table/table-rowspan-crash-only-percent-rows-with-less-than-100-percent-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/fast/table/table-rowspan-crash-with-huge-pedding-value-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/fast/text/international/shape-across-elements-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/fast/xmlhttprequest/xmlhttprequest-get-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/fast/xpath/xpath-functional-test-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/fast/xsl/sort-locale-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/fast/xsl/sort-unicode-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/http/tests/css/border-image-loading-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/http/tests/css/css-image-loading-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/http/tests/css/css-non-blocking-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/http/tests/css/mask-image-loading-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/http/tests/css/reflection-mask-image-loading-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/get-set-stylesheet-text-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/parse-utf8-bom-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/selector-source-data-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-new-API-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/up-down-numerics-and-colors-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/http/tests/misc/DOMContentLoaded-event-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/http/tests/misc/empty-file-formdata-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/http/tests/misc/link-rel-prefetch-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/http/tests/notifications/notification-sandbox-permission-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/http/tests/security/subresourceIntegrity/subresource-integrity-style-blocked-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/paint/invalidation/update-visual-rects-after-compositing-change-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/paint/selection/text-selection-editing-crash-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/platform/linux/svg/animations/animate-text-nested-transforms-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/platform/linux/svg/animations/svglength-animation-px-to-exs-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/platform/mac/fast/forms/select/menulist-type-ahead-find-original-item-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/platform/mac/virtual/threaded/compositing/visibility/visibility-image-layers-dynamic-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/platform/win/compositing/visibility/visibility-image-layers-dynamic-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/platform/win/svg/animations/animate-text-nested-transforms-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/platform/win/svg/animations/svglength-animation-px-to-exs-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/platform/win/virtual/threaded/compositing/visibility/visibility-image-layers-dynamic-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/svg/animations/accumulate-values-width-animation-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/svg/animations/additive-from-to-width-animation-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/svg/animations/additive-type-by-animation-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/svg/animations/additive-values-width-animation-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/svg/animations/animVal-basics-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/svg/animations/animate-calcMode-spline-by-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/svg/animations/animate-calcMode-spline-from-by-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/svg/animations/animate-calcMode-spline-from-to-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/svg/animations/animate-calcMode-spline-to-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/svg/animations/animate-calcMode-spline-values-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/svg/animations/animate-color-calcMode-discrete-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/svg/animations/animate-color-fill-currentColor-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/svg/animations/animate-color-fill-from-by-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/svg/animations/animate-color-rgba-calcMode-discrete-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/svg/animations/animate-color-transparent-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/svg/animations/animate-css-xml-attributeType-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/svg/animations/animate-currentColor-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/svg/animations/animate-dynamic-update-attributeName-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/svg/animations/animate-elem-02-t-drt-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/svg/animations/animate-elem-03-t-drt-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/svg/animations/animate-elem-04-t-drt-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/svg/animations/animate-elem-05-t-drt-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/svg/animations/animate-elem-06-t-drt-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/svg/animations/animate-elem-07-t-drt-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/svg/animations/animate-elem-08-t-drt-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/svg/animations/animate-elem-09-t-drt-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/svg/animations/animate-elem-10-t-drt-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/svg/animations/animate-elem-11-t-drt-expected.txt
[modify] https://crrev.com/3fba023e99a039f2c493acf0cd42305ea42f0fd1/third_party/WebKit/LayoutTests/svg/animations/animate-elem-12-t-drt-expected.txt
[modify] http

Project Member

Comment 12 by bugdroid1@chromium.org, Sep 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4f916f9e833becdd3d05d88eb33ba9018c03ce69

commit 4f916f9e833becdd3d05d88eb33ba9018c03ce69
Author: Max Morin <maxmorin@chromium.org>
Date: Fri Sep 15 08:48:23 2017

Update expectation for fast/text-autosizing/table-inflation-crash.

This one seems to have been missed in
https://chromium-review.googlesource.com/c/chromium/src/+/665378.

TBR: xiaochengh
Bug:  752672 , 758816 
Change-Id: I98e851115af643b6bf7cb4d6cfbda9632a450f8a
NOTRY: true
Reviewed-on: https://chromium-review.googlesource.com/668361
Commit-Queue: Max Morin <maxmorin@chromium.org>
Reviewed-by: Max Morin <maxmorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502208}
[modify] https://crrev.com/4f916f9e833becdd3d05d88eb33ba9018c03ce69/third_party/WebKit/LayoutTests/fast/text-autosizing/table-inflation-crash-expected.txt

Comment 13 by xiaoche...@chromium.org, Sep 20 2017

Blockedon: 727929

Comment 14 by xiaoche...@chromium.org, Nov 3 2017

Blockedon: 781434

Comment 15 by yosin@chromium.org, Jan 10 2018

Labels: Pri-3

Comment 16 by yosin@chromium.org, Jun 22 2018

Blocking: 852470

Comment 17 by xiaoche...@chromium.org, Dec 12

Status: WontFix (was: Available)

Closing this one as it is now obsolete. We already have spec-compliant innerText implementation.

►

Issue 752672 link

Issue metadata

TextIterator should be spec-compliant

Issue description

Comment 1 by xiaoche...@chromium.org, Aug 4 2017

Comment 1 Deleted

Comment 2 by xiaoche...@chromium.org, Aug 4 2017

Comment 2 Deleted

Comment 3 by yosin@chromium.org, Aug 7 2017

Comment 3 Deleted

Comment 4 by xiaoche...@chromium.org, Sep 7 2017

Comment 4 Deleted

Comment 5 by bugdroid1@chromium.org, Sep 11 2017

Comment 5 Deleted

Comment 6 by bugdroid1@chromium.org, Sep 12 2017

Comment 6 Deleted

Comment 7 by bugdroid1@chromium.org, Sep 12 2017

Comment 7 Deleted

Comment 8 by xiaoche...@chromium.org, Sep 12 2017

Comment 8 Deleted

Comment 9 by bugdroid1@chromium.org, Sep 13 2017

Comment 9 Deleted

Comment 10 by bugdroid1@chromium.org, Sep 13 2017

Comment 10 Deleted

Comment 11 by bugdroid1@chromium.org, Sep 14 2017

Comment 11 Deleted

Comment 12 by bugdroid1@chromium.org, Sep 15 2017

Comment 12 Deleted

Comment 13 by xiaoche...@chromium.org, Sep 20 2017

Comment 13 Deleted

Comment 14 by xiaoche...@chromium.org, Nov 3 2017

Comment 14 Deleted

Comment 15 by yosin@chromium.org, Jan 10 2018

Comment 15 Deleted

Comment 16 by yosin@chromium.org, Jun 22 2018

Comment 16 Deleted

Comment 17 by xiaoche...@chromium.org, Dec 12

Comment 17 Deleted

Sign in to add a comment