New issue
Advanced search Search tips

Issue 752670 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 2
Type: Bug



Sign in to add a comment

Presubmit Errors are Now One Character Per Line

Project Member Reported by robliao@chromium.org, Aug 4 2017

Issue description

Banned functions were used.
    base/message_loop/message_loop_unittest.cc:100:
      P
      l
      e
      a
      s
      e
       
      m
      i
      g
      r
      a
      t
      e
       
      a
      w
      a
      y
[...]
 
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64b7ab275e526e32a909511120639d90cfda21f6

commit 64b7ab275e526e32a909511120639d90cfda21f6
Author: Robert Liao <robliao@chromium.org>
Date: Fri Aug 04 23:03:43 2017

Make the RunLoop Presubmit Error Messages a Tuple

The message is expected to be a tuple, otherwise one character per
line is output like so:
Banned functions were used.
    [FILENAME]:100:
      P
      l
      e
      a
      s
      e

BUG= 752670 
TBR=dpranke@chromium.org

Change-Id: I8b91f3b236155d0ac2f037a97f3ba1289ec4c381
Reviewed-on: https://chromium-review.googlesource.com/602855
Commit-Queue: Robert Liao <robliao@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492164}
[modify] https://crrev.com/64b7ab275e526e32a909511120639d90cfda21f6/PRESUBMIT.py

Status: Fixed (was: Started)

Sign in to add a comment