New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 752660 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug

Blocked on:
issue 593874

Blocking:
issue 751812



Sign in to add a comment

Switch chromecast builds to use libc++

Project Member Reported by thomasanderson@chromium.org, Aug 4 2017

Issue description

There is an effort to switch to the debian stretch sysroot:
https://chromium-review.googlesource.com/c/598737

However, cast_shell_android fails with errors like this:
./clang_x64/ijar: /usr/lib/x86_64-linux-gnu/libstdc++.so.6: version `GLIBCXX_3.4.21' not found (required by ./clang_x64/ijar)

This is because the ijar executable was built against a newer libstdc++ from the sysroot, which has new symbols not available in the libstdc++ on Trusty.  Using libc++ instead would fix this issue.
 
Cc: mbjorge@chromium.org bcf@chromium.org
Doing this for all public bots sounds fine to me.

But according to the discussion on https://chromium-review.googlesource.com/c/587305 , internal cast builds will continue using (a more modern) libstdc++

Comment 2 by bcf@chromium.org, Aug 4 2017

We will recompile our external binaries with libc++, so we should be able to use libc++ for our internal builds too.
Yeah, we should be ready by probably end-of-day today or maybe Monday (Aug 7) to switch to libc++ for internal builds
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd262937ff52089b03dc6376f3f77db15822eed8

commit bd262937ff52089b03dc6376f3f77db15822eed8
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Sat Aug 05 00:08:18 2017

Enable libc++ on cast builds

BUG= 752660 
R=thakis@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:cast_shell_android;master.tryserver.chromium.linux:cast_shell_linux

Change-Id: I433fabfd4a8d8f95ad6c04352d2d354362b2641e
Reviewed-on: https://chromium-review.googlesource.com/602591
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492191}
[modify] https://crrev.com/bd262937ff52089b03dc6376f3f77db15822eed8/build/config/c++/c++.gni

Status: Fixed (was: Assigned)

Comment 6 by thakis@chromium.org, Mar 16 2018

Blockedon: 593874

Sign in to add a comment