New issue
Advanced search Search tips

Issue 752659 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

Disabled tests are failing on Win 10 Perf bot

Project Member Reported by bsep@chromium.org, Aug 4 2017

Issue description

On the Win 10 Perf bot (https://build.chromium.org/p/chromium.perf/builders/Win%2010%20Perf) all of the disabled tests are red. They're failing with a python error; it looks like results_merger.py needs to handle shard_results_list == [].

Traceback (most recent call last):
  File "E:\b\rr\tmplg9fqd\rw\checkout\scripts/slave\recipe_modules\swarming\resources\standard_isolated_script_merge.py", line 45, in <module>
    sys.exit(main())
  File "E:\b\rr\tmplg9fqd\rw\checkout\scripts/slave\recipe_modules\swarming\resources\standard_isolated_script_merge.py", line 41, in main
    return StandardIsolatedScriptMerge(args.output_json, args.jsons_to_merge)
  File "E:\b\rr\tmplg9fqd\rw\checkout\scripts/slave\recipe_modules\swarming\resources\standard_isolated_script_merge.py", line 25, in StandardIsolatedScriptMerge
    merged_results = results_merger.merge_test_results(shard_results_list)
  File "E:\b\rr\tmplg9fqd\rw\checkout\scripts\slave\recipe_modules\swarming\resources\results_merger.py", line 64, in merge_test_results
    if 'seconds_since_epoch' in shard_results_list[0]:
TypeError: argument of type 'NoneType' is not iterable

 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/1f492b2f790b7035932e1eb8e6510849140be396

commit 1f492b2f790b7035932e1eb8e6510849140be396
Author: Bret Sepulveda <bsep@chromium.org>
Date: Sat Aug 05 00:25:15 2017

Fix results_merger.py crashing if a results list contains None.

If one of the files to merge contains the valid json "null" this will
parse to None and crash results_merger.py.

Bug:  752659 
Change-Id: Ie83616d9c7f3deb40b31b80a3745b834f7b7771a
Reviewed-on: https://chromium-review.googlesource.com/602854
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Bret Sepulveda <bsep@chromium.org>

[modify] https://crrev.com/1f492b2f790b7035932e1eb8e6510849140be396/scripts/slave/recipe_modules/swarming/resources/results_merger.py

Components: -Infra Infra>Client>Chrome
Status: Assigned (was: Untriaged)

Comment 3 by bsep@chromium.org, Aug 7 2017

Status: Fixed (was: Assigned)
Looks like the Win 10 bots are red because of a real test failure now.

Sign in to add a comment