Unify construction of OfflineAudioContext and AudioContext in BaseAudioContext |
||
Issue descriptionBaseAudioContext has a special constructor intended only for implementing an offline context. This can be unified into one constructor that handles construction of the base context for both offline and online contexts.
,
Aug 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/936b4be1f4e1b151e3f9e37a3d0859a32dabb6e1 commit 936b4be1f4e1b151e3f9e37a3d0859a32dabb6e1 Author: Raymond Toy <rtoy@chromium.org> Date: Tue Aug 15 23:01:48 2017 Remove BaseAudioContext constructor for offline contexts There was a special BaseAudioContext constructor just for offline contexts. Remove this and have just one BaseAudioContext constructor taking an argument indicating whether this is an offline or online context. Remove the virtual HasRealtimeConstraint function too by making it non-virtual and returning the value of the flag used in construction. No changes in behavior; this is all internal. Bug: 752643 Test: none Change-Id: I2334d35cc5adcc5434844dc1d59e8d5ecb5c9720 Reviewed-on: https://chromium-review.googlesource.com/602773 Reviewed-by: Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#494590} [modify] https://crrev.com/936b4be1f4e1b151e3f9e37a3d0859a32dabb6e1/third_party/WebKit/Source/modules/webaudio/AudioContext.cpp [modify] https://crrev.com/936b4be1f4e1b151e3f9e37a3d0859a32dabb6e1/third_party/WebKit/Source/modules/webaudio/BaseAudioContext.cpp [modify] https://crrev.com/936b4be1f4e1b151e3f9e37a3d0859a32dabb6e1/third_party/WebKit/Source/modules/webaudio/BaseAudioContext.h [modify] https://crrev.com/936b4be1f4e1b151e3f9e37a3d0859a32dabb6e1/third_party/WebKit/Source/modules/webaudio/OfflineAudioContext.cpp
,
Aug 18 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by rtoy@chromium.org
, Aug 14 2017Status: Started (was: Available)