New issue
Advanced search Search tips

Issue 752639 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Proj-Servicification

Blocking:
issue 611935



Sign in to add a comment

[mojo-blobs] BlobRegistryImpl::BlobUnderConstruction sometimes isn't cleaned up when construction finishes

Project Member Reported by mek@chromium.org, Aug 4 2017

Issue description

Under some circumstances BlobUnderConstruction instances can linger around, causing files etc held by blobs to not be deleted.
 

Comment 1 by mek@chromium.org, Aug 4 2017

The bug here is because of some confusion around behavior of BlobStorageContext::BuildBlob: when building a blob synchronously fails it does call its ready-for-transport callback with the failed status, but if building finishes synchronously it doesn't call the callback at all.
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a3c3176337d980e3787a2f4e55b0659a38427330

commit a3c3176337d980e3787a2f4e55b0659a38427330
Author: Marijn Kruisselbrink <mek@chromium.org>
Date: Fri Aug 04 23:40:13 2017

Fix bug where sometimes BlobUnderConstruction instances could leak.

Bug:  752639 
Change-Id: Id57bfbaecebb54522767c1044be76119d4840ae5
Reviewed-on: https://chromium-review.googlesource.com/602875
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492175}
[modify] https://crrev.com/a3c3176337d980e3787a2f4e55b0659a38427330/storage/browser/blob/blob_registry_impl.cc
[modify] https://crrev.com/a3c3176337d980e3787a2f4e55b0659a38427330/storage/browser/blob/blob_registry_impl.h
[modify] https://crrev.com/a3c3176337d980e3787a2f4e55b0659a38427330/storage/browser/blob/blob_registry_impl_unittest.cc

Comment 3 by mek@chromium.org, Aug 9 2017

Status: Fixed (was: Started)

Comment 4 by laforge@google.com, Nov 7 2017

Components: Internals>Network>Service

Comment 5 by laforge@google.com, Nov 7 2017

Components: -Internals>Network>Service Internals>Services>Network
Apologies, applied the wrong component in bulk.

Comment 6 by laforge@google.com, Nov 8 2017

Components: Internals>Services>Storage
Setting Internals>Services>Storage to all children of issue 611935

Sign in to add a comment