HWTest stages should warn if hwtests are disabled. |
|||
Issue descriptionOur tryjobs commonly skip over hwtests. The test stages still run, and report 'green'. This has caused confusion. Adding stage warnings/messages would make it eaiser to understand what happened.
,
Aug 4 2017
can you paste an url example?
,
Aug 4 2017
Example builder here: https://uberchromegw.corp.google.com/i/chromiumos.tryserver/builders/llvm_next_toolchain/builds/556 I'll try to fix this on Monday, but I'm deputy so it might/might not get done quickly.
,
Aug 5 2017
maybe adding the text: "[SKIPPED]" as it is done with other stages are skipped would also be appropriate. (example in the same link, stage: uploadprebuilds)
,
Aug 7 2017
I think [DISABLED] would be more appropriate, since we run the stage, just not the tests. However, I'm not 100% the knowledge to generate that change in the name exists in time. Looking.
,
Aug 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/e29f97f5d8160ebbd38e94c34f8bd5f228c67875 commit e29f97f5d8160ebbd38e94c34f8bd5f228c67875 Author: Don Garrett <dgarrett@google.com> Date: Wed Aug 16 05:21:59 2017 HWTestStage: List stage as [DISABLED] when tests won't run. Tryjobs and debug builds disable hwtests. List the fact that tests are disabled as in the stage name, similar to how we display that stages are skipped. BUG= chromium:752637 TEST=run_tests + tryjobs with/without --hwtest. https://luci-milo.appspot.com/buildbot/chromiumos.tryserver/paladin/3565 https://luci-milo.appspot.com/buildbot/chromiumos.tryserver/paladin/3566 Change-Id: I47de3150765374b7eba8f1ddb6bb894612f5989c Reviewed-on: https://chromium-review.googlesource.com/614863 Commit-Ready: Don Garrett <dgarrett@chromium.org> Tested-by: Don Garrett <dgarrett@chromium.org> Reviewed-by: Paul Hobbs <phobbs@google.com> [modify] https://crrev.com/e29f97f5d8160ebbd38e94c34f8bd5f228c67875/cbuildbot/stages/test_stages.py
,
Aug 16 2017
Let me know if this doesn't resolve your issues. |
|||
►
Sign in to add a comment |
|||
Comment 1 by lloz...@google.com
, Aug 4 2017