New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 752635 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Remove all references to imgdiff and imgpatch for update_engine

Project Member Reported by ahass...@chromium.org, Aug 4 2017

Issue description

In update engine we don't use imgdiff and imgpatch anymore. Remove all the references to them.
 
vapier@: What is the correct procedure to remove imgdiff from building and going into images once these two CL's landed? imgdiff is not used by anyone anymore.

https://chromium-review.googlesource.com/c/602733
https://chromium-review.googlesource.com/c/602676

Sorry, imgdiff does not go into device images, but it sill builds and I don't think it is needed anymore unless you just want to keep it there which is fine too.
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/feebccb55dd42f17245a5bfe472214574503eb94

commit feebccb55dd42f17245a5bfe472214574503eb94
Author: Amin Hassani <ahassani@google.com>
Date: Sat Aug 12 01:07:04 2017

update_engine: Remove dependency to imgdiff

We don't use imgdiff anymore. This CL removes update_engine's dependency
to imgdiff.

BUG= chromium:752635 
TEST=./build_image --board=amd64-generic
CQ-DEPEND=CL:602733

Change-Id: I41ca4fe93c06ceca07ad5fcbbaa9dba0d53dda47
Reviewed-on: https://chromium-review.googlesource.com/602676
Commit-Ready: Amin Hassani <ahassani@chromium.org>
Tested-by: Amin Hassani <ahassani@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/feebccb55dd42f17245a5bfe472214574503eb94/chromeos-base/update_engine/update_engine-9999.ebuild

Status: Verified (was: Started)

Sign in to add a comment