Chrome Dev on Pixel C ignores everything after first character when typing on bluetooth keyboard |
||||||||
Issue descriptionChrome Version: 61.0.3163.27 OS: Android 7.1.2 on Pixel C What steps will reproduce the problem? (1) Focus in omnibox (2) Using a bluetooth keyboard, type "google" What is the expected result? The term "google" shows up in the omnibox. What happens instead? Only the character "g" shows up, the rest of the inputs are ignored.
,
Aug 4 2017
jeffcarp: is this issue specific to the omnibox? Your title suggests that this may be more general.
,
Aug 4 2017
It's just in the omnibox, typing elsewhere on the page is fine.
,
Aug 4 2017
Also confirmed that Chrome 60.0.3112.78 on the same device doesn't show this problem.
,
Aug 4 2017
jeffcarp@, I think you can turn off SpannableInlineAutocomplete by going to about:flags for now. Let me know if it doesn't work. Sorry about the trouble.
,
Aug 4 2017
changwan@ disabling that option works! No problem at all, thanks!
,
Aug 4 2017
,
Aug 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/db78f6caf88fc4fc43206965cf4901754d987a13 commit db78f6caf88fc4fc43206965cf4901754d987a13 Author: Changwan Ryu <changwan@chromium.org> Date: Tue Aug 08 14:18:46 2017 Fix a bug in the new autocomplete model for physical keyboard It seems that TextView#dispatchKeyEvent() ends up prepending the typed character in the same span right behind it, messing up the span index value. Changing the flag from INTERMEDIATE to SPAN_EXCLUSIVE_EXCLUSIVE ensures that the span does not expand to other part of the text. BUG= 752628 Change-Id: I7472db63565c7069d0151d6cb12310d3ebf7a858 Reviewed-on: https://chromium-review.googlesource.com/604489 Reviewed-by: Ted Choc <tedchoc@chromium.org> Commit-Queue: Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#492616} [modify] https://crrev.com/db78f6caf88fc4fc43206965cf4901754d987a13/chrome/android/java/src/org/chromium/chrome/browser/omnibox/SpannableAutocompleteEditTextModel.java [modify] https://crrev.com/db78f6caf88fc4fc43206965cf4901754d987a13/chrome/android/junit/src/org/chromium/chrome/browser/omnibox/AutocompleteEditTextTest.java
,
Aug 8 2017
,
Aug 8 2017
This bug requires manual review: M61 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 8 2017
FYI, #8 only affects dev 10% experiment group who uses pixel C or physical keyboard.
,
Aug 10 2017
Approved for M61 branch 3163.
,
Aug 10 2017
talked to amineer@ offline, decided not to merge as m62 dev will be released soon enough.
,
Aug 10 2017
Issue 754146 has been merged into this issue.
,
Aug 10 2017
Are you sure this doesn't need merging to m61? See Issue 754146 I can repro on 61.0.3163.27
,
Aug 11 2017
This is dev-only experiment, and m62 dev will come out around next Tuesday. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by mpear...@chromium.org
, Aug 4 2017