New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 752601 link

Starred by 2 users
Status: Fixed
Owner:
█ thanhph@chromium.org
Last visit > 30 days ago
Closed: Oct 25
Cc:
sadrul@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Rename UIDevToolsCSSAgent to CSSAgent, UIDevToolsDOMAgent to DOMAgent, and UIDevToolsOverlayAgent to OverlayAgent

Project Member Reported by thanhph@chromium.org, Aug 4 2017 
This is because ui_devtools_css_agent.h, ui_devtools_dom_agent.h, and ui_devtools_overlay_agent.h are already in ui_devtools namespace.

Comment 1 by sadrul@chromium.org, Aug 4 2017

Description: Show this description
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6350c274279699138b282ea15063f0f5a46c67ac

commit 6350c274279699138b282ea15063f0f5a46c67ac
Author: zhuoyu.qian <zhuoyu.qian@samsung.com>
Date: Wed Oct 18 20:43:04 2017

Rename UIDevToolsCSSAgent to CSSAgent.

Because ui_devtools_css_agent.(h|cc) are already in ui_devtools
namespace, UIDevToolsCSSAgent class can be simplified as CSSAgent.
Dependent files will change accordingly.

BUG= 752601 

Signed-off-by: zhuoyu.qian <zhuoyu.qian@samsung.com>
Change-Id: I27afcb747e2c3d4aa9cfb9a10a7c73890925b5c3
Reviewed-on: https://chromium-review.googlesource.com/714836
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509860}
[modify] https://crrev.com/6350c274279699138b282ea15063f0f5a46c67ac/chrome/browser/ui/views/chrome_browser_main_extra_parts_views.cc
[modify] https://crrev.com/6350c274279699138b282ea15063f0f5a46c67ac/components/ui_devtools/views/BUILD.gn
[rename] https://crrev.com/6350c274279699138b282ea15063f0f5a46c67ac/components/ui_devtools/views/css_agent.cc
[rename] https://crrev.com/6350c274279699138b282ea15063f0f5a46c67ac/components/ui_devtools/views/css_agent.h
[modify] https://crrev.com/6350c274279699138b282ea15063f0f5a46c67ac/components/ui_devtools/views/ui_devtools_unittest.cc

Comment 3 by thanhph@chromium.org, Oct 23 2017

Summary: Rename UIDevToolsCSSAgent to CSSAgent, UIDevToolsDOMAgent to DOMAgent, and UIDevToolsOverlayAgent to OverlayAgent (was: Rename UIDevToolsCSSAgent to CSSAgent and UIDevToolsDOMAgent to DOMAgent)

Comment 4 by thanhph@chromium.org, Oct 23 2017

Description: Show this description
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 31 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5d00e77af585fa70984780a705d80495a5eabe5c

commit 5d00e77af585fa70984780a705d80495a5eabe5c
Author: zhuoyu.qian <zhuoyu.qian@samsung.com>
Date: Tue Oct 31 19:11:38 2017

Rename UIDevToolsDOMAgent to DOMAgent.

Because ui_devtools_dom_agent.(h|cc) are already in ui_devtools
namespace, UIDevToolsDOMAgent class can be simplified as DOMAgent.
Dependent files will change accordingly.

BUG= 752601 
R=sadrul@chromium.org, thanhph@chromium.org

Signed-off-by: zhuoyu.qian <zhuoyu.qian@samsung.com>
Change-Id: Ide16bd0e4589021deb19d90abacd5437fcb1d589
Reviewed-on: https://chromium-review.googlesource.com/727481
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512899}
[modify] https://crrev.com/5d00e77af585fa70984780a705d80495a5eabe5c/chrome/browser/ui/views/chrome_browser_main_extra_parts_views.cc
[modify] https://crrev.com/5d00e77af585fa70984780a705d80495a5eabe5c/components/ui_devtools/views/BUILD.gn
[modify] https://crrev.com/5d00e77af585fa70984780a705d80495a5eabe5c/components/ui_devtools/views/css_agent.cc
[modify] https://crrev.com/5d00e77af585fa70984780a705d80495a5eabe5c/components/ui_devtools/views/css_agent.h
[rename] https://crrev.com/5d00e77af585fa70984780a705d80495a5eabe5c/components/ui_devtools/views/dom_agent.cc
[rename] https://crrev.com/5d00e77af585fa70984780a705d80495a5eabe5c/components/ui_devtools/views/dom_agent.h
[modify] https://crrev.com/5d00e77af585fa70984780a705d80495a5eabe5c/components/ui_devtools/views/ui_devtools_overlay_agent.cc
[modify] https://crrev.com/5d00e77af585fa70984780a705d80495a5eabe5c/components/ui_devtools/views/ui_devtools_overlay_agent.h
[modify] https://crrev.com/5d00e77af585fa70984780a705d80495a5eabe5c/components/ui_devtools/views/ui_devtools_unittest.cc
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f15d541545265b228a86695a342bd6b2361c81b8

commit f15d541545265b228a86695a342bd6b2361c81b8
Author: zhuoyu.qian <zhuoyu.qian@samsung.com>
Date: Fri Nov 03 18:37:40 2017

Rename UIDevToolsOverlayAgent to OverlayAgent.

Because ui_devtools_overlay_agent.(h|cc) are already in ui_devtools
namespace, UIDevToolsOverlayAgent class can be simplified as
OverlayAgent. Dependent files will change accordingly.

BUG= 752601 
R=sadrul@chromium.org, thanhph@chromium.org

Signed-off-by: zhuoyu.qian <zhuoyu.qian@samsung.com>
Change-Id: Iec039703e989570f1bb374adb274948245a680a5
Reviewed-on: https://chromium-review.googlesource.com/748461
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513851}
[modify] https://crrev.com/f15d541545265b228a86695a342bd6b2361c81b8/chrome/browser/ui/views/chrome_browser_main_extra_parts_views.cc
[modify] https://crrev.com/f15d541545265b228a86695a342bd6b2361c81b8/components/ui_devtools/views/BUILD.gn
[modify] https://crrev.com/f15d541545265b228a86695a342bd6b2361c81b8/components/ui_devtools/views/dom_agent.cc
[rename] https://crrev.com/f15d541545265b228a86695a342bd6b2361c81b8/components/ui_devtools/views/overlay_agent.cc
[rename] https://crrev.com/f15d541545265b228a86695a342bd6b2361c81b8/components/ui_devtools/views/overlay_agent.h
[modify] https://crrev.com/f15d541545265b228a86695a342bd6b2361c81b8/components/ui_devtools/views/ui_devtools_unittest.cc

Comment 7 by benhenry@chromium.org, Aug 1

Status: Assigned (was: Available)

Comment 8 by weili@chromium.org, Oct 25

Status: Fixed (was: Assigned)
I believe this is fixed.
►

Sign in to add a comment