New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 752599 link

Starred by 1 user
Status: Archived
Owner:
█ shuqianz@chromium.org
Last visit > 30 days ago
Closed: Aug 2017
Cc:
akes...@chromium.org
ayatane@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

test_push failed to run because test_push.py has been renamed to push_unittest.py

Project Member Reported by shuqianz@chromium.org, Aug 4 2017 
A recent change add pytest to server_management_lib, which rename test_push.py to push_unittest.py. This caused testing push failed to find the script test_push.py.

test_push.py is not a unittest file. To avoid confusion, rename test_push.py to run_test_push.py everywhere used in server management lib.

Comment 1 by akes...@chromium.org, Aug 4 2017 

If we're going to go through the trouble of renaming it, I think we should also chose a better name. "test_push" is vague and prone to misinterpretation, especially when we talk about the "test push test lab" or "pushing to the test push test lab, then running the test_push".


I propose:

The "test push lab" is hereby known as "staging lab".
The "test push" (in which we update staging) is "staging push".
The "test push test" (in which we run some tests that staging works) is "staging test".

Comment 2 by shuqianz@chromium.org, Aug 4 2017 

Sounds good. I've modified the CL based on that.
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 4 2017 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/chromeos-admin/+/c19bf4bb9dfae753ec1aaca970f01687691efbbc

commit c19bf4bb9dfae753ec1aaca970f01687691efbbc
Author: Shuqian Zhao <shuqianz@chromium.org>
Date: Fri Aug 04 21:01:31 2017

Comment 4 by shuqianz@chromium.org, Aug 4 2017

Status: Fixed (was: Untriaged)

Comment 5 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)
►

Sign in to add a comment