New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 752593 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 625689



Sign in to add a comment

LatencyInfo should be set as coalesced for coalesced gesture events

Project Member Reported by chongz@chromium.org, Aug 4 2017

Issue description

Currently |EventWithCallback| will ack coalesced events with the same |LatencyInfo|, which might cause redundant latency logging.

We want to either mark n-1 latencies as coalesced or pass nullptr instead.
 
Labels: Hotlist-Input-Dev OS-All
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/299a73a1f9756946d1df44ce03aa281647c9fc56

commit 299a73a1f9756946d1df44ce03aa281647c9fc56
Author: Chong Zhang <chongz@chromium.org>
Date: Tue Aug 08 16:23:32 2017

Set LatencyInfo to coalesced when ACKing coalesced original events

After patch we will:
1. ACK the first (oldest) original event with the given latency info;
2. ACK remaining original events with latency info set coalesced.

Note that this is not related to
"Event.Latency.ScrollUpdate.Touch.TimeToScrollUpdateSwapBegin2"
since we are already monitoring only one latency per big event.

Bug:  752593 
Change-Id: Ic9f25223664c0e54f74386efbf7fd545ba628f9a
Reviewed-on: https://chromium-review.googlesource.com/602467
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Chong Zhang <chongz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492650}
[modify] https://crrev.com/299a73a1f9756946d1df44ce03aa281647c9fc56/ui/events/blink/event_with_callback.cc
[modify] https://crrev.com/299a73a1f9756946d1df44ce03aa281647c9fc56/ui/events/blink/input_handler_proxy_unittest.cc

Labels: M-62
Status: Fixed (was: Started)

Sign in to add a comment