I am getting rotation notifications going in and out of tablet mode |
||||||||
Issue descriptionChrome Version : 61.0.3163.30 OS Version: 9765.16.0 I should not be getting those notifications just by going into and out of tablet mode (i rotated as well probably). Either way, I should not be seeing this.
,
Aug 8 2017
Oshima-san, could you take a look or reassign to appropriate people?
,
Aug 15 2017
I couldn't repro on 62.0.3180.0. wutao@, can you test it on 61? This could be due to the rotation animation change.
,
Aug 15 2017
I will take a look. The rotation animation change is in since M60. If this bug is happening in M61, then there may be a regression. I will bisect to find the cause.
,
Aug 15 2017
I only can get the notification going out of tablet mode. But this notification is shown in laptop mode (also as shown in the attach pgn on #0). oshima@ Is this expected behavior?
,
Aug 16 2017
This is not expected and is a regression in the past ~two weeks 61 builds I don't think this is due to your work on rotation animation. My best guess is that it's related to issue 742605 as it happened exactly after it was fixed.
,
Aug 16 2017
Thanks omrilio@ for the insight. You are right I also can repro this on ToT.
,
Aug 16 2017
Uploaded a cl to: https://chromium-review.googlesource.com/c/617612 Do we need to merge this back to M60 as well? I can repro in Chrome 60.0.3112.80/Platform 9592.71.0
,
Aug 16 2017
From my point of view - it looks like a 26 character change CL, low risk for a regression. +Ketaki, what do you think?
,
Aug 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f1698dacf4b32366c7f0e59e08dfbcf22bfa58af commit f1698dacf4b32366c7f0e59e08dfbcf22bfa58af Author: wutao <wutao@chromium.org> Date: Wed Aug 16 21:28:42 2017 CrOS: Do not show orientation notification when existing tablet mode. We should not get screen orientation notification when existing tablet mode. Set the rotation source to ROTATION_SOURCE_ACCELEROMETER when existing tablet mode. Bug: 752590 Test: tested on device. Change-Id: I61c208e848cef12a357755e3227a234945771092 Reviewed-on: https://chromium-review.googlesource.com/617612 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#494956} [modify] https://crrev.com/f1698dacf4b32366c7f0e59e08dfbcf22bfa58af/ash/display/screen_orientation_controller_chromeos.cc
,
Aug 17 2017
,
Aug 17 2017
Approving merge to M61 Chrome OS.
,
Aug 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3bf75b987c4400a6426fefe0ce3b61a317600b08 commit 3bf75b987c4400a6426fefe0ce3b61a317600b08 Author: Qiang Xu <warx@chromium.org> Date: Thu Aug 17 21:24:23 2017 m61 merge: CrOS: Do not show orientation notification when existing tablet mode. m61 merge on behalf of wutao@. We should not get screen orientation notification when existing tablet mode. Set the rotation source to ROTATION_SOURCE_ACCELEROMETER when existing tablet mode. TBR: oshima@chromium.org (cherry picked from commit f1698dacf4b32366c7f0e59e08dfbcf22bfa58af) Bug: 752590 Test: tested on device. Change-Id: I61c208e848cef12a357755e3227a234945771092 Reviewed-on: https://chromium-review.googlesource.com/617612 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#494956} Reviewed-on: https://chromium-review.googlesource.com/619826 Reviewed-by: Qiang(Joe) Xu <warx@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#651} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/3bf75b987c4400a6426fefe0ce3b61a317600b08/ash/display/screen_orientation_controller_chromeos.cc
,
Jan 22 2018
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by kuscher@chromium.org
, Aug 4 2017