New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 752583 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

On window resize and minimize, all window borders are shown.

Project Member Reported by mkarkada@chromium.org, Aug 4 2017

Issue description

Chrome OS Version: M62 (62.0.3176.0 dev build)
Chrome OS Platform: 9807.0.0 dev channel caroline device

Steps To Reproduce:
(1) Open Chrome window on login.
(2) Try resizing the window.
(3) Minimize the window using 'Alt'+'-'.
(4) Observe that all borders of the window are seen as like a frame.

Frequency:
This issue is seen sometimes, doesn't occur always.

Expected Result:
On minimizing any window, borders should not be seen. 

Please refer the attachment.
 
Screenshot 2017-08-04 at 10.47.19 AM.png
2.7 MB View Download
Components: -UI UI>Shell>WindowManager
Cc: skuhne@chromium.org
 Issue 750702  has been merged into this issue.
Cc: jamescook@chromium.org
Owner: est...@chromium.org
Status: Assigned (was: Untriaged)
I can repro this on ToT. The key is to keep the mouse cursor near the edge so that the shadow border is showing, and then press Alt+- to minimize. Assigning to estade.
Cc: wutao@chromium.org fsam...@chromium.org
Labels: -Type-Bug -Pri-2 Pri-1 Type-Bug-Regression
Fady, any chance this is related to recent compositor changes?

wutao, any recent animation changes you know of?

Comment 5 by wutao@chromium.org, Aug 14 2017

I do not know any changes could related to this.

This seems a regression, I built to an earlier version, (around March 17), cannot repro.

Comment 6 by est...@chromium.org, Aug 15 2017

Status: Started (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 16 2017

Comment 8 by est...@chromium.org, Aug 16 2017

Cc: keta...@chromium.org
Labels: -M-62 M-61 Merge-Request-61
This has been present for several milestones and it's probably pretty rare as no one filed the bug until recently (to my knowledge). As far as I know it's a graphical glitch but doesn't cause a crash, data loss, or anything of that nature. So we could merge to m61, but it might not be considered worth it. I'll leave that decision to the TPM in charge, ketakid@.
Labels: -Merge-Request-61 Merge-Approved-61
Approving merge to M61 Chrome OS.
Project Member

Comment 10 by bugdroid1@chromium.org, Aug 16 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/890ba09d69783c2c6958abe190fe9069c545b3a7

commit 890ba09d69783c2c6958abe190fe9069c545b3a7
Author: Evan Stade <estade@chromium.org>
Date: Wed Aug 16 20:19:30 2017

Hide chromeos window resize shadow when window hides unexpectedly.

e.g. via shortcut

TBR=estade@chromium.org

(cherry picked from commit bf51c7814db586dd69fafa2e738d995b11f573bb)

Bug:  752583 
Change-Id: If9ef937ba331c8d937190478da1dd26b9bda656b
Reviewed-on: https://chromium-review.googlesource.com/616024
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#494663}
Reviewed-on: https://chromium-review.googlesource.com/617800
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#605}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/890ba09d69783c2c6958abe190fe9069c545b3a7/ash/wm/resize_shadow_and_cursor_unittest.cc
[modify] https://crrev.com/890ba09d69783c2c6958abe190fe9069c545b3a7/ash/wm/resize_shadow_controller.cc
[modify] https://crrev.com/890ba09d69783c2c6958abe190fe9069c545b3a7/ash/wm/resize_shadow_controller.h
[modify] https://crrev.com/890ba09d69783c2c6958abe190fe9069c545b3a7/testing/buildbot/filters/ash_unittests_mash.filter

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Verified on M-63 beta build (10032.30.0, 63.0.3239.39).

Sign in to add a comment