blink_perf.paint failing on chromium.perf/Android Nexus7v2 Perf |
||
Issue descriptionblink_perf.paint failing on chromium.perf/Android Nexus7v2 Perf Builders failed on: - Android Nexus7v2 Perf: https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus7v2%20Perf These stories have been failing fairly consistently: [ FAILED ] appending-text.html [ FAILED ] large-table-repaint.html https://chromium-swarm.appspot.com/task?id=37c10803d21e7c10&refresh=10&show_raw=1 is a sample task. Screenshots of those stories look ok, so I'm not sure exactly what is wrong. wangxianzhu@ is OOO until 8/16... cc-ing some people who might be able to help? I'm going to disable those two stories on android.
,
Aug 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a976f7f3d4d30effcf6ca351bd8614e9d87ed28f commit a976f7f3d4d30effcf6ca351bd8614e9d87ed28f Author: Stephen Martinis <martiniss@chromium.org> Date: Fri Aug 04 20:11:16 2017 //tools/perf: disable stories for blink_perf.paint Disables two stories which have been failing for ~50 builds. TBR=rnephew Bug: 752579 Change-Id: I45456b8a00584e4649d44aeb2daee664a67cd869 Reviewed-on: https://chromium-review.googlesource.com/602504 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by: rnephew <rnephew@chromium.org> Reviewed-by: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#492112} [modify] https://crrev.com/a976f7f3d4d30effcf6ca351bd8614e9d87ed28f/tools/perf/benchmarks/blink_perf.py
,
Aug 4 2017
Well that answers that. I shall revert your patch as part of my patch to fix this.
,
Aug 4 2017
The CL just landed: https://chromium-review.googlesource.com/c/602504
,
Aug 4 2017
Ok :)
,
Aug 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/759a607b9502bfab9629bc493f5a452d736ebdd3 commit 759a607b9502bfab9629bc493f5a452d736ebdd3 Author: pdr <pdr@chromium.org> Date: Sat Aug 05 00:04:41 2017 Rework blink_perf.paint tests to not timeout on Nexus7v2 large-table-repaint.html and appending-text.html are too bigly for the Nexus7v2. This patch rewrites them to be faster (not timeout), and gives them some headroom to regress and still not timeout. This patch also reverts [1] which initially disabled these tests. [1] https://chromium.googlesource.com/chromium/src/+/a976f7f3d4d30effcf6ca351bd8614e9d87ed28f TBR=rnephew Bug: 752579 Change-Id: Ied87425810a1414f572cecca84eb6d1abf3fe4f1 Reviewed-on: https://chromium-review.googlesource.com/602672 Reviewed-by: Philip Rogers <pdr@chromium.org> Reviewed-by: rnephew <rnephew@chromium.org> Reviewed-by: Stephen Martinis <martiniss@chromium.org> Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#492188} [modify] https://crrev.com/759a607b9502bfab9629bc493f5a452d736ebdd3/third_party/WebKit/PerformanceTests/Paint/appending-text.html [modify] https://crrev.com/759a607b9502bfab9629bc493f5a452d736ebdd3/third_party/WebKit/PerformanceTests/Paint/large-table-repaint.html [modify] https://crrev.com/759a607b9502bfab9629bc493f5a452d736ebdd3/tools/perf/benchmarks/blink_perf.py
,
Aug 5 2017
I try to keep it light with perf sheriffs/perfbot sheriffs/etc because sheriffing can be stressful. Unfortunately, comment #3 came off poorly. Sorry about that. Thanks for your help being a sheriff today and for handling my team's failing test which had slipped our radar (no perf test coverage for ~10 days[1]) You took the time to lookup other teammembers because the test owner was OOO which was really cool. [1] https://chromeperf.appspot.com/report?sid=3588086e078f0dc18866fe1dd44d07ba1d88c82471940b678869ec50af814b56 |
||
►
Sign in to add a comment |
||
Comment 1 by pdr@chromium.org
, Aug 4 2017