New issue
Advanced search Search tips

Issue 752566 link

Starred by 14 users
Status: Fixed
Owner:
ccameron@chromium.org
Closed: Aug 2017
Cc:
ccameron@chromium.org
treib@chromium.org
mac-bugs-priority@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

White flash creating new tab

Project Member Reported by chrishtr@chromium.org, Aug 4 2017 
Version: 62.0.3175.0 / OS X / Retina

1. Install this theme:

https://chrome.google.com/webstore/detail/morpheon-dark/mafbdhjdkjnoafhfelkjpchpaepjknad?utm_source=chrome-ntp-icon

2. Make new tabs repeatedly from the NTP.

Should be no white flash. Instead there is one.

I think this is a recent regression.

Comment 2 by chrishtr@chromium.org, Aug 4 2017

Owner: kenrb@chromium.org
Reverting this patch fixed the issue:

https://chromium-review.googlesource.com/c/587464

Comment 3 by ccameron@chromium.org, Aug 8 2017 

I'm seeing lots of flashes when exposing previously-occluded tabs (I'll get a screencast in a bit). I'll try this with the patch reverted to see if it fixes the issue.

Comment 4 by kenrb@chromium.org, Aug 8 2017 

I haven't had time to look at this yet, but I'm guessing my change to CompositorLock behavior regressed the problem that this patch was fixing: https://chromium.googlesource.com/chromium/src/+/00e438cd22c5e2f26d003c15c0a1621aa24acd0c

My change fixes a security bug so I'd prefer to not have to revert it. We might have to look again at what should be happening when multiple objects are trying to simultaneously acquire CompositorLocks with different expectations.

Comment 5 by ccameron@chromium.org, Aug 11 2017

Owner: ccameron@chromium.org

Comment 6 by ccameron@chromium.org, Aug 11 2017

Status: Fixed (was: Assigned)
Revert landed in r493671, after new fix landed in r493563.

Comment 7 by kenrb@chromium.org, Aug 11 2017 

Thanks for resolving this!
►

Sign in to add a comment