New issue
Advanced search Search tips

Issue 752560 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 396344
Owner:
Closed: Aug 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

BrowserWindowPropertyManagerTest.WindowProperties is failing

Project Member Reported by joedow@chromium.org, Aug 4 2017

Issue description

This test was re-enabled via CL: https://chromium-review.googlesource.com/c/575758 but it is still failing on Windows buildbots:

[ RUN      ] BrowserTestWithProfileShortcutManager.WindowProperties
[5696:5936:0804/100336.050:WARNING:chrome_browser_main_win.cc(483)] Command line too long for RegisterApplicationRestart:  --brave-new-test-launcher --cfi-diag=0 --gtest_also_run_disabled_tests --gtest_filter=BrowserTestWithProfileShortcutManager.WindowProperties --single_process --test-launcher-bot-mode --test-launcher-summary-output="e:\b\swarm_slave\w\io5q64du\output.json" --user-data-dir="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir5404_26305\d5404_21585" --disable-offline-auto-reload --enable-profile-shortcut-manager --no-first-run --no-default-browser-check --enable-logging=stderr --safebrowsing-disable-auto-update --disable-default-apps --wm-window-animations-disabled --disable-component-update --test-type=browser --force-color-profile=srgb --disable-zero-browsers-open-for-tests --ipc-connection-timeout=30 --allow-file-access-from-files --dom-automation --log-gpu-control-list-decisions --disable-backgrounding-occluded-windows --disable-gl-drawing-for-tests --override-use-software-gl-for-tests --force-color-profile=srgb --disable-features=NetworkPrediction --flag-switches-begin --flag-switches-end --restore-last-session about:blank
../../chrome/browser/ui/views/frame/browser_window_property_manager_browsertest_win.cc(94): error:       Expected: VT_LPWSTR
      Which is: 31
To be equal to: prop_var.get().vt
      Which is: 0
Backtrace:
	std::basic_string<wchar_t,std::char_traits<wchar_t>,std::allocator<wchar_t> >::compare [0x012EDB80+14]
	testing::internal::CmpHelperEQ<std::basic_string<wchar_t,std::char_traits<wchar_t>,std::allocator<wchar_t> >,wchar_t *> [0x0191E7FB+24]
	BrowserTestWithProfileShortcutManager_WindowProperties_Test::RunTestOnMainThread [0x0191D834+2436]
	BrowserTestWithProfileShortcutManager_WindowProperties_Test::RunTestOnMainThread [0x0191CEE3+51]
	content::BrowserTestBase::ProxyRunTestOnMainThreadLoop [0x02B52748+248]
	ChromeBrowserMainParts::PreMainMessageLoopRunImpl [0x031F449E+3298]
	ChromeBrowserMainParts::PreMainMessageLoopRun [0x031F377C+268]
	content::BrowserMainLoop::PreMainMessageLoopRun [0x01E5709C+188]
	content::StartupTaskRunner::RunAllTasksNow [0x020A5CFE+34]
	content::BrowserMainLoop::CreateStartupTasks [0x01E55DD4+600]
	content::BrowserMainRunnerImpl::Initialize [0x01E5901C+700]
	content::BrowserMain [0x01E5442C+172]
	content::RunNamedProcessTypeMain [0x02A07BFF+123]
	content::ContentMainRunnerImpl::Run [0x02A080E2+162]
	service_manager::Main [0x039D6AB0+620]
	content::ContentMain [0x02A07B2D+49]
	content::BrowserTestBase::SetUp [0x02B52598+1048]
	InProcessBrowserTest::SetUp [0x02AC4B16+262]
	testing::Test::Run [0x01A93A29+113]
	testing::TestInfo::Run [0x01A94105+213]
	testing::TestCase::Run [0x01A94494+246]
	testing::internal::UnitTestImpl::RunAllTests [0x01A9814A+602]
	testing::UnitTest::Run [0x01A97E16+178]
	base::TestSuite::Run [0x02AD9885+113]
	ChromeTestSuiteRunner::RunTestSuite [0x04FD462B+75]
	content::LaunchTests [0x02B488CF+303]
	LaunchChromeTests [0x04FD48EE+77]
	main [0x04FD45A6+86]
	__scrt_common_main_seh [0x05A7FB2B+249] (f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:253)
	BaseThreadInitThunk [0x753EEE6C+18]
	RtlInitializeExceptionChain [0x76E83AB3+239]
	RtlInitializeExceptionChain [0x76E83A86+194]
 

Comment 1 by bsep@chromium.org, Aug 4 2017

Mergedinto: 396344
Status: Duplicate (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/098de23f872c6b40abb93fc47434b7094f152a7b

commit 098de23f872c6b40abb93fc47434b7094f152a7b
Author: Joe Downing <joedow@google.com>
Date: Fri Aug 04 19:48:49 2017

Disabling flaky BrowserWindowPropertyManagerTest.WindowProperties test

TBR=bsep@chromium.org
BUG= 752560 

Change-Id: I9895e1c34ae5dc6c06e8d85679f777823d85be31
Reviewed-on: https://chromium-review.googlesource.com/602409
Commit-Queue: Joe Downing <joedow@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492105}
[modify] https://crrev.com/098de23f872c6b40abb93fc47434b7094f152a7b/chrome/browser/ui/views/frame/browser_window_property_manager_browsertest_win.cc

Sign in to add a comment