MediaRouterDesktopTest.UpdateMediaSinksOnUserGesture flaky on Win |
||||
Issue descriptionhttps://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/62066 [ RUN ] MediaRouterDesktopTest.UpdateMediaSinksOnUserGesture GMOCK WARNING: Uninteresting mock function call - returning directly. Function call: OnMojoConnectionsReady() NOTE: You can safely ignore the above warning unless this call should not happen. Do not suppress it by blindly adding an EXPECT_CALL() if you don't mean to enforce the call. See https://github.com/google/googletest/blob/master/googlemock/docs/CookBook.md#knowing-when-to-expect for details. GMOCK WARNING: Uninteresting mock function call - returning directly. Function call: StartObservingMediaRoutes(@0018D0CC "") NOTE: You can safely ignore the above warning unless this call should not happen. Do not suppress it by blindly adding an EXPECT_CALL() if you don't mean to enforce the call. See https://github.com/google/googletest/blob/master/googlemock/docs/CookBook.md#knowing-when-to-expect for details. GMOCK WARNING: Uninteresting mock function call - returning directly. Function call: EnableMdnsDiscovery() NOTE: You can safely ignore the above warning unless this call should not happen. Do not suppress it by blindly adding an EXPECT_CALL() if you don't mean to enforce the call. See https://github.com/google/googletest/blob/master/googlemock/docs/CookBook.md#knowing-when-to-expect for details. ../../chrome/browser/media/router/mojo/media_router_desktop_unittest.cc(160): error: Actual function call count doesn't match EXPECT_CALL(mock_media_route_provider_, EnableMdnsDiscovery())... Expected: to be called once Actual: never called - unsatisfied and active [ FAILED ] MediaRouterDesktopTest.UpdateMediaSinksOnUserGesture (122 ms) The culprit is https://chromium-review.googlesource.com/c/572501
,
Aug 4 2017
Hmm I'm not able to repro this on my Windows machine. Looking at the log above, it's weird that EnableMdnsDiscovery() does get called, but doesn't match the EXPECT_CALL(). Not sure what's going on there.
,
Nov 8 2017
,
Nov 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/687b4385de466e7f3783d0f401f64d296551df94 commit 687b4385de466e7f3783d0f401f64d296551df94 Author: btolsch <btolsch@chromium.org> Date: Wed Nov 08 00:34:56 2017 Fix some Windows-disabled MediaRouterDesktop tests The MediaRouterDesktop refactoring dropped the FirewallCheck::SKIP_FOR_TESTING flag, which causes the firewall check to run, which runs outside of chrome's normally controlled message loops (in a COM STA thread) which leads to a race. The refactoring also dropped the is_mdns_enabled_ flag which changes the number/timing of EnableMdnsDiscovery() calls to expect. Bug: 752513 , 781412 Change-Id: I11c492f9a068c6c048dafd11ece5684b095ebef1 Reviewed-on: https://chromium-review.googlesource.com/756892 Reviewed-by: Wez <wez@chromium.org> Reviewed-by: Takumi Fujimoto <takumif@chromium.org> Commit-Queue: Brandon Tolsch <btolsch@chromium.org> Cr-Commit-Position: refs/heads/master@{#514670} [modify] https://crrev.com/687b4385de466e7f3783d0f401f64d296551df94/chrome/browser/media/router/mojo/media_router_desktop_unittest.cc
,
Nov 9 2017
Closing this bug as well since the waterfall is still looking good after the last fix. |
||||
►
Sign in to add a comment |
||||
Comment 1 by bugdroid1@chromium.org
, Aug 4 2017