New issue
Advanced search Search tips

Issue 752504 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug

Blocking:
issue 618368
issue 729185



Sign in to add a comment

send / use overlay size with promotion hint to fix initial overlay rect

Project Member Reported by liber...@chromium.org, Aug 4 2017

Issue description

when switching to an overlay, the initial position and size are wrong.  if ScheduleOverlayPlane arrives too late to set it, then we see a black flash when entering fullscreen, while the overlay is in the wrong spot.

we can send the size with the promotion hint (currently sends the origin only), and use that for the initial position.
 
Blocking: 618368
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/622578c065664b3e2a0e5f8ee449e9537874dffe

commit 622578c065664b3e2a0e5f8ee449e9537874dffe
Author: liberato@chromium.org <liberato@chromium.org>
Date: Tue Aug 08 17:27:42 2017

Added display_{width, height} to overlay hint.

Previously, we sent the display position but not the size to the
GLStreamTextureImage during overlay processing.  It turns out that
the size is also useful when using the hint.

In particular, knowing the complete bounds for it lets us set the
initial position properly, and avoid some ugly transitions into
fullscreen on clank.  This CL doesn't include any code to use the
size information.

Bug:  752504 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ie5391eddf8129f788d20fd7bbefc1416ac80a884
Reviewed-on: https://chromium-review.googlesource.com/602448
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Commit-Queue: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492685}
[modify] https://crrev.com/622578c065664b3e2a0e5f8ee449e9537874dffe/cc/output/overlay_candidate.cc
[modify] https://crrev.com/622578c065664b3e2a0e5f8ee449e9537874dffe/cc/output/overlay_candidate.h
[modify] https://crrev.com/622578c065664b3e2a0e5f8ee449e9537874dffe/cc/resources/resource_provider.cc
[modify] https://crrev.com/622578c065664b3e2a0e5f8ee449e9537874dffe/gpu/command_buffer/client/gles2_c_lib_autogen.h
[modify] https://crrev.com/622578c065664b3e2a0e5f8ee449e9537874dffe/gpu/command_buffer/client/gles2_cmd_helper_autogen.h
[modify] https://crrev.com/622578c065664b3e2a0e5f8ee449e9537874dffe/gpu/command_buffer/client/gles2_implementation_autogen.h
[modify] https://crrev.com/622578c065664b3e2a0e5f8ee449e9537874dffe/gpu/command_buffer/client/gles2_implementation_impl_autogen.h
[modify] https://crrev.com/622578c065664b3e2a0e5f8ee449e9537874dffe/gpu/command_buffer/client/gles2_interface_autogen.h
[modify] https://crrev.com/622578c065664b3e2a0e5f8ee449e9537874dffe/gpu/command_buffer/client/gles2_interface_stub_autogen.h
[modify] https://crrev.com/622578c065664b3e2a0e5f8ee449e9537874dffe/gpu/command_buffer/client/gles2_interface_stub_impl_autogen.h
[modify] https://crrev.com/622578c065664b3e2a0e5f8ee449e9537874dffe/gpu/command_buffer/client/gles2_trace_implementation_autogen.h
[modify] https://crrev.com/622578c065664b3e2a0e5f8ee449e9537874dffe/gpu/command_buffer/client/gles2_trace_implementation_impl_autogen.h
[modify] https://crrev.com/622578c065664b3e2a0e5f8ee449e9537874dffe/gpu/command_buffer/cmd_buffer_functions.txt
[modify] https://crrev.com/622578c065664b3e2a0e5f8ee449e9537874dffe/gpu/command_buffer/common/gles2_cmd_format_autogen.h
[modify] https://crrev.com/622578c065664b3e2a0e5f8ee449e9537874dffe/gpu/command_buffer/common/gles2_cmd_format_test_autogen.h
[modify] https://crrev.com/622578c065664b3e2a0e5f8ee449e9537874dffe/gpu/command_buffer/common/gles2_cmd_utils_implementation_autogen.h
[modify] https://crrev.com/622578c065664b3e2a0e5f8ee449e9537874dffe/gpu/command_buffer/service/gl_stream_texture_image.h
[modify] https://crrev.com/622578c065664b3e2a0e5f8ee449e9537874dffe/gpu/command_buffer/service/gles2_cmd_decoder.cc
[modify] https://crrev.com/622578c065664b3e2a0e5f8ee449e9537874dffe/gpu/command_buffer/service/gles2_cmd_decoder_autogen.h
[modify] https://crrev.com/622578c065664b3e2a0e5f8ee449e9537874dffe/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doer_prototypes.h
[modify] https://crrev.com/622578c065664b3e2a0e5f8ee449e9537874dffe/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doers.cc
[modify] https://crrev.com/622578c065664b3e2a0e5f8ee449e9537874dffe/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_handlers_autogen.cc
[modify] https://crrev.com/622578c065664b3e2a0e5f8ee449e9537874dffe/media/gpu/avda_codec_image.cc
[modify] https://crrev.com/622578c065664b3e2a0e5f8ee449e9537874dffe/media/gpu/avda_codec_image.h

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1d251d38bcbafcca294a5eb05d38c4e8b6fda7cd

commit 1d251d38bcbafcca294a5eb05d38c4e8b6fda7cd
Author: liberato@chromium.org <liberato@chromium.org>
Date: Tue Aug 08 17:42:13 2017

Use promotion hint rect for overlay initial position.

When promoting video to an overlay in AVDA, we need to provide an
initial rect for it.  This CL sets that rect to be the same as the
one for the most recent promotion hint, so that it lines up with
wherever the non-overlay video quad was.

It also introduces a delay before switching to overlays when
transitioning into fullscreen to give the blink layout time to
finish.  This makes the transition look much better.

Bug:  752504 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I01b512c40cdffbbe597ebf7eadeb705bf406812f
Reviewed-on: https://chromium-review.googlesource.com/602523
Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Commit-Queue: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492691}
[modify] https://crrev.com/1d251d38bcbafcca294a5eb05d38c4e8b6fda7cd/media/base/media_switches.cc
[modify] https://crrev.com/1d251d38bcbafcca294a5eb05d38c4e8b6fda7cd/media/gpu/android/promotion_hint_aggregator.h
[modify] https://crrev.com/1d251d38bcbafcca294a5eb05d38c4e8b6fda7cd/media/gpu/android_video_decode_accelerator.cc
[modify] https://crrev.com/1d251d38bcbafcca294a5eb05d38c4e8b6fda7cd/media/gpu/android_video_decode_accelerator.h
[modify] https://crrev.com/1d251d38bcbafcca294a5eb05d38c4e8b6fda7cd/media/gpu/android_video_surface_chooser.h
[modify] https://crrev.com/1d251d38bcbafcca294a5eb05d38c4e8b6fda7cd/media/gpu/android_video_surface_chooser_impl.cc
[modify] https://crrev.com/1d251d38bcbafcca294a5eb05d38c4e8b6fda7cd/media/gpu/android_video_surface_chooser_impl_unittest.cc
[modify] https://crrev.com/1d251d38bcbafcca294a5eb05d38c4e8b6fda7cd/media/gpu/avda_codec_image.cc

Status: Fixed (was: Started)
Blocking: 729185

Sign in to add a comment