New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 752453 link

Starred by 2 users
Status: Fixed
Owner:
treib@chromium.org
Closed: Sep 2017
Cc:
█ k...@chromium.org
█ bauerb@chromium.org
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Feature

Blocked on:
issue 725435
Blocking:
issue 753815



Sign in to add a comment

Allow non-Google default search engine to have "Doodles" on the Android NTP

Project Member Reported by treib@chromium.org, Aug 4 2017 
This is a follow-up to  issue 725435 : That one allowed non-Google DSEs to have a static logo on the NTP. This is about allowing them to implement the full "Doodle" API which also supports animated images, more flexible dynamic updates, and custom clickthrough URLs.
To do this, we will implement a new field "doodle_api_url" in prepopulated_engines.json, which allows each search engine to specify their own URL for the Doodle API. If that field is not populated, we will fall back to the "logo_url" introduced in  issue 725435 . If that is also missing, there will be no logo on the URL.

Comment 1 by fi...@chromium.org, Aug 7 2017

Labels: zine-triaged

Comment 2 by treib@chromium.org, Aug 9 2017

Status: Started (was: Assigned)

Comment 3 by treib@chromium.org, Aug 9 2017

Blocking: 753815

Comment 4 by treib@chromium.org, Aug 21 2017

Labels: -M-62 M-63
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/41ed19d67a06ba42c935517d395e590c9e3fb282

commit 41ed19d67a06ba42c935517d395e590c9e3fb282
Author: Marc Treib <treib@chromium.org>
Date: Tue Aug 22 09:17:13 2017

Add support for third-party doodles on the Android NTP

This adds a 'doodle_url' field to prepopulated_engines.json, and plumbs
it through to the LogoService. It also adds a command line flag
--third-party-doodle-url for testing, and a feature
ThirdPartyDoodles (disabled by default).

This is a follow-up to https://chromium-review.googlesource.com/c/539417
and  https://crbug.com/725435 .

Bug:  752453 
Change-Id: Iaf6e14d5b60069ea58875ed891240bbab26d559a
Reviewed-on: https://chromium-review.googlesource.com/608136
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496258}
[modify] https://crrev.com/41ed19d67a06ba42c935517d395e590c9e3fb282/chrome/browser/search_engines/template_url_service_android.cc
[modify] https://crrev.com/41ed19d67a06ba42c935517d395e590c9e3fb282/components/search_engines/default_search_manager.cc
[modify] https://crrev.com/41ed19d67a06ba42c935517d395e590c9e3fb282/components/search_engines/default_search_manager.h
[modify] https://crrev.com/41ed19d67a06ba42c935517d395e590c9e3fb282/components/search_engines/prepopulated_engines_schema.json
[modify] https://crrev.com/41ed19d67a06ba42c935517d395e590c9e3fb282/components/search_engines/template_url.h
[modify] https://crrev.com/41ed19d67a06ba42c935517d395e590c9e3fb282/components/search_engines/template_url_data.cc
[modify] https://crrev.com/41ed19d67a06ba42c935517d395e590c9e3fb282/components/search_engines/template_url_data.h
[modify] https://crrev.com/41ed19d67a06ba42c935517d395e590c9e3fb282/components/search_engines/template_url_data_util.cc
[modify] https://crrev.com/41ed19d67a06ba42c935517d395e590c9e3fb282/components/search_engines/template_url_prepopulate_data_unittest.cc
[modify] https://crrev.com/41ed19d67a06ba42c935517d395e590c9e3fb282/components/search_provider_logos/features.cc
[modify] https://crrev.com/41ed19d67a06ba42c935517d395e590c9e3fb282/components/search_provider_logos/features.h
[modify] https://crrev.com/41ed19d67a06ba42c935517d395e590c9e3fb282/components/search_provider_logos/google_logo_api.h
[modify] https://crrev.com/41ed19d67a06ba42c935517d395e590c9e3fb282/components/search_provider_logos/logo_service.cc
[modify] https://crrev.com/41ed19d67a06ba42c935517d395e590c9e3fb282/components/search_provider_logos/switches.cc
[modify] https://crrev.com/41ed19d67a06ba42c935517d395e590c9e3fb282/components/search_provider_logos/switches.h
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/93af46ababf16ef0b9056ac945ad325117ce6bb1

commit 93af46ababf16ef0b9056ac945ad325117ce6bb1
Author: Marc Treib <treib@chromium.org>
Date: Wed Aug 23 13:30:00 2017

Third-party doodles: Add an about:flags entry for testing

Bug:  752453 
Change-Id: I597070d6d98d1e6bc0d14c9c9a970261d171a95b
Reviewed-on: https://chromium-review.googlesource.com/618711
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496668}
[modify] https://crrev.com/93af46ababf16ef0b9056ac945ad325117ce6bb1/chrome/browser/about_flags.cc
[modify] https://crrev.com/93af46ababf16ef0b9056ac945ad325117ce6bb1/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/93af46ababf16ef0b9056ac945ad325117ce6bb1/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/93af46ababf16ef0b9056ac945ad325117ce6bb1/chrome/browser/search_engines/template_url_service_android.cc
[modify] https://crrev.com/93af46ababf16ef0b9056ac945ad325117ce6bb1/components/search_provider_logos/features.cc
[modify] https://crrev.com/93af46ababf16ef0b9056ac945ad325117ce6bb1/components/search_provider_logos/features.h
[modify] https://crrev.com/93af46ababf16ef0b9056ac945ad325117ce6bb1/components/search_provider_logos/logo_service.cc
[modify] https://crrev.com/93af46ababf16ef0b9056ac945ad325117ce6bb1/tools/metrics/histograms/enums.xml
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 5 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/54d379bc0a71fbaeeb5f74dfc3f21f94d343a291

commit 54d379bc0a71fbaeeb5f74dfc3f21f94d343a291
Author: Marc Treib <treib@chromium.org>
Date: Tue Sep 05 15:31:39 2017

Enable ThirdPartyDoodles by default

Bug:  752453 
Change-Id: I43c79081e7687e3e2042efe857ac0959872d1414
Reviewed-on: https://chromium-review.googlesource.com/650292
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499642}
[modify] https://crrev.com/54d379bc0a71fbaeeb5f74dfc3f21f94d343a291/components/search_provider_logos/features.cc

Comment 8 by treib@chromium.org, Sep 12 2017

Status: Fixed (was: Started)
►

Sign in to add a comment