New issue
Advanced search Search tips

Issue 752428 link

Starred by 4 users

Issue metadata

Status: Started
Owner:
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----

Blocked on:
issue 746958



Sign in to add a comment

don't exclude source files from v8 jumbo compilation units

Reported by most...@opera.com, Aug 4 2017

Issue description

In  crbug.com/746958  we started adding jumbo compile support to v8, but excluded some source files from jumbo due to symbol clashes that were not trivial to resolve (these source files are still built, just standalone rather than in a jumbo compilation unit).  Let's try to fix these symbol clashes and no longer exclude files from v8 jumbo compilation.
 

Comment 1 by most...@opera.com, Aug 4 2017

Blockedon: 746958

Comment 2 by most...@opera.com, Aug 9 2017

Status: Assigned (was: Untriaged)

Comment 3 by most...@opera.com, Aug 9 2017

Status: Started (was: Assigned)
First fix: https://chromium-review.googlesource.com/608961
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/66ae347963e29bb89ac3cb3bb9099dbd2899c0d6

commit 66ae347963e29bb89ac3cb3bb9099dbd2899c0d6
Author: Mostyn Bramley-Moore <mostynb@opera.com>
Date: Wed Aug 23 10:27:44 2017

jumbo: Include src/compiler/*linkage.cc in jumbo compilation units

BUG=chromium:752428

Change-Id: I0d1f3a09ecd2ffb7bfd8120b212e88fd00008fc0
Reviewed-on: https://chromium-review.googlesource.com/608961
Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
Commit-Queue: Mostyn Bramley-Moore <mostynb@opera.com>
Cr-Commit-Position: refs/heads/master@{#47544}
[modify] https://crrev.com/66ae347963e29bb89ac3cb3bb9099dbd2899c0d6/BUILD.gn
[modify] https://crrev.com/66ae347963e29bb89ac3cb3bb9099dbd2899c0d6/src/compiler/c-linkage.cc
[modify] https://crrev.com/66ae347963e29bb89ac3cb3bb9099dbd2899c0d6/src/compiler/wasm-linkage.cc

Comment 5 by most...@vewd.com, Sep 28 2017

Owner: most...@vewd.com
Labels: Pri-2
Setting defect without priority to Pri-2.

Sign in to add a comment