New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 752410 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

81%-91.4% improvement in system_health.common_desktop at 490728:490891

Project Member Reported by alexclarke@chromium.org, Aug 4 2017

Issue description

Suspiciously large improvements, did something break?
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=752410

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=1ea79907f63a04bae89b057fabde5bd8a5d4f0739cd8ff13d63a75fdd43811f1


Bot(s) for this bug's original alert(s):

chromium-rel-mac11
chromium-rel-mac12
chromium-rel-mac12-mini-8gb
chromium-rel-win10
chromium-rel-win7-dual
chromium-rel-win7-x64-dual
win-high-dpi
Cc: xunji...@chromium.org
Owner: xunji...@chromium.org

=== Auto-CCing suspected CL author xunjieli@chromium.org ===

Hi xunjieli@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Helen Li
  Commit : 05ee1dbfaf0aa7c03b9ea2040f0345277042d0f1
  Date   : Mon Jul 31 13:24:01 2017
  Subject: [wpr-go] Switch system_health_desktop.json to use go

Bisect Details
  Configuration: mac_10_11_perf_bisect
  Benchmark    : system_health.common_desktop
  Metric       : cpu_time_percentage_avg/load_tools/load_tools_weather
  Change       : 81.26% | 0.36328764883 -> 0.0680626804712

Revision             Result                       N
chromium@490739      0.363288 +- 0.00604996       6      good
chromium@490748      0.365904 +- 0.00353867       6      good
chromium@490750      0.367393 +- 0.0120727        6      good
chromium@490751      0.0692455 +- 0.00413763      6      bad       <--
chromium@490752      0.0680797 +- 0.00638183      6      bad
chromium@490756      0.0688467 +- 0.0034088       6      bad
chromium@490772      0.0680627 +- 0.00398044      6      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=load.tools.weather system_health.common_desktop

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8972207534981162464


For feedback, file a bug with component Speed>Bisection
Status: Assigned (was: Untriaged)
Thanks for filing the alert. 
This is fixed in last night's catapult roll (eb34528a8b674bea3e27dd45496e7d2201a0ba05). 

The metrics are back to the original values. I will keep the bug open to keep track of the graphs.
Status: Fixed (was: Assigned)
Thanks, I confirm that this is fixed in 357e1deefca78c61e457f340270c9cd6f38321f5. All grouped metrics are back at their original value before the wpr-go switch (05ee1dbfaf0aa7c03b9ea2040f0345277042d0f1).

Sign in to add a comment