New issue
Advanced search Search tips

Issue 752406 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 674692
Owner: ----
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[WPT import] imports failing due to DCHECKS in CQ

Project Member Reported by foolip@chromium.org, Aug 4 2017

Issue description

wpt-importer has been failing due to CQ not passing recently:
https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/419
https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/420

These are the reviews:
https://chromium-review.googlesource.com/601352
https://chromium-review.googlesource.com/601748

In both cases, external/wpt/css/css-ui-3/text-overflow-011.html was added and no changes to TestExpectations were made, but that test crashed on a failed DCHECK in CQ:

STDERR: [1:1:0803/234103.319600:42755341249:FATAL:TextPainter.cpp(58)] Check failed: from <= text_run_paint_info.run.length(). 

This is related to issue 674692. However, enabling DCHECKS on some try bots isn't the only potential fix here, could one not instead use failing CQ bots to update expectations and try again? (This rinse-and-repeat approach is effectively what bit.ly/ecosystem-infra-rotation suggests doing manually.)
 
Summary: [WPT import] imports failing due to DCHECKS in CQ (was: [WPT import] )
Mergedinto: 674692
Status: Duplicate (was: Untriaged)

Sign in to add a comment